This is an automatically generated bug from the commit-queue. platform/mac/editing/deleting/deletionUI-single-instance.html has been flaky on the commit-queue. platform/mac/editing/deleting/deletionUI-single-instance.html was authored by rniwa@webkit.org. http://trac.webkit.org/browser/trunk/LayoutTests/platform/mac/editing/deleting/deletionUI-single-instance.html The commit-queue just saw platform/mac/editing/deleting/deletionUI-single-instance.html flake (text diff) while processing attachment 196863 [details] on bug 114172. Bot: webkit-cq-03 Port: <class 'webkitpy.common.config.ports.MacPort'> Platform: Mac OS X 10.8.3 The bots will update this with information from each new failure. If you believe this bug to be fixed or invalid, feel free to close. The bots will re-open if the flake re-occurs. If you would like to track this test fix with another bug, please close this bug as a duplicate. The bots will follow the duplicate chain when making future comments.
Created attachment 196884 [details] Archive of layout-test-results from webkit-cq-03
The commit-queue just saw platform/mac/editing/deleting/deletionUI-single-instance.html flake (text diff) while processing attachment 196841 [details] on bug 114155. Bot: webkit-cq-01 Port: <class 'webkitpy.common.config.ports.MacPort'> Platform: Mac OS X 10.8.3
Created attachment 196913 [details] Archive of layout-test-results from webkit-cq-01
The commit-queue just saw platform/mac/editing/deleting/deletionUI-single-instance.html flake (text diff) while processing attachment 197031 [details] on bug 114269. Bot: webkit-cq-03 Port: <class 'webkitpy.common.config.ports.MacPort'> Platform: Mac OS X 10.8.3
Created attachment 197042 [details] Archive of layout-test-results from webkit-cq-03
The commit-queue just saw platform/mac/editing/deleting/deletionUI-single-instance.html flake (text diff) while processing attachment 197034 [details] on bug 85934. Bot: webkit-cq-02 Port: <class 'webkitpy.common.config.ports.MacPort'> Platform: Mac OS X 10.8.3
Created attachment 197098 [details] Archive of layout-test-results from webkit-cq-02
The commit-queue just saw platform/mac/editing/deleting/deletionUI-single-instance.html flake (text diff) while processing attachment 197099 [details] on bug 114283. Bot: webkit-cq-03 Port: <class 'webkitpy.common.config.ports.MacPort'> Platform: Mac OS X 10.8.3
Created attachment 197103 [details] Archive of layout-test-results from webkit-cq-03
The commit-queue just saw platform/mac/editing/deleting/deletionUI-single-instance.html flake (text diff) while processing attachment 197237 [details] on bug 114346. Bot: webkit-cq-03 Port: <class 'webkitpy.common.config.ports.MacPort'> Platform: Mac OS X 10.8.3
Created attachment 197275 [details] Archive of layout-test-results from webkit-cq-03
The commit-queue just saw platform/mac/editing/deleting/deletionUI-single-instance.html flake (text diff) while processing attachment 197222 [details] on bug 114290. Bot: webkit-cq-02 Port: <class 'webkitpy.common.config.ports.MacPort'> Platform: Mac OS X 10.8.3
Created attachment 197318 [details] Archive of layout-test-results from webkit-cq-02
The commit-queue just saw platform/mac/editing/deleting/deletionUI-single-instance.html flake (text diff) while processing attachment 197266 [details] on bug 114358. Bot: webkit-cq-03 Port: <class 'webkitpy.common.config.ports.MacPort'> Platform: Mac OS X 10.8.3
Created attachment 197359 [details] Archive of layout-test-results from webkit-cq-03
The commit-queue just saw platform/mac/editing/deleting/deletionUI-single-instance.html flake (text diff) while processing attachment 197414 [details] on bug 114390. Bot: webkit-cq-01 Port: <class 'webkitpy.common.config.ports.MacPort'> Platform: Mac OS X 10.8.3
Created attachment 197448 [details] Archive of layout-test-results from webkit-cq-01
The commit-queue just saw platform/mac/editing/deleting/deletionUI-single-instance.html flake (text diff) while processing attachment 197243 [details] on bug 114350. Bot: webkit-cq-03 Port: <class 'webkitpy.common.config.ports.MacPort'> Platform: Mac OS X 10.8.3
Created attachment 197468 [details] Archive of layout-test-results from webkit-cq-03
The commit-queue just saw platform/mac/editing/deleting/deletionUI-single-instance.html flake (text diff) while processing attachment 197526 [details] on bug 114423. Bot: webkit-cq-03 Port: <class 'webkitpy.common.config.ports.MacPort'> Platform: Mac OS X 10.8.3
Created attachment 197562 [details] Archive of layout-test-results from webkit-cq-03
The commit-queue just saw platform/mac/editing/deleting/deletionUI-single-instance.html flake (text diff) while processing attachment 197520 [details] on bug 114416. Bot: webkit-cq-01 Port: <class 'webkitpy.common.config.ports.MacPort'> Platform: Mac OS X 10.8.3
Created attachment 197625 [details] Archive of layout-test-results from webkit-cq-01
The commit-queue just saw platform/mac/editing/deleting/deletionUI-single-instance.html flake (text diff) while processing attachment 197736 [details] on bug 114437. Bot: webkit-cq-01 Port: <class 'webkitpy.common.config.ports.MacPort'> Platform: Mac OS X 10.8.3
Created attachment 197754 [details] Archive of layout-test-results from webkit-cq-01
The commit-queue just saw platform/mac/editing/deleting/deletionUI-single-instance.html flake (text diff) while processing attachment 197749 [details] on bug 114500. Bot: webkit-cq-01 Port: <class 'webkitpy.common.config.ports.MacPort'> Platform: Mac OS X 10.8.3
Created attachment 197785 [details] Archive of layout-test-results from webkit-cq-01
The commit-queue just saw platform/mac/editing/deleting/deletionUI-single-instance.html flake (text diff) while processing attachment 197746 [details] on bug 114503. Bot: webkit-cq-03 Port: <class 'webkitpy.common.config.ports.MacPort'> Platform: Mac OS X 10.8.3
Created attachment 197815 [details] Archive of layout-test-results from webkit-cq-03
The commit-queue just saw platform/mac/editing/deleting/deletionUI-single-instance.html flake (text diff) while processing attachment 198044 [details] on bug 114615. Bot: webkit-cq-01 Port: <class 'webkitpy.common.config.ports.MacPort'> Platform: Mac OS X 10.8.3
Created attachment 198079 [details] Archive of layout-test-results from webkit-cq-01
The commit-queue just saw platform/mac/editing/deleting/deletionUI-single-instance.html flake (text diff) while processing attachment 198082 [details] on bug 114468. Bot: webkit-cq-02 Port: <class 'webkitpy.common.config.ports.MacPort'> Platform: Mac OS X 10.8.3
Created attachment 198087 [details] Archive of layout-test-results from webkit-cq-02
The commit-queue just saw platform/mac/editing/deleting/deletionUI-single-instance.html flake (text diff) while processing attachment 198127 [details] on bug 114624. Bot: webkit-cq-03 Port: <class 'webkitpy.common.config.ports.MacPort'> Platform: Mac OS X 10.8.3
Created attachment 198140 [details] Archive of layout-test-results from webkit-cq-03
The commit-queue just saw platform/mac/editing/deleting/deletionUI-single-instance.html flake (text diff) while processing attachment 197888 [details] on bug 114534. Bot: webkit-cq-03 Port: <class 'webkitpy.common.config.ports.MacPort'> Platform: Mac OS X 10.8.3
Created attachment 198265 [details] Archive of layout-test-results from webkit-cq-03
The commit-queue just saw platform/mac/editing/deleting/deletionUI-single-instance.html flake (text diff) while processing attachment 196460 [details] on bug 113927. Bot: webkit-cq-01 Port: <class 'webkitpy.common.config.ports.MacPort'> Platform: Mac OS X 10.8.3
Created attachment 198313 [details] Archive of layout-test-results from webkit-cq-01
The commit-queue just saw platform/mac/editing/deleting/deletionUI-single-instance.html flake (text diff) while processing attachment 198274 [details] on bug 114511. Bot: webkit-cq-01 Port: <class 'webkitpy.common.config.ports.MacPort'> Platform: Mac OS X 10.8.3
Created attachment 198355 [details] Archive of layout-test-results from webkit-cq-01
The commit-queue just saw platform/mac/editing/deleting/deletionUI-single-instance.html flake (text diff) while processing attachment 198387 [details] on bug 108980. Bot: webkit-cq-02 Port: <class 'webkitpy.common.config.ports.MacPort'> Platform: Mac OS X 10.8.3
Created attachment 198397 [details] Archive of layout-test-results from webkit-cq-02
The commit-queue just saw platform/mac/editing/deleting/deletionUI-single-instance.html flake (text diff) while processing attachment 198509 [details] on bug 114654. Bot: webkit-cq-02 Port: <class 'webkitpy.common.config.ports.MacPort'> Platform: Mac OS X 10.8.3
Created attachment 198543 [details] Archive of layout-test-results from webkit-cq-02
The commit-queue just saw platform/mac/editing/deleting/deletionUI-single-instance.html flake (text diff) while processing attachment 198335 [details] on bug 114686. Bot: webkit-cq-03 Port: <class 'webkitpy.common.config.ports.MacPort'> Platform: Mac OS X 10.8.3
Created attachment 198547 [details] Archive of layout-test-results from webkit-cq-03
The commit-queue just saw platform/mac/editing/deleting/deletionUI-single-instance.html flake (text diff) while processing attachment 198631 [details] on bug 114773. Bot: webkit-cq-02 Port: <class 'webkitpy.common.config.ports.MacPort'> Platform: Mac OS X 10.8.3
Created attachment 198636 [details] Archive of layout-test-results from webkit-cq-02
The commit-queue just saw platform/mac/editing/deleting/deletionUI-single-instance.html flake (text diff) while processing attachment 198850 [details] on bug 109588. Bot: webkit-cq-03 Port: <class 'webkitpy.common.config.ports.MacPort'> Platform: Mac OS X 10.8.3
Created attachment 198859 [details] Archive of layout-test-results from webkit-cq-03
The commit-queue just saw platform/mac/editing/deleting/deletionUI-single-instance.html flake (text diff) while processing attachment 199053 [details] on bug 114970. Bot: webkit-cq-03 Port: <class 'webkitpy.common.config.ports.MacPort'> Platform: Mac OS X 10.8.3
Created attachment 199059 [details] Archive of layout-test-results from webkit-cq-03
The commit-queue just saw platform/mac/editing/deleting/deletionUI-single-instance.html flake (text diff) while processing attachment 199153 [details] on bug 115013. Bot: webkit-cq-01 Port: <class 'webkitpy.common.config.ports.MacPort'> Platform: Mac OS X 10.8.3
Created attachment 199173 [details] Archive of layout-test-results from webkit-cq-01
The commit-queue just saw platform/mac/editing/deleting/deletionUI-single-instance.html flake (text diff) while processing attachment 199245 [details] on bug 115029. Bot: webkit-cq-02 Port: <class 'webkitpy.common.config.ports.MacPort'> Platform: Mac OS X 10.8.3
Created attachment 199248 [details] Archive of layout-test-results from webkit-cq-02
The commit-queue just saw platform/mac/editing/deleting/deletionUI-single-instance.html flake (text diff) while processing attachment 199130 [details] on bug 114526. Bot: webkit-cq-01 Port: <class 'webkitpy.common.config.ports.MacPort'> Platform: Mac OS X 10.8.3
Created attachment 199283 [details] Archive of layout-test-results from webkit-cq-01
The commit-queue just saw platform/mac/editing/deleting/deletionUI-single-instance.html flake (text diff) while processing attachment 199342 [details] on bug 115068. Bot: webkit-cq-02 Port: <class 'webkitpy.common.config.ports.MacPort'> Platform: Mac OS X 10.8.3
Created attachment 199345 [details] Archive of layout-test-results from webkit-cq-02
The commit-queue just saw platform/mac/editing/deleting/deletionUI-single-instance.html flake (text diff) while processing attachment 199156 [details] on bug 114897. Bot: webkit-cq-02 Port: <class 'webkitpy.common.config.ports.MacPort'> Platform: Mac OS X 10.8.3
Created attachment 199451 [details] Archive of layout-test-results from webkit-cq-02
The commit-queue just saw platform/mac/editing/deleting/deletionUI-single-instance.html flake (text diff) while processing attachment 199412 [details] on bug 115099. Bot: webkit-cq-02 Port: <class 'webkitpy.common.config.ports.MacPort'> Platform: Mac OS X 10.8.3
Created attachment 199459 [details] Archive of layout-test-results from webkit-cq-02
The commit-queue just saw platform/mac/editing/deleting/deletionUI-single-instance.html flake (text diff) while processing attachment 199531 [details] on bug 115137. Bot: webkit-cq-02 Port: <class 'webkitpy.common.config.ports.MacPort'> Platform: Mac OS X 10.8.3
Created attachment 199540 [details] Archive of layout-test-results from webkit-cq-02
The commit-queue just saw platform/mac/editing/deleting/deletionUI-single-instance.html flake (text diff) while processing attachment 199517 [details] on bug 114218. Bot: webkit-cq-03 Port: <class 'webkitpy.common.config.ports.MacPort'> Platform: Mac OS X 10.8.3
Created attachment 199576 [details] Archive of layout-test-results from webkit-cq-03
The commit-queue just saw platform/mac/editing/deleting/deletionUI-single-instance.html flake (text diff) while processing attachment 199112 [details] on bug 113976. Bot: webkit-cq-02 Port: <class 'webkitpy.common.config.ports.MacPort'> Platform: Mac OS X 10.8.3
Created attachment 199726 [details] Archive of layout-test-results from webkit-cq-02
The commit-queue just saw platform/mac/editing/deleting/deletionUI-single-instance.html flake (text diff) while processing attachment 199925 [details] on bug 115318. Bot: webkit-cq-02 Port: <class 'webkitpy.common.config.ports.MacPort'> Platform: Mac OS X 10.8.3
Created attachment 199956 [details] Archive of layout-test-results from webkit-cq-02
The commit-queue just saw platform/mac/editing/deleting/deletionUI-single-instance.html flake (text diff) while processing attachment 200138 [details] on bug 115434. Bot: webkit-cq-01 Port: <class 'webkitpy.common.config.ports.MacPort'> Platform: Mac OS X 10.8.3
Created attachment 200153 [details] Archive of layout-test-results from webkit-cq-01
The commit-queue just saw platform/mac/editing/deleting/deletionUI-single-instance.html flake (text diff) while processing attachment 200255 [details] on bug 115495. Bot: webkit-cq-03 Port: <class 'webkitpy.common.config.ports.MacPort'> Platform: Mac OS X 10.8.3
Created attachment 200261 [details] Archive of layout-test-results from webkit-cq-03
The commit-queue just saw platform/mac/editing/deleting/deletionUI-single-instance.html flake (text diff) while processing attachment 200336 [details] on bug 115529. Bot: webkit-cq-01 Port: <class 'webkitpy.common.config.ports.MacPort'> Platform: Mac OS X 10.8.3
Created attachment 200338 [details] Archive of layout-test-results from webkit-cq-01
The commit-queue just saw platform/mac/editing/deleting/deletionUI-single-instance.html flake (text diff) while processing attachment 200467 [details] on bug 115573. Bot: webkit-cq-01 Port: <class 'webkitpy.common.config.ports.MacPort'> Platform: Mac OS X 10.8.3
Created attachment 200472 [details] Archive of layout-test-results from webkit-cq-01
The commit-queue just saw platform/mac/editing/deleting/deletionUI-single-instance.html flake (text diff) while processing attachment 200549 [details] on bug 115602. Bot: webkit-cq-03 Port: <class 'webkitpy.common.config.ports.MacPort'> Platform: Mac OS X 10.8.3
Created attachment 200554 [details] Archive of layout-test-results from webkit-cq-03
The commit-queue just saw platform/mac/editing/deleting/deletionUI-single-instance.html flake (text diff) while processing attachment 200589 [details] on bug 115611. Bot: webkit-cq-02 Port: <class 'webkitpy.common.config.ports.MacPort'> Platform: Mac OS X 10.8.3
Created attachment 200607 [details] Archive of layout-test-results from webkit-cq-02
The commit-queue just saw platform/mac/editing/deleting/deletionUI-single-instance.html flake (text diff) while processing attachment 200427 [details] on bug 114742. Bot: webkit-cq-02 Port: <class 'webkitpy.common.config.ports.MacPort'> Platform: Mac OS X 10.8.3
Created attachment 200677 [details] Archive of layout-test-results from webkit-cq-02
The commit-queue just saw platform/mac/editing/deleting/deletionUI-single-instance.html flake (text diff) while processing attachment 200720 [details] on bug 102105. Bot: webkit-cq-03 Port: <class 'webkitpy.common.config.ports.MacPort'> Platform: Mac OS X 10.8.3
Created attachment 200734 [details] Archive of layout-test-results from webkit-cq-03
The commit-queue just saw platform/mac/editing/deleting/deletionUI-single-instance.html flake (text diff) while processing attachment 200768 [details] on bug 113808. Bot: webkit-cq-02 Port: <class 'webkitpy.common.config.ports.MacPort'> Platform: Mac OS X 10.8.3
Created attachment 200804 [details] Archive of layout-test-results from webkit-cq-02
The commit-queue just saw platform/mac/editing/deleting/deletionUI-single-instance.html flake (text diff) while processing attachment 200805 [details] on bug 115672. Bot: webkit-cq-02 Port: <class 'webkitpy.common.config.ports.MacPort'> Platform: Mac OS X 10.8.3
Created attachment 200826 [details] Archive of layout-test-results from webkit-cq-02
The commit-queue just saw platform/mac/editing/deleting/deletionUI-single-instance.html flake (text diff) while processing attachment 201098 [details] on bug 115714. Bot: webkit-cq-01 Port: <class 'webkitpy.common.config.ports.MacPort'> Platform: Mac OS X 10.8.3
Created attachment 201140 [details] Archive of layout-test-results from webkit-cq-01
The commit-queue just saw platform/mac/editing/deleting/deletionUI-single-instance.html flake (text diff) while processing attachment 201190 [details] on bug 115857. Bot: webkit-cq-01 Port: <class 'webkitpy.common.config.ports.MacPort'> Platform: Mac OS X 10.8.3
Created attachment 201204 [details] Archive of layout-test-results from webkit-cq-01
The commit-queue just saw platform/mac/editing/deleting/deletionUI-single-instance.html flake (text diff) while processing attachment 201380 [details] on bug 115928. Bot: webkit-cq-03 Port: <class 'webkitpy.common.config.ports.MacPort'> Platform: Mac OS X 10.8.3
Created attachment 201386 [details] Archive of layout-test-results from webkit-cq-03
The commit-queue just saw platform/mac/editing/deleting/deletionUI-single-instance.html flake (text diff) while processing attachment 201421 [details] on bug 115456. Bot: webkit-cq-02 Port: <class 'webkitpy.common.config.ports.MacPort'> Platform: Mac OS X 10.8.3
Created attachment 201589 [details] Archive of layout-test-results from webkit-cq-02
The commit-queue just saw platform/mac/editing/deleting/deletionUI-single-instance.html flake (text diff) while processing attachment 201959 [details] on bug 116227. Bot: webkit-cq-01 Port: <class 'webkitpy.common.config.ports.MacPort'> Platform: Mac OS X 10.8.3
Created attachment 202041 [details] Archive of layout-test-results from webkit-cq-01
The commit-queue just saw platform/mac/editing/deleting/deletionUI-single-instance.html flake (text diff) while processing attachment 202335 [details] on bug 115531. Bot: webkit-cq-03 Port: <class 'webkitpy.common.config.ports.MacPort'> Platform: Mac OS X 10.8.3
Created attachment 202365 [details] Archive of layout-test-results from webkit-cq-03
The commit-queue just saw platform/mac/editing/deleting/deletionUI-single-instance.html flake (text diff) while processing attachment 202536 [details] on bug 116605. Bot: webkit-cq-01 Port: <class 'webkitpy.common.config.ports.MacPort'> Platform: Mac OS X 10.8.3
Created attachment 202543 [details] Archive of layout-test-results from webkit-cq-01
The commit-queue just saw platform/mac/editing/deleting/deletionUI-single-instance.html flake (text diff) while processing attachment 202573 [details] on bug 116581. Bot: webkit-cq-03 Port: <class 'webkitpy.common.config.ports.MacPort'> Platform: Mac OS X 10.8.3
Created attachment 202607 [details] Archive of layout-test-results from webkit-cq-03
The commit-queue just saw platform/mac/editing/deleting/deletionUI-single-instance.html flake (text diff) while processing attachment 202664 [details] on bug 116659. Bot: webkit-cq-02 Port: <class 'webkitpy.common.config.ports.MacPort'> Platform: Mac OS X 10.8.3
Created attachment 202678 [details] Archive of layout-test-results from webkit-cq-02
The commit-queue just saw platform/mac/editing/deleting/deletionUI-single-instance.html flake (text diff) while processing attachment 203149 [details] on bug 116951. Bot: webkit-cq-02 Port: <class 'webkitpy.common.config.ports.MacPort'> Platform: Mac OS X 10.8.3
Created attachment 203154 [details] Archive of layout-test-results from webkit-cq-02
The commit-queue just saw platform/mac/editing/deleting/deletionUI-single-instance.html flake (text diff) while processing attachment 203217 [details] on bug 116954. Bot: webkit-cq-01 Port: <class 'webkitpy.common.config.ports.MacPort'> Platform: Mac OS X 10.8.3
Created attachment 203221 [details] Archive of layout-test-results from webkit-cq-01
The commit-queue just saw platform/mac/editing/deleting/deletionUI-single-instance.html flake (text diff) while processing attachment 203812 [details] on bug 117222. Bot: webkit-cq-01 Port: <class 'webkitpy.common.config.ports.MacPort'> Platform: Mac OS X 10.8.3
Created attachment 203815 [details] Archive of layout-test-results from webkit-cq-01
The commit-queue just saw platform/mac/editing/deleting/deletionUI-single-instance.html flake (text diff) while processing attachment 204185 [details] on bug 117416. Bot: webkit-cq-01 Port: <class 'webkitpy.common.config.ports.MacPort'> Platform: Mac OS X 10.8.3
Created attachment 204194 [details] Archive of layout-test-results from webkit-cq-01
The commit-queue just saw platform/mac/editing/deleting/deletionUI-single-instance.html flake (text diff) while processing attachment 204225 [details] on bug 117441. Bot: webkit-cq-01 Port: <class 'webkitpy.common.config.ports.MacPort'> Platform: Mac OS X 10.8.3
Created attachment 204232 [details] Archive of layout-test-results from webkit-cq-01
The commit-queue just saw platform/mac/editing/deleting/deletionUI-single-instance.html flake (text diff) while processing attachment 204297 [details] on bug 117295. Bot: webkit-cq-01 Port: <class 'webkitpy.common.config.ports.MacPort'> Platform: Mac OS X 10.8.3
Created attachment 204300 [details] Archive of layout-test-results from webkit-cq-01
The commit-queue just saw platform/mac/editing/deleting/deletionUI-single-instance.html flake (text diff) while processing attachment 204380 [details] on bug 117528. Bot: webkit-cq-01 Port: <class 'webkitpy.common.config.ports.MacPort'> Platform: Mac OS X 10.8.3
Created attachment 204414 [details] Archive of layout-test-results from webkit-cq-01
The commit-queue just saw platform/mac/editing/deleting/deletionUI-single-instance.html flake (text diff) while processing attachment 204464 [details] on bug 116745. Bot: webkit-cq-02 Port: <class 'webkitpy.common.config.ports.MacPort'> Platform: Mac OS X 10.8.3
Created attachment 204495 [details] Archive of layout-test-results from webkit-cq-02
The commit-queue just saw platform/mac/editing/deleting/deletionUI-single-instance.html flake (text diff) while processing attachment 204497 [details] on bug 117557. Bot: webkit-cq-02 Port: <class 'webkitpy.common.config.ports.MacPort'> Platform: Mac OS X 10.8.3
Created attachment 204502 [details] Archive of layout-test-results from webkit-cq-02
The commit-queue just saw platform/mac/editing/deleting/deletionUI-single-instance.html flake (text diff) while processing attachment 204587 [details] on bug 117593. Bot: webkit-cq-02 Port: <class 'webkitpy.common.config.ports.MacPort'> Platform: Mac OS X 10.8.3
Created attachment 204590 [details] Archive of layout-test-results from webkit-cq-02
Created attachment 210493 [details] proposed fix
Comment on attachment 210493 [details] proposed fix Clearing flags on attachment: 210493 Committed r155161: <http://trac.webkit.org/changeset/155161>
All reviewed patches have been landed. Closing bug.
Comment on attachment 210493 [details] proposed fix View in context: https://bugs.webkit.org/attachment.cgi?id=210493&action=review > Source/WebCore/editing/Editor.cpp:926 > + m_deleteButtonController = adoptPtr(new DeleteButtonController(&m_frame)); I would prefer that we reset the delete button controller rather than destroying it and creating a new one. I’m not sure the delete button controller should be allocated on the heap.
Interestingly, Ryosuke and myself considered deleting and re-creating the whole Editor in the future, as explicit clear() is a recipe for ongoing trouble like this. What is the benefit of clearing as opposed to re-creating such long-lived objects?
(In reply to comment #136) > Interestingly, Ryosuke and myself considered deleting and re-creating the whole Editor in the future, as explicit clear() is a recipe for ongoing trouble like this. > > What is the benefit of clearing as opposed to re-creating such long-lived objects? Not sure there are benefits. I can think of a few possible benefits that may or may not be true: 1) Recreating the objects invalidates outstanding pointers and references to the objects, and so could lead to accessing deallocated memory if it happened inside a function that was holding a pointer or reference. 2) Memory allocation and deallocation are costly; clearing might be significantly faster. 3) Being able to delete and recreate the object requires allocating a separate object on the heap. This uses slightly more memory, and maybe could give us less locality of reference, and requires additional pointer loads than embedding the object inside the object that owns it. If the object needs a lifetime tied to a document, maybe it should be associated with the document lifetime rather than the frame in a more direct way rather than being associated with the frame and re-allocated each time the frame hosts a new document.