Bug 114526 - [CSS Exclusions] shape-inside overflow should be pushed to the outside of the content box
Summary: [CSS Exclusions] shape-inside overflow should be pushed to the outside of the...
Alias: None
Product: WebKit
Classification: Unclassified
Component: CSS (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Zoltan Horvath
Depends on:
Blocks: 89256 115001 115053
  Show dependency treegraph
Reported: 2013-04-12 12:57 PDT by Bear Travis
Modified: 2013-04-23 13:15 PDT (History)
4 users (show)

See Also:

proposed patch (35.08 KB, patch)
2013-04-22 16:40 PDT, Zoltan Horvath
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Bear Travis 2013-04-12 12:57:17 PDT
The specification has changed to define shape-outside as the inverse of an exclusion. Overflowing content should not overlap the shape, and it should be pushed outside the content box.
Comment 1 Zoltan Horvath 2013-04-22 16:40:42 PDT
Created attachment 199130 [details]
proposed patch
Comment 2 Zoltan Horvath 2013-04-22 17:05:40 PDT
I'm going to change the behavior for shape-inside on regions separately in bug #115001.
Comment 3 Dave Hyatt 2013-04-23 10:42:34 PDT
Comment on attachment 199130 [details]
proposed patch

Comment 4 WebKit Commit Bot 2013-04-23 11:21:28 PDT
The commit-queue encountered the following flaky tests while processing attachment 199130 [details]:

http/tests/security/mixedContent/redirect-https-to-http-iframe-in-main-frame.html bug 114208 (authors: abarth@webkit.org and rniwa@webkit.org)
media/media-element-play-after-eos.html bug 115048 (authors: fischman@chromium.org and pnormand@igalia.com)
fast/loader/javascript-url-in-object.html bug 114210 (authors: rniwa@webkit.org and sam@webkit.org)
platform/mac/editing/deleting/deletionUI-single-instance.html bug 114181 (author: rniwa@webkit.org)
svg/batik/filters/feTile.svg bug 114375 (authors: krit@webkit.org and zimmermann@kde.org)
transitions/color-transition-rounding.html bug 114182 (author: simon.fraser@apple.com)
transitions/cubic-bezier-overflow-svg-length.html bug 114183 (author: peter@chromium.org)
transitions/interrupt-zero-duration.html bug 114184 (authors: cmarrin@apple.com, rniwa@webkit.org, and simon.fraser@apple.com)
transitions/multiple-background-transitions.html bug 114185 (author: simon.fraser@apple.com)
transitions/cubic-bezier-overflow-color.html bug 114186 (author: peter@chromium.org)
transitions/multiple-shadow-transitions.html bug 114187 (author: simon.fraser@apple.com)
transitions/mismatched-shadow-transitions.html bug 114188 (author: simon.fraser@apple.com)
transitions/color-transition-all.html bug 114189 (authors: ossy@webkit.org and simon.fraser@apple.com)
transitions/negative-delay.html bug 114190 (author: simon.fraser@apple.com)
transitions/cubic-bezier-overflow-shadow.html bug 114191 (author: peter@chromium.org)
transitions/min-max-width-height-transitions.html bug 114192 (author: simon.fraser@apple.com)
transitions/cancel-transition.html bug 114193 (authors: ojan@chromium.org, rniwa@webkit.org, and simon.fraser@apple.com)
transitions/border-radius-transition.html bug 114194 (author: simon.fraser@apple.com)
transitions/flex-transitions.html bug 114195 (author: tony@chromium.org)
transitions/mixed-type.html bug 114196 (author: mikelawther@chromium.org)
transitions/multiple-mask-transitions.html bug 114197 (author: simon.fraser@apple.com)
transitions/color-transition-premultiplied.html bug 114198 (author: simon.fraser@apple.com)
transitions/mismatched-shadow-styles.html bug 114199 (author: simon.fraser@apple.com)
transitions/mask-transitions.html bug 114200 (authors: ojan@chromium.org, oliver@apple.com, and simon.fraser@apple.com)
transitions/cubic-bezier-overflow-length.html bug 114201 (author: peter@chromium.org)
transitions/multiple-background-size-transitions.html bug 114202 (authors: mitz@webkit.org and simon.fraser@apple.com)
transitions/clip-transition.html bug 114203 (authors: dglazkov@chromium.org and simon.fraser@apple.com)
transitions/cubic-bezier-overflow-transform.html bug 114204 (author: peter@chromium.org)
transitions/interrupted-accelerated-transition.html bug 56242 (authors: rniwa@webkit.org, simon.fraser@apple.com, and tonyg@chromium.org)
transitions/background-transitions.html bug 114206 (author: simon.fraser@apple.com)
The commit-queue is continuing to process your patch.
Comment 5 WebKit Commit Bot 2013-04-23 11:22:27 PDT
Comment on attachment 199130 [details]
proposed patch

Clearing flags on attachment: 199130

Committed r148975: <http://trac.webkit.org/changeset/148975>
Comment 6 WebKit Commit Bot 2013-04-23 11:22:31 PDT
All reviewed patches have been landed.  Closing bug.