Bug 114468 – color-index media feature not supported

• Status: RESOLVED
• Resolution: FIXED
• Component: CSS

[Rune Lillesveen]

Created attachment 197681 [details]
Testcase detecting color-index support

The color-index media feature from CSS Media Queries[1] is not supported or recognized.

[1] http://www.w3.org/TR/css3-mediaqueries/

[Rune Lillesveen]

Created attachment 197682 [details]
Patch

[WebKit Commit Bot]

Attachment 197682 [details] did not pass style-queue:

Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'LayoutTests/ChangeLog', u'LayoutTests/fast/media/mq-color-index-01-expected.html', u'LayoutTests/fast/media/mq-color-index-01.html', u'LayoutTests/fast/media/mq-color-index-02-expected.txt', u'LayoutTests/fast/media/mq-color-index-02.html', u'Source/WebCore/ChangeLog', u'Source/WebCore/css/MediaFeatureNames.h', u'Source/WebCore/css/MediaQueryEvaluator.cpp', u'Source/WebCore/css/MediaQueryExp.cpp']" exit_code: 1
Source/WebCore/css/MediaQueryEvaluator.cpp:219:  color_indexMediaFeatureEval is incorrectly named. Don't use underscores in your identifier names.  [readability/naming/underscores] [4]
Source/WebCore/css/MediaQueryEvaluator.cpp:434:  min_color_indexMediaFeatureEval is incorrectly named. Don't use underscores in your identifier names.  [readability/naming/underscores] [4]
Source/WebCore/css/MediaQueryEvaluator.cpp:439:  max_color_indexMediaFeatureEval is incorrectly named. Don't use underscores in your identifier names.  [readability/naming/underscores] [4]
Total errors found: 3 in 9 files


If any of these errors are false positives, please file a bug against check-webkit-style.

[Build Bot]

Comment on attachment 197682 [details]
Patch

Attachment 197682 [details] did not pass mac-ews (mac):
Output: http://webkit-queues.appspot.com/results/103033

[Build Bot]

Comment on attachment 197682 [details]
Patch

Attachment 197682 [details] did not pass mac-wk2-ews (mac-wk2):
Output: http://webkit-queues.appspot.com/results/106028

[Rune Lillesveen]

Created attachment 197730 [details]
Patch

[WebKit Commit Bot]

Attachment 197730 [details] did not pass style-queue:

Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'LayoutTests/ChangeLog', u'LayoutTests/fast/media/mq-color-index-01-expected.html', u'LayoutTests/fast/media/mq-color-index-01.html', u'LayoutTests/fast/media/mq-color-index-02-expected.txt', u'LayoutTests/fast/media/mq-color-index-02.html', u'Source/WebCore/ChangeLog', u'Source/WebCore/css/MediaFeatureNames.h', u'Source/WebCore/css/MediaQueryEvaluator.cpp', u'Source/WebCore/css/MediaQueryExp.cpp']" exit_code: 1
Source/WebCore/css/MediaQueryEvaluator.cpp:219:  color_indexMediaFeatureEval is incorrectly named. Don't use underscores in your identifier names.  [readability/naming/underscores] [4]
Source/WebCore/css/MediaQueryEvaluator.cpp:435:  min_color_indexMediaFeatureEval is incorrectly named. Don't use underscores in your identifier names.  [readability/naming/underscores] [4]
Source/WebCore/css/MediaQueryEvaluator.cpp:440:  max_color_indexMediaFeatureEval is incorrectly named. Don't use underscores in your identifier names.  [readability/naming/underscores] [4]
Total errors found: 3 in 9 files


If any of these errors are false positives, please file a bug against check-webkit-style.

[Kenneth Rohde Christiansen]

Comment on attachment 197730 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=197730&action=review

> Source/WebCore/css/MediaQueryEvaluator.cpp:246
> +    if (value)
> +        return numberValue(value, number) && compareValue(0, static_cast<int>(number), op);
> +
> +    return false;

I would prefer 

if (!value)
    return

return number...

[Rune Lillesveen]

Created attachment 198075 [details]
Patch

[WebKit Commit Bot]

Attachment 198075 [details] did not pass style-queue:

Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'LayoutTests/ChangeLog', u'LayoutTests/fast/media/mq-color-index-01-expected.html', u'LayoutTests/fast/media/mq-color-index-01.html', u'LayoutTests/fast/media/mq-color-index-02-expected.txt', u'LayoutTests/fast/media/mq-color-index-02.html', u'Source/WebCore/ChangeLog', u'Source/WebCore/css/MediaFeatureNames.h', u'Source/WebCore/css/MediaQueryEvaluator.cpp', u'Source/WebCore/css/MediaQueryExp.cpp']" exit_code: 1
Source/WebCore/css/MediaQueryEvaluator.cpp:219:  color_indexMediaFeatureEval is incorrectly named. Don't use underscores in your identifier names.  [readability/naming/underscores] [4]
Source/WebCore/css/MediaQueryEvaluator.cpp:435:  min_color_indexMediaFeatureEval is incorrectly named. Don't use underscores in your identifier names.  [readability/naming/underscores] [4]
Source/WebCore/css/MediaQueryEvaluator.cpp:440:  max_color_indexMediaFeatureEval is incorrectly named. Don't use underscores in your identifier names.  [readability/naming/underscores] [4]
Total errors found: 3 in 9 files


If any of these errors are false positives, please file a bug against check-webkit-style.

[Kenneth Rohde Christiansen]

Comment on attachment 198075 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=198075&action=review

> Source/WebCore/css/MediaQueryEvaluator.cpp:238
> +static bool color_indexMediaFeatureEval(CSSValue* value, RenderStyle*, Frame* frame, MediaFeaturePrefix op)
> +{
> +    UNUSED_PARAM(frame);

I would just not add frame, ie just Frame*

[Rune Lillesveen]

Created attachment 198080 [details]
Patch

[WebKit Commit Bot]

Attachment 198080 [details] did not pass style-queue:

Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'LayoutTests/ChangeLog', u'LayoutTests/fast/media/mq-color-index-01-expected.html', u'LayoutTests/fast/media/mq-color-index-01.html', u'LayoutTests/fast/media/mq-color-index-02-expected.txt', u'LayoutTests/fast/media/mq-color-index-02.html', u'Source/WebCore/ChangeLog', u'Source/WebCore/css/MediaFeatureNames.h', u'Source/WebCore/css/MediaQueryEvaluator.cpp', u'Source/WebCore/css/MediaQueryExp.cpp']" exit_code: 1
Source/WebCore/css/MediaQueryEvaluator.cpp:219:  color_indexMediaFeatureEval is incorrectly named. Don't use underscores in your identifier names.  [readability/naming/underscores] [4]
Source/WebCore/css/MediaQueryEvaluator.cpp:433:  min_color_indexMediaFeatureEval is incorrectly named. Don't use underscores in your identifier names.  [readability/naming/underscores] [4]
Source/WebCore/css/MediaQueryEvaluator.cpp:438:  max_color_indexMediaFeatureEval is incorrectly named. Don't use underscores in your identifier names.  [readability/naming/underscores] [4]
Total errors found: 3 in 9 files


If any of these errors are false positives, please file a bug against check-webkit-style.

[Kenneth Rohde Christiansen]

When something is reviewed, and there are reviewer comments, feel free to fill in the Reviewed by line and just set cq?

[Rune Lillesveen]

Created attachment 198082 [details]
Patch

[WebKit Commit Bot]

Attachment 198082 [details] did not pass style-queue:

Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'LayoutTests/ChangeLog', u'LayoutTests/fast/media/mq-color-index-01-expected.html', u'LayoutTests/fast/media/mq-color-index-01.html', u'LayoutTests/fast/media/mq-color-index-02-expected.txt', u'LayoutTests/fast/media/mq-color-index-02.html', u'Source/WebCore/ChangeLog', u'Source/WebCore/css/MediaFeatureNames.h', u'Source/WebCore/css/MediaQueryEvaluator.cpp', u'Source/WebCore/css/MediaQueryExp.cpp']" exit_code: 1
Source/WebCore/css/MediaQueryEvaluator.cpp:219:  color_indexMediaFeatureEval is incorrectly named. Don't use underscores in your identifier names.  [readability/naming/underscores] [4]
Source/WebCore/css/MediaQueryEvaluator.cpp:433:  min_color_indexMediaFeatureEval is incorrectly named. Don't use underscores in your identifier names.  [readability/naming/underscores] [4]
Source/WebCore/css/MediaQueryEvaluator.cpp:438:  max_color_indexMediaFeatureEval is incorrectly named. Don't use underscores in your identifier names.  [readability/naming/underscores] [4]
Total errors found: 3 in 9 files


If any of these errors are false positives, please file a bug against check-webkit-style.

[Kenneth Rohde Christiansen]

Comment on attachment 198082 [details]
Patch

then you don't need to set r? Btw there is a script git-add-reviewer HEAD "name" that you might wish to use.

[Rune Lillesveen]

(In reply to comment #16)
> (From update of attachment 198082 [details])
> then you don't need to set r? Btw there is a script git-add-reviewer HEAD "name" that you might wish to use.

Ah, ok. Thanks!

[WebKit Commit Bot]

The commit-queue encountered the following flaky tests while processing attachment 198082 [details]:

http/tests/ssl/ping-with-unsafe-redirect.html bug 114616 (author: [e-mail])
http/tests/security/mixedContent/redirect-https-to-http-iframe-in-main-frame.html bug 114208 (authors: [e-mail] and [e-mail])
media/track/track-mode.html bug 114361 (author: [e-mail])
fast/loader/javascript-url-in-object.html bug 114210 (authors: [e-mail] and [e-mail])
platform/mac/editing/deleting/deletionUI-single-instance.html bug 114181 (author: [e-mail])
svg/batik/filters/feTile.svg bug 114375 (authors: [e-mail] and [e-mail])
transitions/color-transition-rounding.html bug 114182 (author: [e-mail])
transitions/cubic-bezier-overflow-svg-length.html bug 114183 (author: [e-mail])
transitions/interrupt-zero-duration.html bug 114184 (authors: [e-mail], [e-mail], and [e-mail])
transitions/multiple-background-transitions.html bug 114185 (author: [e-mail])
transitions/cubic-bezier-overflow-color.html bug 114186 (author: [e-mail])
transitions/multiple-shadow-transitions.html bug 114187 (author: [e-mail])
transitions/mismatched-shadow-transitions.html bug 114188 (author: [e-mail])
transitions/color-transition-all.html bug 114189 (authors: [e-mail] and [e-mail])
transitions/cubic-bezier-overflow-shadow.html bug 114191 (author: [e-mail])
transitions/min-max-width-height-transitions.html bug 114192 (author: [e-mail])
transitions/cancel-transition.html bug 114193 (authors: [e-mail], [e-mail], and [e-mail])
transitions/border-radius-transition.html bug 114194 (author: [e-mail])
transitions/flex-transitions.html bug 114195 (author: [e-mail])
transitions/mixed-type.html bug 114196 (author: [e-mail])
transitions/multiple-mask-transitions.html bug 114197 (author: [e-mail])
transitions/color-transition-premultiplied.html bug 114198 (author: [e-mail])
transitions/mismatched-shadow-styles.html bug 114199 (author: [e-mail])
transitions/mask-transitions.html bug 114200 (authors: [e-mail], [e-mail], and [e-mail])
transitions/cubic-bezier-overflow-length.html bug 114201 (author: [e-mail])
transitions/multiple-background-size-transitions.html bug 114202 (authors: [e-mail] and [e-mail])
transitions/clip-transition.html bug 114203 (authors: [e-mail] and [e-mail])
transitions/cubic-bezier-overflow-transform.html bug 114204 (author: [e-mail])
transitions/interrupted-accelerated-transition.html bug 56242 (authors: [e-mail], [e-mail], and [e-mail])
transitions/background-transitions.html bug 114206 (author: [e-mail])
The commit-queue is continuing to process your patch.

[WebKit Commit Bot]

Comment on attachment 198082 [details]
Patch

Clearing flags on attachment: 198082

Committed r148431: <http://trac.webkit.org/changeset/148431>

[WebKit Commit Bot]

All reviewed patches have been landed.  Closing bug.