Bug 114686 - [BlackBerry] Add support for filesystem: URLs to media player
Summary: [BlackBerry] Add support for filesystem: URLs to media player
Alias: None
Product: WebKit
Classification: Unclassified
Component: Media (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: John Griggs
Depends on:
Reported: 2013-04-16 09:09 PDT by John Griggs
Modified: 2013-04-17 08:55 PDT (History)
6 users (show)

See Also:

Patch (5.28 KB, patch)
2013-04-16 09:18 PDT, John Griggs
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description John Griggs 2013-04-16 09:09:41 PDT
Add support to allow the BlackBerry Media Player to load media resources identified by filesystem: URLs that refer to entities in the Web File System.
Comment 1 John Griggs 2013-04-16 09:18:34 PDT
Created attachment 198335 [details]
Comment 2 Rob Buis 2013-04-17 08:00:51 PDT
Comment on attachment 198335 [details]

View in context: https://bugs.webkit.org/attachment.cgi?id=198335&action=review

Looks good.

> Source/WebCore/ChangeLog:9
> +        Translate filesystem: URLs to file:// URLs for use by the media player, but only after the filesystem: URL has been checked for security, etc.

Next time please add the internal reviewer (Liam Quinn in this case).
Comment 3 WebKit Commit Bot 2013-04-17 08:54:34 PDT
The commit-queue encountered the following flaky tests while processing attachment 198335 [details]:

platform/mac/fonts/han-disunification.html bug 114207 (author: ap@webkit.org)
platform/mac/editing/deleting/deletionUI-single-instance.html bug 114181 (author: rniwa@webkit.org)
transitions/color-transition-rounding.html bug 114182 (author: simon.fraser@apple.com)
transitions/cubic-bezier-overflow-svg-length.html bug 114183 (author: peter@chromium.org)
transitions/interrupt-zero-duration.html bug 114184 (authors: cmarrin@apple.com, rniwa@webkit.org, and simon.fraser@apple.com)
transitions/multiple-background-transitions.html bug 114185 (author: simon.fraser@apple.com)
transitions/cubic-bezier-overflow-color.html bug 114186 (author: peter@chromium.org)
transitions/multiple-shadow-transitions.html bug 114187 (author: simon.fraser@apple.com)
transitions/mismatched-shadow-transitions.html bug 114188 (author: simon.fraser@apple.com)
transitions/color-transition-all.html bug 114189 (authors: ossy@webkit.org and simon.fraser@apple.com)
transitions/cubic-bezier-overflow-shadow.html bug 114191 (author: peter@chromium.org)
transitions/min-max-width-height-transitions.html bug 114192 (author: simon.fraser@apple.com)
transitions/cancel-transition.html bug 114193 (authors: ojan@chromium.org, rniwa@webkit.org, and simon.fraser@apple.com)
transitions/border-radius-transition.html bug 114194 (author: simon.fraser@apple.com)
transitions/flex-transitions.html bug 114195 (author: tony@chromium.org)
transitions/mixed-type.html bug 114196 (author: mikelawther@chromium.org)
transitions/multiple-mask-transitions.html bug 114197 (author: simon.fraser@apple.com)
transitions/color-transition-premultiplied.html bug 114198 (author: simon.fraser@apple.com)
transitions/mismatched-shadow-styles.html bug 114199 (author: simon.fraser@apple.com)
transitions/mask-transitions.html bug 114200 (authors: ojan@chromium.org, oliver@apple.com, and simon.fraser@apple.com)
transitions/cubic-bezier-overflow-length.html bug 114201 (author: peter@chromium.org)
transitions/multiple-background-size-transitions.html bug 114202 (authors: mitz@webkit.org and simon.fraser@apple.com)
transitions/clip-transition.html bug 114203 (authors: dglazkov@chromium.org and simon.fraser@apple.com)
transitions/cubic-bezier-overflow-transform.html bug 114204 (author: peter@chromium.org)
transitions/interrupted-accelerated-transition.html bug 56242 (authors: rniwa@webkit.org, simon.fraser@apple.com, and tonyg@chromium.org)
transitions/background-transitions.html bug 114206 (author: simon.fraser@apple.com)
http/tests/security/cookies/third-party-cookie-blocking-user-action.html bug 114511 (authors: ap@webkit.org, jochen@chromium.org, and rniwa@webkit.org)
http/tests/security/mixedContent/redirect-https-to-http-iframe-in-main-frame.html bug 114208 (authors: abarth@webkit.org and rniwa@webkit.org)
fast/loader/javascript-url-in-object.html bug 114210 (authors: rniwa@webkit.org and sam@webkit.org)
media/video-no-audio.html bug 114748 (authors: annacc@chromium.org, jamesr@chromium.org, rniwa@webkit.org, and vrk@chromium.org)
The commit-queue is continuing to process your patch.
Comment 4 WebKit Commit Bot 2013-04-17 08:55:28 PDT
Comment on attachment 198335 [details]

Clearing flags on attachment: 198335

Committed r148613: <http://trac.webkit.org/changeset/148613>
Comment 5 WebKit Commit Bot 2013-04-17 08:55:30 PDT
All reviewed patches have been landed.  Closing bug.