[Qt][EFL][GTK] fast/regions/overflow-size-change-with-stacking-context-rtl.html fails after r151202

[Gábor Ábrahám]

This test fails on Qt, GTK and EFL after r151202 could you check it please?

[Qt]
Test results: http://build.webkit.sed.hu/results/x86-64%20Linux%20Qt%20Release/r151266%20(51556)/results.html

Image: http://build.webkit.sed.hu/results/x86-64%20Linux%20Qt%20Release/r151266%20(51556)/fast/regions/overflow-size-change-with-stacking-context-rtl-diffs.html

[EFL]
Test results: http://build.webkit.org/results/EFL%20Linux%2064-bit%20Release%20WK1/r151267%20(182)/results.html

Image: http://build.webkit.org/results/EFL%20Linux%2064-bit%20Release%20WK1/r151267%20(182)/fast/regions/overflow-size-change-with-stacking-context-rtl-diffs.html

[GTK]
Test results: http://build.webkit.org/results/GTK%20Linux%2064-bit%20Release/r151269%20(38364)/results.html

Image: http://build.webkit.org/results/GTK%20Linux%2064-bit%20Release/r151269%20(38364)/fast/regions/overflow-size-change-with-stacking-context-rtl-diffs.html

[Mihnea Ovidenie]

Taking a look...

[Mihnea Ovidenie]

Similar to https://bugs.webkit.org/show_bug.cgi?id=102387, i will fix this regression by making the margins compute to int values.

[Mihnea Ovidenie]

Created attachment 204016 [details]
Patch

[Mihnea Ovidenie]

Tested the fix with a Mac build with subpixel layout enabled.

[Gábor Ábrahám]

*** Bug 117336 has been marked as a duplicate of this bug. ***

[Zoltan Arvai]

(In reply to comment #4)
> Tested the fix with a Mac build with subpixel layout enabled.

Seems ok in Qt linux, too.

[Alexandru Chiculita]

Comment on attachment 204016 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=204016&action=review

r=me

> LayoutTests/ChangeLog:8
> +        Make sure that computed margins are ints not floats to avoid differences on platforms that enable

nit: I think the comment is not enough to explain the changes in this patch.

[Mihnea Ovidenie]

Created attachment 204297 [details]
Patch for landing

[WebKit Commit Bot]

The commit-queue encountered the following flaky tests while processing attachment 204297 [details]:

platform/mac/editing/deleting/deletionUI-single-instance.html bug 114181 (author: [e-mail])
transitions/color-transition-rounding.html bug 114182 (author: [e-mail])
transitions/cubic-bezier-overflow-svg-length.html bug 114183 (author: [e-mail])
transitions/interrupt-zero-duration.html bug 114184 (authors: [e-mail], [e-mail], and [e-mail])
transitions/multiple-background-transitions.html bug 114185 (author: [e-mail])
transitions/cubic-bezier-overflow-color.html bug 114186 (author: [e-mail])
transitions/mismatched-shadow-transitions.html bug 114188 (author: [e-mail])
transitions/color-transition-all.html bug 114189 (authors: [e-mail] and [e-mail])
transitions/cubic-bezier-overflow-shadow.html bug 114191 (author: [e-mail])
transitions/min-max-width-height-transitions.html bug 114192 (author: [e-mail])
transitions/cancel-transition.html bug 114193 (authors: [e-mail], [e-mail], and [e-mail])
transitions/border-radius-transition.html bug 114194 (author: [e-mail])
transitions/flex-transitions.html bug 114195 (author: [e-mail])
transitions/mixed-type.html bug 114196 (author: [e-mail])
transitions/color-transition-premultiplied.html bug 114198 (author: [e-mail])
transitions/mismatched-shadow-styles.html bug 114199 (author: [e-mail])
transitions/mask-transitions.html bug 114200 (authors: [e-mail], [e-mail], and [e-mail])
transitions/cubic-bezier-overflow-length.html bug 114201 (author: [e-mail])
transitions/multiple-background-size-transitions.html bug 114202 (authors: [e-mail] and [e-mail])
transitions/clip-transition.html bug 114203 (authors: [e-mail], [e-mail], and [e-mail])
transitions/cubic-bezier-overflow-transform.html bug 114204 (author: [e-mail])
transitions/interrupted-accelerated-transition.html bug 56242 (authors: [e-mail], [e-mail], and [e-mail])
transitions/background-transitions.html bug 114206 (author: [e-mail])
http/tests/cookies/multiple-cookies.html bug 115608 (authors: [e-mail], [e-mail], and [e-mail])
http/tests/security/mixedContent/redirect-https-to-http-iframe-in-main-frame.html bug 114208 (authors: [e-mail] and [e-mail])
http/tests/inspector/inspect-element.html bug 78869 (author: [e-mail])
fast/dom/Window/window-postmessage-clone.html bug 40123 (authors: [e-mail], [e-mail], and [e-mail])
fast/loader/javascript-url-in-object.html bug 114210 (authors: [e-mail] and [e-mail])
plugins/mouse-move-over-plugin-in-frame.html bug 116664 (authors: [e-mail] and [e-mail])
plugins/mouse-events.html bug 116665 (authors: [e-mail], [e-mail], [e-mail], and [e-mail])
The commit-queue is continuing to process your patch.

[WebKit Commit Bot]

Comment on attachment 204297 [details]
Patch for landing

Clearing flags on attachment: 204297

Committed r151430: <http://trac.webkit.org/changeset/151430>

[WebKit Commit Bot]

All reviewed patches have been landed.  Closing bug.