Bug 114624 – Crash when favicon is requested

• Status: RESOLVED
• Resolution: FIXED
• Component: WebKit API

A NULL pointer exception occurs when a favicon is requested with WebIconDatabase::iconForURL.
The crash occurs in WebIconDatabase::getOrCreateDefaultIconBitmap (WebKit/win/WebIconDatabase.cpp, line 310),
because the call iconDatabase().defaultIcon(*size) returns NULL and gets dereferenced.

Created attachment 198127 [details]
Patch

[Brent Fulgham]

Comment on attachment 198127 [details]
Patch

r=me.  Is there an existing test for this?

[WebKit Commit Bot]

The commit-queue encountered the following flaky tests while processing attachment 198127 [details]:

platform/mac/editing/deleting/deletionUI-single-instance.html bug 114181 (author: [e-mail])
transitions/color-transition-rounding.html bug 114182 (author: [e-mail])
transitions/cubic-bezier-overflow-svg-length.html bug 114183 (author: [e-mail])
transitions/interrupt-zero-duration.html bug 114184 (authors: [e-mail], [e-mail], and [e-mail])
transitions/multiple-background-transitions.html bug 114185 (author: [e-mail])
transitions/cubic-bezier-overflow-color.html bug 114186 (author: [e-mail])
transitions/multiple-shadow-transitions.html bug 114187 (author: [e-mail])
transitions/mismatched-shadow-transitions.html bug 114188 (author: [e-mail])
transitions/color-transition-all.html bug 114189 (authors: [e-mail] and [e-mail])
transitions/negative-delay.html bug 114190 (author: [e-mail])
transitions/cubic-bezier-overflow-shadow.html bug 114191 (author: [e-mail])
transitions/min-max-width-height-transitions.html bug 114192 (author: [e-mail])
transitions/cancel-transition.html bug 114193 (authors: [e-mail], [e-mail], and [e-mail])
transitions/border-radius-transition.html bug 114194 (author: [e-mail])
transitions/flex-transitions.html bug 114195 (author: [e-mail])
transitions/mixed-type.html bug 114196 (author: [e-mail])
transitions/multiple-mask-transitions.html bug 114197 (author: [e-mail])
transitions/color-transition-premultiplied.html bug 114198 (author: [e-mail])
transitions/mismatched-shadow-styles.html bug 114199 (author: [e-mail])
transitions/mask-transitions.html bug 114200 (authors: [e-mail], [e-mail], and [e-mail])
transitions/cubic-bezier-overflow-length.html bug 114201 (author: [e-mail])
transitions/multiple-background-size-transitions.html bug 114202 (authors: [e-mail] and [e-mail])
transitions/clip-transition.html bug 114203 (authors: [e-mail] and [e-mail])
transitions/cubic-bezier-overflow-transform.html bug 114204 (author: [e-mail])
transitions/shorthand-border-transitions.html bug 114205 (authors: [e-mail] and [e-mail])
transitions/interrupted-accelerated-transition.html bug 56242 (authors: [e-mail], [e-mail], and [e-mail])
transitions/background-transitions.html bug 114206 (author: [e-mail])
http/tests/security/cookies/third-party-cookie-blocking-user-action.html bug 114511 (authors: [e-mail], [e-mail], and [e-mail])
http/tests/security/mixedContent/redirect-https-to-http-iframe-in-main-frame.html bug 114208 (authors: [e-mail] and [e-mail])
fast/loader/javascript-url-in-object.html bug 114210 (authors: [e-mail] and [e-mail])
The commit-queue is continuing to process your patch.

[WebKit Commit Bot]

Comment on attachment 198127 [details]
Patch

Clearing flags on attachment: 198127

Committed r148456: <http://trac.webkit.org/changeset/148456>

[WebKit Commit Bot]

All reviewed patches have been landed.  Closing bug.

(In reply to comment #2)
> (From update of attachment 198127 [details])
> r=me.  Is there an existing test for this?

No, not that I'm aware of.