Bug 117222 – [Coordinated Graphics] Prevent a recursive painting in CoordinatedGraphicsLayer

• Status: RESOLVED
• Resolution: FIXED
• Component: Layout and Rendering

[Gwang Yoon Hwang]

CoordinatedGraphicsLayer::flushCompositingState() will cross frame
boundaries if the GraphicsLayers are connected. In this case,
updateContentBuffers will invoke a painting of a sub-frame that causes
flushCompositingState recursively.

To prevent this behavior this patch extracts updateContentBuffers from
flushCompositingState, and places it in
updateContentBuffersIncludeSublayers, which is another tree traveler for
painting.

[Gwang Yoon Hwang]

Created attachment 203779 [details]
Patch

[Noam Rosenthal]

Comment on attachment 203779 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=203779&action=review

Needs some renames, but I like the approach.

> Source/WebKit2/ChangeLog:16
> +        updateContentBuffersIncludeSublayers, which is another tree traveler for
> +        painting.

"tree traveler" you mean which traverses the tree separately from flushing the state.

> Source/WebCore/platform/graphics/texmap/coordinated/CoordinatedGraphicsLayer.h:114
> +    void requestSyncStateChangesIncludeSubLayers();

syncPendingStateChangesIncludingSubLayers

> Source/WebCore/platform/graphics/texmap/coordinated/CoordinatedGraphicsLayer.h:115
> +    void updateContentBuffersIncludeSubLayers();

updateContentBuffersIncludingSubLayeres

[Gwang Yoon Hwang]

Created attachment 203801 [details]
Patch

[Gwang Yoon Hwang]

(In reply to comment #2)
> (From update of attachment 203779 [details])
> View in context: https://bugs.webkit.org/attachment.cgi?id=203779&action=review
> 
> Needs some renames, but I like the approach.
> 
> > Source/WebKit2/ChangeLog:16
> > +        updateContentBuffersIncludeSublayers, which is another tree traveler for
> > +        painting.
> 
> "tree traveler" you mean which traverses the tree separately from flushing the state.

Yes. thanks for suggesting nice phrase.

> 
> > Source/WebCore/platform/graphics/texmap/coordinated/CoordinatedGraphicsLayer.h:114
> > +    void requestSyncStateChangesIncludeSubLayers();
> 
> syncPendingStateChangesIncludingSubLayers
> 
> > Source/WebCore/platform/graphics/texmap/coordinated/CoordinatedGraphicsLayer.h:115
> > +    void updateContentBuffersIncludeSubLayers();
> 
> updateContentBuffersIncludingSubLayeres

Good naming. I changed names of methods.

[Noam Rosenthal]

Comment on attachment 203801 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=203801&action=review

Has a typo, otherwise LGTM

> Source/WebCore/platform/graphics/texmap/coordinated/CoordinatedGraphicsLayer.cpp:1001
> +void CoordinatedGraphicsLayer::updateContentBuffersIncludingSubLayeres()

Layeres -> Layers

[Gwang Yoon Hwang]

Created attachment 203812 [details]
Patch

[Gwang Yoon Hwang]

(In reply to comment #5)
> (From update of attachment 203801 [details])
> View in context: https://bugs.webkit.org/attachment.cgi?id=203801&action=review
> 
> Has a typo, otherwise LGTM
> 
> > Source/WebCore/platform/graphics/texmap/coordinated/CoordinatedGraphicsLayer.cpp:1001
> > +void CoordinatedGraphicsLayer::updateContentBuffersIncludingSubLayeres()
> 
> Layeres -> Layers

Thanks for review. I had fixed typo.

[Gwang Yoon Hwang]

Created attachment 203813 [details]
Patch

[WebKit Commit Bot]

The commit-queue encountered the following flaky tests while processing attachment 203812 [details]:

platform/mac/editing/deleting/deletionUI-single-instance.html bug 114181 (author: [e-mail])
transitions/color-transition-rounding.html bug 114182 (author: [e-mail])
transitions/cubic-bezier-overflow-svg-length.html bug 114183 (author: [e-mail])
transitions/interrupt-zero-duration.html bug 114184 (authors: [e-mail], [e-mail], and [e-mail])
transitions/multiple-background-transitions.html bug 114185 (author: [e-mail])
transitions/cubic-bezier-overflow-color.html bug 114186 (author: [e-mail])
transitions/multiple-shadow-transitions.html bug 114187 (author: [e-mail])
transitions/mismatched-shadow-transitions.html bug 114188 (author: [e-mail])
transitions/color-transition-all.html bug 114189 (authors: [e-mail] and [e-mail])
transitions/negative-delay.html bug 114190 (author: [e-mail])
transitions/cubic-bezier-overflow-shadow.html bug 114191 (author: [e-mail])
transitions/min-max-width-height-transitions.html bug 114192 (author: [e-mail])
transitions/cancel-transition.html bug 114193 (authors: [e-mail], [e-mail], and [e-mail])
transitions/border-radius-transition.html bug 114194 (author: [e-mail])
transitions/flex-transitions.html bug 114195 (author: [e-mail])
transitions/mixed-type.html bug 114196 (author: [e-mail])
transitions/multiple-mask-transitions.html bug 114197 (author: [e-mail])
transitions/color-transition-premultiplied.html bug 114198 (author: [e-mail])
transitions/mismatched-shadow-styles.html bug 114199 (author: [e-mail])
transitions/mask-transitions.html bug 114200 (authors: [e-mail], [e-mail], and [e-mail])
transitions/cubic-bezier-overflow-length.html bug 114201 (author: [e-mail])
transitions/multiple-background-size-transitions.html bug 114202 (authors: [e-mail] and [e-mail])
transitions/clip-transition.html bug 114203 (authors: [e-mail], [e-mail], and [e-mail])
transitions/cubic-bezier-overflow-transform.html bug 114204 (author: [e-mail])
transitions/interrupted-accelerated-transition.html bug 56242 (authors: [e-mail], [e-mail], and [e-mail])
transitions/background-transitions.html bug 114206 (author: [e-mail])
http/tests/security/mixedContent/redirect-https-to-http-iframe-in-main-frame.html bug 114208 (authors: [e-mail] and [e-mail])
http/tests/inspector/inspect-element.html bug 78869 (author: [e-mail])
fast/loader/javascript-url-in-object.html bug 114210 (authors: [e-mail] and [e-mail])
svg/animations/smil-leak-dynamically-added-element-instances.svg bug 114281 (authors: [e-mail] and [e-mail])
The commit-queue is continuing to process your patch.

[WebKit Commit Bot]

Comment on attachment 203813 [details]
Patch

Clearing flags on attachment: 203813

Committed r151220: <http://trac.webkit.org/changeset/151220>

[WebKit Commit Bot]

All reviewed patches have been landed.  Closing bug.