Bug 116954 – [BlackBerry] Use StringBuilder instead of + operator to build strings in AboutData

• Status: RESOLVED
• Resolution: FIXED
• Component: WebKit BlackBerry

[Carlos Garcia Campos]

It's more efficient.

[Carlos Garcia Campos]

Created attachment 203152 [details]
Patch

[Rob Buis]

Comment on attachment 203152 [details]
Patch

Looks good.

[WebKit Commit Bot]

Comment on attachment 203152 [details]
Patch

Rejecting attachment 203152 [details] from commit-queue.

Failed to run "['/Volumes/Data/EWS/WebKit/Tools/Scripts/webkit-patch', '--status-host=webkit-queues.appspot.com', '--bot-id=webkit-cq-01', 'apply-attachment', '--no-update', '--non-interactive', 203152, '--port=mac']" exit_code: 2 cwd: /Volumes/Data/EWS/WebKit

Last 500 characters of output:
Kit/blackberry/WebKitSupport/AboutData.cpp
Hunk #1 FAILED at 67.
Hunk #2 succeeded at 194 (offset -1 lines).
Hunk #3 succeeded at 226 (offset -1 lines).
Hunk #4 succeeded at 248 (offset -1 lines).
Hunk #5 succeeded at 418 (offset -1 lines).
1 out of 5 hunks FAILED -- saving rejects to file Source/WebKit/blackberry/WebKitSupport/AboutData.cpp.rej

Failed to run "[u'/Volumes/Data/EWS/WebKit/Tools/Scripts/svn-apply', '--force', '--reviewer', u'Rob Buis']" exit_code: 1 cwd: /Volumes/Data/EWS/WebKit

Full output: http://webkit-queues.appspot.com/results/683433

[Carlos Garcia Campos]

Created attachment 203217 [details]
Rebased patch

[WebKit Commit Bot]

The commit-queue encountered the following flaky tests while processing attachment 203217 [details]:

platform/mac/editing/deleting/deletionUI-single-instance.html bug 114181 (author: [e-mail])
transitions/color-transition-rounding.html bug 114182 (author: [e-mail])
transitions/cubic-bezier-overflow-svg-length.html bug 114183 (author: [e-mail])
transitions/interrupt-zero-duration.html bug 114184 (authors: [e-mail], [e-mail], and [e-mail])
transitions/multiple-background-transitions.html bug 114185 (author: [e-mail])
transitions/cubic-bezier-overflow-color.html bug 114186 (author: [e-mail])
transitions/multiple-shadow-transitions.html bug 114187 (author: [e-mail])
transitions/mismatched-shadow-transitions.html bug 114188 (author: [e-mail])
transitions/color-transition-all.html bug 114189 (authors: [e-mail] and [e-mail])
transitions/negative-delay.html bug 114190 (author: [e-mail])
transitions/cubic-bezier-overflow-shadow.html bug 114191 (author: [e-mail])
transitions/min-max-width-height-transitions.html bug 114192 (author: [e-mail])
transitions/cancel-transition.html bug 114193 (authors: [e-mail], [e-mail], and [e-mail])
transitions/border-radius-transition.html bug 114194 (author: [e-mail])
transitions/flex-transitions.html bug 114195 (author: [e-mail])
transitions/mixed-type.html bug 114196 (author: [e-mail])
transitions/multiple-mask-transitions.html bug 114197 (author: [e-mail])
transitions/color-transition-premultiplied.html bug 114198 (author: [e-mail])
transitions/mismatched-shadow-styles.html bug 114199 (author: [e-mail])
transitions/mask-transitions.html bug 114200 (authors: [e-mail], [e-mail], and [e-mail])
transitions/cubic-bezier-overflow-length.html bug 114201 (author: [e-mail])
transitions/multiple-background-size-transitions.html bug 114202 (authors: [e-mail] and [e-mail])
transitions/clip-transition.html bug 114203 (authors: [e-mail], [e-mail], and [e-mail])
transitions/cubic-bezier-overflow-transform.html bug 114204 (author: [e-mail])
transitions/interrupted-accelerated-transition.html bug 56242 (authors: [e-mail], [e-mail], and [e-mail])
transitions/background-transitions.html bug 114206 (author: [e-mail])
http/tests/security/mixedContent/redirect-https-to-http-iframe-in-main-frame.html bug 114208 (authors: [e-mail] and [e-mail])
http/tests/inspector/inspect-element.html bug 78869 (author: [e-mail])
fast/dom/Window/window-postmessage-clone.html bug 40123 (authors: [e-mail], [e-mail], and [e-mail])
fast/loader/javascript-url-in-object.html bug 114210 (authors: [e-mail] and [e-mail])
The commit-queue is continuing to process your patch.

[WebKit Commit Bot]

Comment on attachment 203217 [details]
Rebased patch

Clearing flags on attachment: 203217

Committed r150913: <http://trac.webkit.org/changeset/150913>

[WebKit Commit Bot]

All reviewed patches have been landed.  Closing bug.