Bug 116581 - [css] Update ETextDecorations enum to TextDecorations (incl. enumeration values)
Summary: [css] Update ETextDecorations enum to TextDecorations (incl. enumeration values)
Alias: None
Product: WebKit
Classification: Unclassified
Component: CSS (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Bruno Abinader (history only)
Depends on:
Reported: 2013-05-21 16:19 PDT by Bruno Abinader (history only)
Modified: 2013-05-24 15:08 PDT (History)
10 users (show)

See Also:

Proposed patch (32.44 KB, patch)
2013-05-21 16:34 PDT, Bruno Abinader (history only)
no flags Details | Formatted Diff | Diff
Proposed patch (32.43 KB, patch)
2013-05-21 18:30 PDT, Bruno Abinader (history only)
kling: review+
Details | Formatted Diff | Diff
Proposed patch (32.43 KB, patch)
2013-05-22 10:55 PDT, Bruno Abinader (history only)
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Bruno Abinader (history only) 2013-05-21 16:19:31 PDT
Currently, ETextDecorations enum uses a C-like coding style for its enumeration values, as well as a 'E' prefix that surely had some meaning in the past, but not nowadays.

This issue has already been fixed in Blink: https://code.google.com/p/chromium/issues/detail?id=242591 - I am intending to backport the patch to WebKit.
Comment 1 Bruno Abinader (history only) 2013-05-21 16:34:25 PDT
Created attachment 202477 [details]
Proposed patch
Comment 2 EFL EWS Bot 2013-05-21 17:11:37 PDT
Comment on attachment 202477 [details]
Proposed patch

Attachment 202477 [details] did not pass efl-ews (efl):
Output: http://webkit-queues.appspot.com/results/338347
Comment 3 kov's GTK+ EWS bot 2013-05-21 17:42:38 PDT
Comment on attachment 202477 [details]
Proposed patch

Attachment 202477 [details] did not pass gtk-ews (gtk):
Output: http://webkit-queues.appspot.com/results/372231
Comment 4 Bruno Abinader (history only) 2013-05-21 18:30:48 PDT
Created attachment 202486 [details]
Proposed patch

Fixed a typo
Comment 5 Andreas Kling 2013-05-22 10:48:55 PDT
Comment on attachment 202486 [details]
Proposed patch

View in context: https://bugs.webkit.org/attachment.cgi?id=202486&action=review

r=me. This looks way better!

> Source/WebCore/rendering/style/RenderStyleConstants.h:344
> +    TextDecorationNone = 0x0 , TextDecorationUnderline = 0x1, TextDecorationOverline = 0x2, TextDecorationLineThrough= 0x4, TextDecorationBlink = 0x8

Missing space after TextDecorationLineThrough.
Comment 6 Bruno Abinader (history only) 2013-05-22 10:55:31 PDT
Created attachment 202573 [details]
Proposed patch
Comment 7 WebKit Commit Bot 2013-05-22 11:36:46 PDT
The commit-queue encountered the following flaky tests while processing attachment 202573 [details]:

svg/batik/text/smallFonts.svg bug 115040 (author: oliver@apple.com)
svg/batik/text/textAnchor.svg bug 116285 (authors: darin@apple.com and zimmermann@kde.org)
svg/batik/paints/patternRegions.svg bug 116380 (author: zimmermann@kde.org)
svg/dom/SVGScriptElement/script-load-and-error-events.svg bug 114279 (authors: fmalita@chromium.org, yurys@chromium.org, and zimmermann@kde.org)
transitions/color-transition-rounding.html bug 114182 (author: simon.fraser@apple.com)
transitions/cubic-bezier-overflow-svg-length.html bug 114183 (author: peter@chromium.org)
transitions/interrupt-zero-duration.html bug 114184 (authors: cmarrin@apple.com, rniwa@webkit.org, and simon.fraser@apple.com)
transitions/multiple-background-transitions.html bug 114185 (author: simon.fraser@apple.com)
transitions/cubic-bezier-overflow-color.html bug 114186 (author: peter@chromium.org)
transitions/mismatched-shadow-transitions.html bug 114188 (author: simon.fraser@apple.com)
transitions/color-transition-all.html bug 114189 (authors: ossy@webkit.org and simon.fraser@apple.com)
transitions/cubic-bezier-overflow-shadow.html bug 114191 (author: peter@chromium.org)
transitions/min-max-width-height-transitions.html bug 114192 (author: simon.fraser@apple.com)
transitions/cancel-transition.html bug 114193 (authors: ojan@chromium.org, rniwa@webkit.org, and simon.fraser@apple.com)
transitions/border-radius-transition.html bug 114194 (author: simon.fraser@apple.com)
transitions/flex-transitions.html bug 114195 (author: tony@chromium.org)
transitions/mixed-type.html bug 114196 (author: mikelawther@chromium.org)
transitions/color-transition-premultiplied.html bug 114198 (author: simon.fraser@apple.com)
transitions/mismatched-shadow-styles.html bug 114199 (author: simon.fraser@apple.com)
transitions/mask-transitions.html bug 114200 (authors: ojan@chromium.org, oliver@apple.com, and simon.fraser@apple.com)
transitions/cubic-bezier-overflow-length.html bug 114201 (author: peter@chromium.org)
transitions/multiple-background-size-transitions.html bug 114202 (authors: mitz@webkit.org and simon.fraser@apple.com)
transitions/clip-transition.html bug 114203 (authors: dglazkov@chromium.org, krit@webkit.org, and simon.fraser@apple.com)
transitions/cubic-bezier-overflow-transform.html bug 114204 (author: peter@chromium.org)
transitions/interrupted-accelerated-transition.html bug 56242 (authors: rniwa@webkit.org, simon.fraser@apple.com, and tonyg@chromium.org)
transitions/background-transitions.html bug 114206 (author: simon.fraser@apple.com)
http/tests/security/mixedContent/redirect-https-to-http-iframe-in-main-frame.html bug 114208 (authors: abarth@webkit.org and rniwa@webkit.org)
http/tests/inspector/appcache/appcache-manifest-with-non-existing-file.html bug 114209 (author: vsevik@chromium.org)
fast/loader/javascript-url-in-object.html bug 114210 (authors: rniwa@webkit.org and sam@webkit.org)
platform/mac/editing/deleting/deletionUI-single-instance.html bug 114181 (author: rniwa@webkit.org)
The commit-queue is continuing to process your patch.
Comment 8 WebKit Commit Bot 2013-05-22 11:37:44 PDT
Comment on attachment 202573 [details]
Proposed patch

Clearing flags on attachment: 202573

Committed r150525: <http://trac.webkit.org/changeset/150525>