Bug 116581 – [css] Update ETextDecorations enum to TextDecorations (incl. enumeration values)

• Status: RESOLVED
• Resolution: FIXED
• Component: CSS

[Bruno Abinader (history only)]

Currently, ETextDecorations enum uses a C-like coding style for its enumeration values, as well as a 'E' prefix that surely had some meaning in the past, but not nowadays.

This issue has already been fixed in Blink: https://code.google.com/p/chromium/issues/detail?id=242591 - I am intending to backport the patch to WebKit.

[Bruno Abinader (history only)]

Created attachment 202477 [details]
Proposed patch

[EFL EWS Bot]

Comment on attachment 202477 [details]
Proposed patch

Attachment 202477 [details] did not pass efl-ews (efl):
Output: http://webkit-queues.appspot.com/results/338347

[kov's GTK+ EWS bot]

Comment on attachment 202477 [details]
Proposed patch

Attachment 202477 [details] did not pass gtk-ews (gtk):
Output: http://webkit-queues.appspot.com/results/372231

[Bruno Abinader (history only)]

Created attachment 202486 [details]
Proposed patch

Fixed a typo

[Andreas Kling]

Comment on attachment 202486 [details]
Proposed patch

View in context: https://bugs.webkit.org/attachment.cgi?id=202486&action=review

r=me. This looks way better!

> Source/WebCore/rendering/style/RenderStyleConstants.h:344
> +    TextDecorationNone = 0x0 , TextDecorationUnderline = 0x1, TextDecorationOverline = 0x2, TextDecorationLineThrough= 0x4, TextDecorationBlink = 0x8

Missing space after TextDecorationLineThrough.

[Bruno Abinader (history only)]

Created attachment 202573 [details]
Proposed patch

[WebKit Commit Bot]

The commit-queue encountered the following flaky tests while processing attachment 202573 [details]:

svg/batik/text/smallFonts.svg bug 115040 (author: [e-mail])
svg/batik/text/textAnchor.svg bug 116285 (authors: [e-mail] and [e-mail])
svg/batik/paints/patternRegions.svg bug 116380 (author: [e-mail])
svg/dom/SVGScriptElement/script-load-and-error-events.svg bug 114279 (authors: [e-mail], [e-mail], and [e-mail])
transitions/color-transition-rounding.html bug 114182 (author: [e-mail])
transitions/cubic-bezier-overflow-svg-length.html bug 114183 (author: [e-mail])
transitions/interrupt-zero-duration.html bug 114184 (authors: [e-mail], [e-mail], and [e-mail])
transitions/multiple-background-transitions.html bug 114185 (author: [e-mail])
transitions/cubic-bezier-overflow-color.html bug 114186 (author: [e-mail])
transitions/mismatched-shadow-transitions.html bug 114188 (author: [e-mail])
transitions/color-transition-all.html bug 114189 (authors: [e-mail] and [e-mail])
transitions/cubic-bezier-overflow-shadow.html bug 114191 (author: [e-mail])
transitions/min-max-width-height-transitions.html bug 114192 (author: [e-mail])
transitions/cancel-transition.html bug 114193 (authors: [e-mail], [e-mail], and [e-mail])
transitions/border-radius-transition.html bug 114194 (author: [e-mail])
transitions/flex-transitions.html bug 114195 (author: [e-mail])
transitions/mixed-type.html bug 114196 (author: [e-mail])
transitions/color-transition-premultiplied.html bug 114198 (author: [e-mail])
transitions/mismatched-shadow-styles.html bug 114199 (author: [e-mail])
transitions/mask-transitions.html bug 114200 (authors: [e-mail], [e-mail], and [e-mail])
transitions/cubic-bezier-overflow-length.html bug 114201 (author: [e-mail])
transitions/multiple-background-size-transitions.html bug 114202 (authors: [e-mail] and [e-mail])
transitions/clip-transition.html bug 114203 (authors: [e-mail], [e-mail], and [e-mail])
transitions/cubic-bezier-overflow-transform.html bug 114204 (author: [e-mail])
transitions/interrupted-accelerated-transition.html bug 56242 (authors: [e-mail], [e-mail], and [e-mail])
transitions/background-transitions.html bug 114206 (author: [e-mail])
http/tests/security/mixedContent/redirect-https-to-http-iframe-in-main-frame.html bug 114208 (authors: [e-mail] and [e-mail])
http/tests/inspector/appcache/appcache-manifest-with-non-existing-file.html bug 114209 (author: [e-mail])
fast/loader/javascript-url-in-object.html bug 114210 (authors: [e-mail] and [e-mail])
platform/mac/editing/deleting/deletionUI-single-instance.html bug 114181 (author: [e-mail])
The commit-queue is continuing to process your patch.

[WebKit Commit Bot]

Comment on attachment 202573 [details]
Proposed patch

Clearing flags on attachment: 202573

Committed r150525: <http://trac.webkit.org/changeset/150525>