Bug 117593 – Avoid duplicate isInt32() / isUInt32() checks in JSDOMBindings

• Status: RESOLVED
• Resolution: FIXED
• Component: Bindings

[Chris Dumez]

In JSDOMBindings.cpp, the following pattern is used several times:
if (value.isInt32())
    return value.toInt32(exec);

This would be more efficiently written as:
if (value.isInt32())
    return value.asInt32();

The issue is that JSValue::toInt32() also calls value.isInt32() internally as well and returns value.asInt32() if it is.
We should therefore call asInt32() directly since we already know the value is an int32.

[Chris Dumez]

Created attachment 204587 [details]
Patch

[Geoffrey Garen]

Comment on attachment 204587 [details]
Patch

r=me

[WebKit Commit Bot]

The commit-queue encountered the following flaky tests while processing attachment 204587 [details]:

platform/mac/fonts/han-disunification.html bug 114207 (author: [e-mail])
platform/mac/editing/deleting/deletionUI-single-instance.html bug 114181 (author: [e-mail])
transitions/color-transition-rounding.html bug 114182 (author: [e-mail])
transitions/cubic-bezier-overflow-svg-length.html bug 114183 (author: [e-mail])
transitions/interrupt-zero-duration.html bug 114184 (authors: [e-mail], [e-mail], and [e-mail])
transitions/multiple-background-transitions.html bug 114185 (author: [e-mail])
transitions/cubic-bezier-overflow-color.html bug 114186 (author: [e-mail])
transitions/multiple-shadow-transitions.html bug 114187 (author: [e-mail])
transitions/mismatched-shadow-transitions.html bug 114188 (author: [e-mail])
transitions/color-transition-all.html bug 114189 (authors: [e-mail] and [e-mail])
transitions/cubic-bezier-overflow-shadow.html bug 114191 (author: [e-mail])
transitions/min-max-width-height-transitions.html bug 114192 (author: [e-mail])
transitions/cancel-transition.html bug 114193 (authors: [e-mail], [e-mail], and [e-mail])
transitions/border-radius-transition.html bug 114194 (author: [e-mail])
transitions/flex-transitions.html bug 114195 (author: [e-mail])
transitions/mixed-type.html bug 114196 (author: [e-mail])
transitions/multiple-mask-transitions.html bug 114197 (author: [e-mail])
transitions/color-transition-premultiplied.html bug 114198 (author: [e-mail])
transitions/mismatched-shadow-styles.html bug 114199 (author: [e-mail])
transitions/mask-transitions.html bug 114200 (authors: [e-mail], [e-mail], and [e-mail])
transitions/cubic-bezier-overflow-length.html bug 114201 (author: [e-mail])
transitions/multiple-background-size-transitions.html bug 114202 (authors: [e-mail] and [e-mail])
transitions/clip-transition.html bug 114203 (authors: [e-mail], [e-mail], and [e-mail])
transitions/cubic-bezier-overflow-transform.html bug 114204 (author: [e-mail])
transitions/interrupted-accelerated-transition.html bug 56242 (authors: [e-mail], [e-mail], and [e-mail])
transitions/background-transitions.html bug 114206 (author: [e-mail])
http/tests/security/mixedContent/redirect-https-to-http-iframe-in-main-frame.html bug 114208 (authors: [e-mail] and [e-mail])
fast/repaint/table-cell-collapsed-border-scroll.html bug 117529 (author: [e-mail])
fast/loader/javascript-url-in-object.html bug 114210 (authors: [e-mail] and [e-mail])
compositing/reflections/load-video-in-reflection.html bug 117427 (authors: [e-mail], [e-mail], and [e-mail])
The commit-queue is continuing to process your patch.

[WebKit Commit Bot]

Comment on attachment 204587 [details]
Patch

Clearing flags on attachment: 204587

Committed r151550: <http://trac.webkit.org/changeset/151550>

[WebKit Commit Bot]

All reviewed patches have been landed.  Closing bug.