Bug 116605 – [Mac] Captions menu isn't internationalized, doesn't use rtl layout for rtl languages

• Status: RESOLVED
• Resolution: FIXED
• Component: Media

[Antoine Quint]

When the user locale is set to hebrew, for instance, the text is laid out ltr and left-aligned. It should be laid out rtl and right-aligned.

[Antoine Quint]

<rdar://problem/13772554>

[Antoine Quint]

Created attachment 202515 [details]
Patch

[Eric Carlson]

Comment on attachment 202515 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=202515&action=review

> Source/WebCore/ChangeLog:32
> +        Makr the checkmarks a ::before pseudo-class rather than a background-image such that

Nit: Makr -> Make

> Source/WebCore/ChangeLog:33
> +        we may control is positioning using the internationlization-friendly "-webkit-margin-start"

Nit: is -> its

[Antoine Quint]

Created attachment 202536 [details]
Patch for landing

[WebKit Commit Bot]

The commit-queue encountered the following flaky tests while processing attachment 202536 [details]:

http/tests/security/mixedContent/redirect-https-to-http-iframe-in-main-frame.html bug 114208 (authors: [e-mail] and [e-mail])
svg/batik/text/textFeatures.svg bug 116326 (authors: [e-mail] and [e-mail])
svg/batik/filters/feTile.svg bug 114375 (authors: [e-mail] and [e-mail])
svg/animations/smil-leak-elements.svg bug 114280 (authors: [e-mail] and [e-mail])
svg/animations/smil-leak-dynamically-added-element-instances.svg bug 114281 (authors: [e-mail] and [e-mail])
fast/loader/javascript-url-in-object.html bug 114210 (authors: [e-mail] and [e-mail])
platform/mac/editing/deleting/deletionUI-single-instance.html bug 114181 (author: [e-mail])
compositing/overflow/overflow-compositing-descendant.html bug 116485 (authors: [e-mail], [e-mail], and [e-mail])
transitions/color-transition-rounding.html bug 114182 (author: [e-mail])
transitions/cubic-bezier-overflow-svg-length.html bug 114183 (author: [e-mail])
transitions/interrupt-zero-duration.html bug 114184 (authors: [e-mail], [e-mail], and [e-mail])
transitions/multiple-background-transitions.html bug 114185 (author: [e-mail])
transitions/cubic-bezier-overflow-color.html bug 114186 (author: [e-mail])
transitions/mismatched-shadow-transitions.html bug 114188 (author: [e-mail])
transitions/color-transition-all.html bug 114189 (authors: [e-mail] and [e-mail])
transitions/cubic-bezier-overflow-shadow.html bug 114191 (author: [e-mail])
transitions/min-max-width-height-transitions.html bug 114192 (author: [e-mail])
transitions/cancel-transition.html bug 114193 (authors: [e-mail], [e-mail], and [e-mail])
transitions/border-radius-transition.html bug 114194 (author: [e-mail])
transitions/flex-transitions.html bug 114195 (author: [e-mail])
transitions/mixed-type.html bug 114196 (author: [e-mail])
transitions/color-transition-premultiplied.html bug 114198 (author: [e-mail])
transitions/mismatched-shadow-styles.html bug 114199 (author: [e-mail])
transitions/mask-transitions.html bug 114200 (authors: [e-mail], [e-mail], and [e-mail])
transitions/cubic-bezier-overflow-length.html bug 114201 (author: [e-mail])
transitions/multiple-background-size-transitions.html bug 114202 (authors: [e-mail] and [e-mail])
transitions/clip-transition.html bug 114203 (authors: [e-mail], [e-mail], and [e-mail])
transitions/cubic-bezier-overflow-transform.html bug 114204 (author: [e-mail])
transitions/interrupted-accelerated-transition.html bug 56242 (authors: [e-mail], [e-mail], and [e-mail])
transitions/background-transitions.html bug 114206 (author: [e-mail])
The commit-queue is continuing to process your patch.

[WebKit Commit Bot]

Comment on attachment 202536 [details]
Patch for landing

Clearing flags on attachment: 202536

Committed r150516: <http://trac.webkit.org/changeset/150516>

[WebKit Commit Bot]

All reviewed patches have been landed.  Closing bug.