Bug 117416 – [WK2][CoordinatedGraphics] Add default case to switches to fix strict build

• Status: RESOLVED
• Resolution: FIXED
• Component: New Bugs

[Sergio Correia (qrwteyrutiyoup)]

[WK2][CoordinatedGraphics] Add default case to switches to fix strict build

[Sergio Correia (qrwteyrutiyoup)]

Created attachment 204180 [details]
Patch

[Noam Rosenthal]

Comment on attachment 204180 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=204180&action=review

> Source/WebKit2/ChangeLog:26
> +        While doing a strict build, with ENABLE_WERROR enabled, gcc complained
> +        about some enumeration values not being handled in two switch statements,
> +        causing the build to fail:
> +
> +        CoordinatedGraphicsArgumentCoders.cpp:171:24: error: enumeration value
> +        'COLOR' not handled in switch [-Werror=switch]
> +        CoordinatedGraphicsArgumentCoders.cpp:171:24: error: enumeration value
> +        'MATRIX' not handled in switch [-Werror=switch]
> +
> +        and
> +
> +        CoordinatedGraphicsArgumentCoders.cpp:288:24: error: enumeration value
> +        'COLOR' not handled in switch [-Werror=switch]
> +        CoordinatedGraphicsArgumentCoders.cpp:288:24: error: enumeration value
> +        'MATRIX' not handled in switch [-Werror=switch]
> +        cc1plus: all warnings being treated as errors
> +
> +        This patch adds a default case for each of these switches, to stop gcc
> +        from complaining and breaking a strict build.

Too much information, simply say that you fix strict build by asserting on default switch cases or something like that :)

[Sergio Correia (qrwteyrutiyoup)]

(In reply to comment #2)
> (From update of attachment 204180 [details])
> View in context: https://bugs.webkit.org/attachment.cgi?id=204180&action=review
[snip] 
> Too much information, simply say that you fix strict build by asserting on default switch cases or something like that :)

Heh, okay :)

[Sergio Correia (qrwteyrutiyoup)]

Created attachment 204183 [details]
Patch

[Noam Rosenthal]

Comment on attachment 204183 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=204183&action=review

> Source/WebKit2/ChangeLog:8
> +        This patch fix a strict build by asserting on the default case of two switch

nit: fix -> fixes :)

[Sergio Correia (qrwteyrutiyoup)]

Created attachment 204185 [details]
Patch

Fixed typo in changelog.

[WebKit Commit Bot]

The commit-queue encountered the following flaky tests while processing attachment 204185 [details]:

http/tests/security/mixedContent/redirect-https-to-http-iframe-in-main-frame.html bug 114208 (authors: [e-mail] and [e-mail])
http/tests/inspector/inspect-element.html bug 78869 (author: [e-mail])
media/video-poster-delayed.html bug 117426 (authors: [e-mail], [e-mail], [e-mail], and [e-mail])
fast/loader/javascript-url-in-object.html bug 114210 (authors: [e-mail] and [e-mail])
platform/mac/editing/deleting/deletionUI-single-instance.html bug 114181 (author: [e-mail])
compositing/reflections/load-video-in-reflection.html bug 117427 (authors: [e-mail], [e-mail], and [e-mail])
transitions/color-transition-rounding.html bug 114182 (author: [e-mail])
transitions/cubic-bezier-overflow-svg-length.html bug 114183 (author: [e-mail])
transitions/interrupt-zero-duration.html bug 114184 (authors: [e-mail], [e-mail], and [e-mail])
transitions/multiple-background-transitions.html bug 114185 (author: [e-mail])
transitions/cubic-bezier-overflow-color.html bug 114186 (author: [e-mail])
transitions/multiple-shadow-transitions.html bug 114187 (author: [e-mail])
transitions/mismatched-shadow-transitions.html bug 114188 (author: [e-mail])
transitions/color-transition-all.html bug 114189 (authors: [e-mail] and [e-mail])
transitions/cubic-bezier-overflow-shadow.html bug 114191 (author: [e-mail])
transitions/min-max-width-height-transitions.html bug 114192 (author: [e-mail])
transitions/cancel-transition.html bug 114193 (authors: [e-mail], [e-mail], and [e-mail])
transitions/border-radius-transition.html bug 114194 (author: [e-mail])
transitions/flex-transitions.html bug 114195 (author: [e-mail])
transitions/mixed-type.html bug 114196 (author: [e-mail])
transitions/multiple-mask-transitions.html bug 114197 (author: [e-mail])
transitions/color-transition-premultiplied.html bug 114198 (author: [e-mail])
transitions/mismatched-shadow-styles.html bug 114199 (author: [e-mail])
transitions/mask-transitions.html bug 114200 (authors: [e-mail], [e-mail], and [e-mail])
transitions/cubic-bezier-overflow-length.html bug 114201 (author: [e-mail])
transitions/multiple-background-size-transitions.html bug 114202 (authors: [e-mail] and [e-mail])
transitions/clip-transition.html bug 114203 (authors: [e-mail], [e-mail], and [e-mail])
transitions/cubic-bezier-overflow-transform.html bug 114204 (author: [e-mail])
transitions/interrupted-accelerated-transition.html bug 56242 (authors: [e-mail], [e-mail], and [e-mail])
transitions/background-transitions.html bug 114206 (author: [e-mail])
The commit-queue is continuing to process your patch.

[WebKit Commit Bot]

Comment on attachment 204185 [details]
Patch

Clearing flags on attachment: 204185

Committed r151406: <http://trac.webkit.org/changeset/151406>

[WebKit Commit Bot]

All reviewed patches have been landed.  Closing bug.