Bug 115531 - Remove DISABLE_ROUNDED_CORNER_CLIPPING
Summary: Remove DISABLE_ROUNDED_CORNER_CLIPPING
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Layout and Rendering (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Jeff Rogers
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2013-05-02 14:58 PDT by Simon Fraser (smfr)
Modified: 2013-05-20 18:24 PDT (History)
5 users (show)

See Also:


Attachments
Patch (2.46 KB, patch)
2013-05-20 17:52 PDT, Jeff Rogers
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Simon Fraser (smfr) 2013-05-02 14:58:10 PDT
I think DISABLE_ROUNDED_CORNER_CLIPPING was added by Google because Skia was slow. We should remove it.
Comment 1 Simon Fraser (smfr) 2013-05-02 14:58:54 PDT
Oh, #if PLATFORM(BLACKBERRY). Sadface
Comment 2 Jeff Rogers 2013-05-03 15:48:13 PDT
(In reply to comment #1)
> Oh, #if PLATFORM(BLACKBERRY). Sadface

Feel free to remove this, the BlackBerry port isn't using this any more.
Comment 3 Jeff Rogers 2013-05-20 17:52:35 PDT
Created attachment 202335 [details]
Patch
Comment 4 Andreas Kling 2013-05-20 18:00:40 PDT
Comment on attachment 202335 [details]
Patch

Fabulous, thanks!
Comment 5 WebKit Commit Bot 2013-05-20 18:23:51 PDT
The commit-queue encountered the following flaky tests while processing attachment 202335 [details]:

transitions/color-transition-rounding.html bug 114182 (author: simon.fraser@apple.com)
transitions/cubic-bezier-overflow-svg-length.html bug 114183 (author: peter@chromium.org)
transitions/interrupt-zero-duration.html bug 114184 (authors: cmarrin@apple.com, rniwa@webkit.org, and simon.fraser@apple.com)
transitions/multiple-background-transitions.html bug 114185 (author: simon.fraser@apple.com)
transitions/cubic-bezier-overflow-color.html bug 114186 (author: peter@chromium.org)
transitions/mismatched-shadow-transitions.html bug 114188 (author: simon.fraser@apple.com)
transitions/color-transition-all.html bug 114189 (authors: ossy@webkit.org and simon.fraser@apple.com)
transitions/cubic-bezier-overflow-shadow.html bug 114191 (author: peter@chromium.org)
transitions/min-max-width-height-transitions.html bug 114192 (author: simon.fraser@apple.com)
transitions/cancel-transition.html bug 114193 (authors: ojan@chromium.org, rniwa@webkit.org, and simon.fraser@apple.com)
transitions/border-radius-transition.html bug 114194 (author: simon.fraser@apple.com)
transitions/flex-transitions.html bug 114195 (author: tony@chromium.org)
transitions/mixed-type.html bug 114196 (author: mikelawther@chromium.org)
transitions/color-transition-premultiplied.html bug 114198 (author: simon.fraser@apple.com)
transitions/mismatched-shadow-styles.html bug 114199 (author: simon.fraser@apple.com)
transitions/mask-transitions.html bug 114200 (authors: ojan@chromium.org, oliver@apple.com, and simon.fraser@apple.com)
transitions/cubic-bezier-overflow-length.html bug 114201 (author: peter@chromium.org)
transitions/multiple-background-size-transitions.html bug 114202 (authors: mitz@webkit.org and simon.fraser@apple.com)
transitions/clip-transition.html bug 114203 (authors: dglazkov@chromium.org, krit@webkit.org, and simon.fraser@apple.com)
transitions/cubic-bezier-overflow-transform.html bug 114204 (author: peter@chromium.org)
transitions/interrupted-accelerated-transition.html bug 56242 (authors: rniwa@webkit.org, simon.fraser@apple.com, and tonyg@chromium.org)
transitions/background-transitions.html bug 114206 (author: simon.fraser@apple.com)
http/tests/security/mixedContent/redirect-https-to-http-iframe-in-main-frame.html bug 114208 (authors: abarth@webkit.org and rniwa@webkit.org)
svg/batik/text/textLayout.svg bug 116283 (authors: darin@apple.com and zimmermann@kde.org)
svg/batik/masking/maskRegions.svg bug 114120 (author: zimmermann@kde.org)
svg/batik/paints/patternRegions.svg bug 116380 (author: zimmermann@kde.org)
fast/loader/javascript-url-in-object.html bug 114210 (authors: rniwa@webkit.org and sam@webkit.org)
platform/mac/editing/deleting/deletionUI-single-instance.html bug 114181 (author: rniwa@webkit.org)
compositing/overflow/overflow-compositing-descendant.html bug 116485 (authors: mihaip@chromium.org, rniwa@webkit.org, and simon.fraser@apple.com)
editing/inserting/typing-at-end-of-line.html bug 116486 (author: enrica@apple.com)
The commit-queue is continuing to process your patch.
Comment 6 WebKit Commit Bot 2013-05-20 18:24:38 PDT
Comment on attachment 202335 [details]
Patch

Clearing flags on attachment: 202335

Committed r150394: <http://trac.webkit.org/changeset/150394>
Comment 7 WebKit Commit Bot 2013-05-20 18:24:41 PDT
All reviewed patches have been landed.  Closing bug.