Bug 115857 – [BlackBerry] Style updates required based on new check-webkit-style

• Status: RESOLVED
• Resolution: FIXED
• Component: WebKit BlackBerry

[Mike Fenton]

This applies to a large number of unit files.  All changes will be attached to this bug.

[Mike Fenton]

Created attachment 201190 [details]
Patch 1

[Mike Fenton]

Created attachment 201192 [details]
Patch 2

[Mike Fenton]

Created attachment 201193 [details]
Patch 3

[Mike Fenton]

Created attachment 201194 [details]
Patch 4

[Mike Fenton]

Created attachment 201195 [details]
Patch 5

[Mike Fenton]

Created attachment 201196 [details]
Patch 6

[Mike Fenton]

Created attachment 201197 [details]
Patch 7

[Mike Fenton]

Created attachment 201198 [details]
Patch 8

[Mike Fenton]

Created attachment 201199 [details]
Patch 9

[Mike Fenton]

Created attachment 201200 [details]
Patch 10

[Mike Fenton]

Created attachment 201201 [details]
Patch 11

[Mike Fenton]

Created attachment 201202 [details]
Patch 12

[Mike Fenton]

Created attachment 201203 [details]
Patch 13

[Rob Buis]

Comment on attachment 201190 [details]
Patch 1

Ok.

[WebKit Commit Bot]

The commit-queue encountered the following flaky tests while processing attachment 201190 [details]:

platform/mac/editing/deleting/deletionUI-single-instance.html bug 114181 (author: [e-mail])
transitions/color-transition-rounding.html bug 114182 (author: [e-mail])
transitions/cubic-bezier-overflow-svg-length.html bug 114183 (author: [e-mail])
transitions/interrupt-zero-duration.html bug 114184 (authors: [e-mail], [e-mail], and [e-mail])
transitions/multiple-background-transitions.html bug 114185 (author: [e-mail])
transitions/cubic-bezier-overflow-color.html bug 114186 (author: [e-mail])
transitions/multiple-shadow-transitions.html bug 114187 (author: [e-mail])
transitions/mismatched-shadow-transitions.html bug 114188 (author: [e-mail])
transitions/color-transition-all.html bug 114189 (authors: [e-mail] and [e-mail])
transitions/negative-delay.html bug 114190 (author: [e-mail])
transitions/cubic-bezier-overflow-shadow.html bug 114191 (author: [e-mail])
transitions/min-max-width-height-transitions.html bug 114192 (author: [e-mail])
transitions/cancel-transition.html bug 114193 (authors: [e-mail], [e-mail], and [e-mail])
transitions/border-radius-transition.html bug 114194 (author: [e-mail])
transitions/flex-transitions.html bug 114195 (author: [e-mail])
transitions/mixed-type.html bug 114196 (author: [e-mail])
transitions/multiple-mask-transitions.html bug 114197 (author: [e-mail])
transitions/color-transition-premultiplied.html bug 114198 (author: [e-mail])
transitions/mismatched-shadow-styles.html bug 114199 (author: [e-mail])
transitions/mask-transitions.html bug 114200 (authors: [e-mail], [e-mail], and [e-mail])
transitions/cubic-bezier-overflow-length.html bug 114201 (author: [e-mail])
transitions/multiple-background-size-transitions.html bug 114202 (authors: [e-mail] and [e-mail])
transitions/clip-transition.html bug 114203 (authors: [e-mail], [e-mail], and [e-mail])
transitions/cubic-bezier-overflow-transform.html bug 114204 (author: [e-mail])
transitions/shorthand-border-transitions.html bug 114205 (authors: [e-mail] and [e-mail])
transitions/interrupted-accelerated-transition.html bug 56242 (authors: [e-mail], [e-mail], and [e-mail])
transitions/background-transitions.html bug 114206 (author: [e-mail])
http/tests/security/cookies/third-party-cookie-blocking-user-action.html bug 114511 (authors: [e-mail], [e-mail], and [e-mail])
http/tests/security/mixedContent/redirect-https-to-http-iframe-in-main-frame.html bug 114208 (authors: [e-mail] and [e-mail])
fast/loader/javascript-url-in-object.html bug 114210 (authors: [e-mail] and [e-mail])
The commit-queue is continuing to process your patch.

[WebKit Commit Bot]

Comment on attachment 201190 [details]
Patch 1

Clearing flags on attachment: 201190

Committed r149806: <http://trac.webkit.org/changeset/149806>

[Rob Buis]

Comment on attachment 201192 [details]
Patch 2

Ok.

[Rob Buis]

Comment on attachment 201193 [details]
Patch 3

Ok.

[Rob Buis]

Comment on attachment 201194 [details]
Patch 4

Ok.

[WebKit Commit Bot]

Comment on attachment 201193 [details]
Patch 3

Clearing flags on attachment: 201193

Committed r149808: <http://trac.webkit.org/changeset/149808>

[WebKit Commit Bot]

Comment on attachment 201194 [details]
Patch 4

Clearing flags on attachment: 201194

Committed r149809: <http://trac.webkit.org/changeset/149809>

[WebKit Commit Bot]

Comment on attachment 201192 [details]
Patch 2

Clearing flags on attachment: 201192

Committed r149811: <http://trac.webkit.org/changeset/149811>

[Rob Buis]

Comment on attachment 201195 [details]
Patch 5

Ok.

[Rob Buis]

Comment on attachment 201196 [details]
Patch 6

Ok.

[Rob Buis]

Comment on attachment 201197 [details]
Patch 7

Ok.

[WebKit Commit Bot]

Comment on attachment 201197 [details]
Patch 7

Clearing flags on attachment: 201197

Committed r149815: <http://trac.webkit.org/changeset/149815>

[Rob Buis]

Comment on attachment 201198 [details]
Patch 8

Ok.

[WebKit Commit Bot]

Comment on attachment 201198 [details]
Patch 8

Rejecting attachment 201198 [details] from commit-queue.

Failed to run "['/Volumes/Data/EWS/WebKit/Tools/Scripts/webkit-patch', '--status-host=webkit-queues.appspot.com', '--bot-id=webkit-cq-03', 'apply-attachment', '--no-update', '--non-interactive', 201198, '--port=mac']" exit_code: 2 cwd: /Volumes/Data/EWS/WebKit

Last 500 characters of output:
pp
patching file Source/WebKit/blackberry/Api/WebPageCompositor.h
patching file Source/WebKit/blackberry/Api/WebPageCompositor_p.h
patching file Source/WebKit/blackberry/Api/WebSettings_p.h
patching file Source/WebKit/blackberry/ChangeLog
Hunk #1 FAILED at 1.
1 out of 1 hunk FAILED -- saving rejects to file Source/WebKit/blackberry/ChangeLog.rej

Failed to run "[u'/Volumes/Data/EWS/WebKit/Tools/Scripts/svn-apply', '--force', '--reviewer', u'Rob Buis']" exit_code: 1 cwd: /Volumes/Data/EWS/WebKit

Full output: http://webkit-queues.appspot.com/results/432027

[WebKit Commit Bot]

Comment on attachment 201196 [details]
Patch 6

Clearing flags on attachment: 201196

Committed r149818: <http://trac.webkit.org/changeset/149818>

[Rob Buis]

Comment on attachment 201199 [details]
Patch 9

LGTM.

[Rob Buis]

Comment on attachment 201200 [details]
Patch 10

Ok.

[WebKit Commit Bot]

Comment on attachment 201195 [details]
Patch 5

Rejecting attachment 201195 [details] from commit-queue.

Failed to run "['/Volumes/Data/EWS/WebKit/Tools/Scripts/webkit-patch', '--status-host=webkit-queues.appspot.com', '--bot-id=webkit-cq-02', 'land-attachment', '--force-clean', '--non-interactive', '--parent-command=commit-queue', 201195, '--port=mac']" exit_code: 2 cwd: /Volumes/Data/EWS/WebKit

Last 500 characters of output:
0-ab3c-d52691b4dbfc ...
Currently at 149814 = 96336ad83fb2e14bb1978c58c016b85743eac6d4
r149815 = f4080a7c3467212ef2e4e9f5f0170664a0448043
r149816 = 3c3b47e42a3622d93a955d3a7cbac5a44a06a529
r149817 = e32495936a230de179133a1d655fac20d1b46786
r149818 = 28fe0aa603f65f54a01877dc54a174a51258c1a9
Done rebuilding .git/svn/refs/remotes/origin/master/.rev_map.268f45cc-cd09-0410-ab3c-d52691b4dbfc
First, rewinding head to replay your work on top of it...
Fast-forwarded master to refs/remotes/origin/master.

Full output: http://webkit-queues.appspot.com/results/408552

[WebKit Commit Bot]

Comment on attachment 201199 [details]
Patch 9

Clearing flags on attachment: 201199

Committed r149819: <http://trac.webkit.org/changeset/149819>

[WebKit Commit Bot]

Comment on attachment 201200 [details]
Patch 10

Clearing flags on attachment: 201200

Committed r149820: <http://trac.webkit.org/changeset/149820>

[Rob Buis]

Comment on attachment 201195 [details]
Patch 5

Retry.

[WebKit Commit Bot]

Comment on attachment 201195 [details]
Patch 5

Rejecting attachment 201195 [details] from commit-queue.

Failed to run "['/Volumes/Data/EWS/WebKit/Tools/Scripts/webkit-patch', '--status-host=webkit-queues.appspot.com', '--bot-id=webkit-cq-03', 'apply-attachment', '--no-update', '--non-interactive', 201195, '--port=mac']" exit_code: 2 cwd: /Volumes/Data/EWS/WebKit

Last 500 characters of output:
 patch file(s).
patching file Source/WebKit/blackberry/ChangeLog
patching file Source/WebKit/blackberry/WebKitSupport/SelectionHandler.cpp
Hunk #3 FAILED at 385.
1 out of 9 hunks FAILED -- saving rejects to file Source/WebKit/blackberry/WebKitSupport/SelectionHandler.cpp.rej
patching file Source/WebKit/blackberry/WebKitSupport/SelectionHandler.h

Failed to run "[u'/Volumes/Data/EWS/WebKit/Tools/Scripts/svn-apply', '--force', '--reviewer', u'Rob Buis']" exit_code: 1 cwd: /Volumes/Data/EWS/WebKit

Full output: http://webkit-queues.appspot.com/results/433052

[Rob Buis]

Comment on attachment 201201 [details]
Patch 11

Ok.

[Rob Buis]

Comment on attachment 201202 [details]
Patch 12

Ok.

[Rob Buis]

Comment on attachment 201203 [details]
Patch 13

LGTM.

[WebKit Commit Bot]

Comment on attachment 201201 [details]
Patch 11

Clearing flags on attachment: 201201

Committed r149822: <http://trac.webkit.org/changeset/149822>

[WebKit Commit Bot]

Comment on attachment 201203 [details]
Patch 13

Clearing flags on attachment: 201203

Committed r149823: <http://trac.webkit.org/changeset/149823>

[WebKit Commit Bot]

Comment on attachment 201202 [details]
Patch 12

Clearing flags on attachment: 201202

Committed r149824: <http://trac.webkit.org/changeset/149824>

[Mike Fenton]

Created attachment 201257 [details]
Updated Patch 5 with new changelog.

[Rob Buis]

Comment on attachment 201257 [details]
Updated Patch 5 with new changelog.

Ok.

[Mike Fenton]

Created attachment 201258 [details]
Updated patch 8 with new changelog.

[WebKit Commit Bot]

Comment on attachment 201258 [details]
Updated patch 8 with new changelog.

Rejecting attachment 201258 [details] from review queue.

[e-mail] does not have reviewer permissions according to http://trac.webkit.org/browser/trunk/Tools/Scripts/webkitpy/common/config/committers.py.

- If you do not have reviewer rights please read http://webkit.org/coding/contributing.html for instructions on how to use bugzilla flags.

- If you have reviewer rights please correct the error in Tools/Scripts/webkitpy/common/config/committers.py by adding yourself to the file (no review needed).  The commit-queue restarts itself every 2 hours.  After restart the commit-queue will correctly respect your reviewer rights.

[Rob Buis]

Comment on attachment 201258 [details]
Updated patch 8 with new changelog.

Ok.

[WebKit Commit Bot]

Comment on attachment 201257 [details]
Updated Patch 5 with new changelog.

Clearing flags on attachment: 201257

Committed r149826: <http://trac.webkit.org/changeset/149826>

[WebKit Commit Bot]

Comment on attachment 201258 [details]
Updated patch 8 with new changelog.

Clearing flags on attachment: 201258

Committed r149831: <http://trac.webkit.org/changeset/149831>

[WebKit Commit Bot]

All reviewed patches have been landed.  Closing bug.