Bug 137910 - Add initial support for generating the StyleBuilder from CSSPropertyNames.in
Summary: Add initial support for generating the StyleBuilder from CSSPropertyNames.in
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: CSS (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Chris Dumez
URL: https://code.google.com/p/chromium/is...
Keywords: BlinkMergeCandidate
Depends on:
Blocks: 138000 138012 138036 138087 138121 138125 138207 138208 138209 138270 138283 138287 138288 138295 138296 138297 138337 138359 138398 138452 138547 138550 138594 138595 138715 138764 138766 139104 139172 139218 139250 139285 139633 139635 139660 139763 139765 139858 139898 139999 140007 140008 140010 140034 140051 140111 140112 140129 140157 140168 140169 140181 140204 140219 140267 140277 140315 140327 140340 140342
  Show dependency treegraph
 
Reported: 2014-10-20 23:24 PDT by Chris Dumez
Modified: 2015-01-11 13:38 PST (History)
6 users (show)

See Also:


Attachments
WIP Patch (15.89 KB, patch)
2014-10-20 23:25 PDT, Chris Dumez
no flags Details | Formatted Diff | Diff
WIP Patch (16.61 KB, patch)
2014-10-20 23:33 PDT, Chris Dumez
no flags Details | Formatted Diff | Diff
WIP Patch (84.61 KB, patch)
2014-10-21 20:52 PDT, Chris Dumez
no flags Details | Formatted Diff | Diff
WIP Patch (84.89 KB, patch)
2014-10-21 20:58 PDT, Chris Dumez
no flags Details | Formatted Diff | Diff
WIP Patch (85.41 KB, patch)
2014-10-21 21:15 PDT, Chris Dumez
no flags Details | Formatted Diff | Diff
Patch (90.34 KB, patch)
2014-10-21 22:16 PDT, Chris Dumez
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Chris Dumez 2014-10-20 23:24:10 PDT
Add initial support for generating the StyleBuilder from CSSPropertyNames.in, similarly to what was done in Blink:
https://code.google.com/p/chromium/issues/detail?id=237400

This is a first step towards getting rid of the DeprecatedStyleBuilder class.
Comment 1 Chris Dumez 2014-10-20 23:25:01 PDT
Created attachment 240189 [details]
WIP Patch
Comment 2 Chris Dumez 2014-10-20 23:33:38 PDT
Created attachment 240190 [details]
WIP Patch
Comment 3 Chris Dumez 2014-10-21 20:52:11 PDT
Created attachment 240243 [details]
WIP Patch
Comment 4 Chris Dumez 2014-10-21 20:58:53 PDT
Created attachment 240244 [details]
WIP Patch
Comment 5 Chris Dumez 2014-10-21 21:15:55 PDT
Created attachment 240247 [details]
WIP Patch
Comment 6 Chris Dumez 2014-10-21 22:16:00 PDT
Created attachment 240251 [details]
Patch
Comment 7 Andreas Kling 2014-10-22 09:16:31 PDT
Comment on attachment 240251 [details]
Patch

Wicked! r=me
Comment 8 WebKit Commit Bot 2014-10-22 09:56:35 PDT
Comment on attachment 240251 [details]
Patch

Clearing flags on attachment: 240251

Committed r175052: <http://trac.webkit.org/changeset/175052>
Comment 9 WebKit Commit Bot 2014-10-22 09:56:40 PDT
All reviewed patches have been landed.  Closing bug.