Bug 140007 - Move '-webkit-font-variant-ligature' CSS property to the new StyleBuilder
Summary: Move '-webkit-font-variant-ligature' CSS property to the new StyleBuilder
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: CSS (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Chris Dumez
URL:
Keywords:
Depends on: 137910
Blocks:
  Show dependency treegraph
 
Reported: 2014-12-30 11:15 PST by Chris Dumez
Modified: 2014-12-30 14:25 PST (History)
5 users (show)

See Also:


Attachments
Patch (12.59 KB, patch)
2014-12-30 11:57 PST, Chris Dumez
no flags Details | Formatted Diff | Diff
Patch (12.55 KB, patch)
2014-12-30 13:43 PST, Chris Dumez
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Chris Dumez 2014-12-30 11:15:01 PST
Move '-webkit-font-variant-ligature' CSS property to the new StyleBuilder.
Comment 1 Chris Dumez 2014-12-30 11:57:38 PST
Created attachment 243827 [details]
Patch
Comment 2 Darin Adler 2014-12-30 12:51:48 PST
Comment on attachment 243827 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=243827&action=review

> Source/WebCore/css/StyleBuilderCustom.h:1262
> +#if !ASSERT_DISABLED

Why is this #if needed? The else has only the assertion in it. Is this a pattern followed in other functions in this file?
Comment 3 Chris Dumez 2014-12-30 12:57:16 PST
Comment on attachment 243827 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=243827&action=review

>> Source/WebCore/css/StyleBuilderCustom.h:1262
>> +#if !ASSERT_DISABLED
> 
> Why is this #if needed? The else has only the assertion in it. Is this a pattern followed in other functions in this file?

I merely moved this code. I don't think this pattern is used elsewhere in this file. I will drop it as it likely builds fine without it.
Comment 4 Chris Dumez 2014-12-30 13:43:56 PST
Created attachment 243829 [details]
Patch
Comment 5 WebKit Commit Bot 2014-12-30 14:25:36 PST
Comment on attachment 243829 [details]
Patch

Clearing flags on attachment: 243829

Committed r177827: <http://trac.webkit.org/changeset/177827>
Comment 6 WebKit Commit Bot 2014-12-30 14:25:44 PST
All reviewed patches have been landed.  Closing bug.