Bug 140219 - Move -webkit-tap-highlight-color / -webkit-overflow-scrolling / -webkit-touch-callout to the new StyleBuilder
Summary: Move -webkit-tap-highlight-color / -webkit-overflow-scrolling / -webkit-touch...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: CSS (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Chris Dumez
URL:
Keywords:
Depends on: 137910
Blocks:
  Show dependency tree / graph
 
Reported: 2015-01-07 15:28 PST by Chris Dumez
Modified: 2015-01-07 23:55 PST (History)
5 users (show)

See Also:

Attachments
Patch (12.59 KB, patch)
2015-01-07 17:20 PST, Chris Dumez 		no flags Details | Formatted Diff | Diff
Patch (12.67 KB, patch)
2015-01-07 22:45 PST, Chris Dumez 		no flags Details | Formatted Diff | Diff
Patch (12.60 KB, patch)
2015-01-07 22:53 PST, Chris Dumez 		no flags Details | Formatted Diff | Diff
Show Obsolete (2) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Chris Dumez 2015-01-07 15:28:46 PST 
Move -webkit-tap-highlight-color / -webkit-overflow-scrolling / -webkit-touch-callout to the new StyleBuilder
Comment 1 Chris Dumez 2015-01-07 17:20:18 PST 
Created attachment 244227 [details]
Patch
Comment 2 Darin Adler 2015-01-07 20:19:40 PST 
Comment on attachment 244227 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=244227&action=review

> Source/WebCore/css/StyleBuilderConverter.h:1061
> +    return downcast<CSSPrimitiveValue>(value).getStringValue().lower() != "none";

Can we do this with equalIgnoringCase instead of lower? It's a shame to copy the string if it happens to have an uppercase character in it, just to do an equality comparison. More efficient still would be equalIgnoringASCIICase if we had an overload that takes the right type.

> Source/WebCore/css/StyleBuilderConverter.h:1063
> +#endif // PLATFORM(IOS)

In these short sequences, these comments on the #endif are ugly and don't seem to add clarity.
Comment 3 WebKit Commit Bot 2015-01-07 21:42:08 PST 
Comment on attachment 244227 [details]
Patch

Rejecting attachment 244227 [details] from commit-queue.

Failed to run "['/Volumes/Data/EWS/WebKit/Tools/Scripts/webkit-patch', '--status-host=webkit-queues.appspot.com', '--bot-id=webkit-cq-01', 'land-attachment', '--force-clean', '--non-interactive', '--parent-command=commit-queue', 244227, '--port=mac']" exit_code: 2 cwd: /Volumes/Data/EWS/WebKit

Last 500 characters of output:
    -> origin/master
Partial-rebuilding .git/svn/refs/remotes/origin/master/.rev_map.268f45cc-cd09-0410-ab3c-d52691b4dbfc ...
Currently at 178099 = 872690584ea2f35ace4928e38aaafb983e616a41
r178100 = 608d0716a1e22238a9f4bfd5213b38689a782b18
r178101 = 8acfb24eec38d82cd85c718f17d1bcd954336f64
Done rebuilding .git/svn/refs/remotes/origin/master/.rev_map.268f45cc-cd09-0410-ab3c-d52691b4dbfc
First, rewinding head to replay your work on top of it...
Fast-forwarded master to refs/remotes/origin/master.

Full output: http://webkit-queues.appspot.com/results/5872560549920768
Comment 4 Chris Dumez 2015-01-07 22:45:14 PST 
Created attachment 244243 [details]
Patch
Comment 5 Chris Dumez 2015-01-07 22:53:47 PST 
Created attachment 244244 [details]
Patch
Comment 6 WebKit Commit Bot 2015-01-07 23:55:44 PST 
Comment on attachment 244244 [details]
Patch

Clearing flags on attachment: 244244

Committed r178108: <http://trac.webkit.org/changeset/178108>
Comment 7 WebKit Commit Bot 2015-01-07 23:55:49 PST 
All reviewed patches have been landed.  Closing bug.