Bug 139635 - Move 'counter-increment' / 'counter-reset' to the new StyleBuilder
Summary: Move 'counter-increment' / 'counter-reset' to the new StyleBuilder
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: CSS (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Chris Dumez
URL:
Keywords:
Depends on: 137910
Blocks:
  Show dependency tree / graph
 
Reported: 2014-12-14 21:03 PST by Chris Dumez
Modified: 2014-12-15 01:49 PST (History)
4 users (show)

See Also:

Attachments
Patch (11.15 KB, patch)
2014-12-14 21:41 PST, Chris Dumez 		no flags Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Chris Dumez 2014-12-14 21:03:48 PST 
Move 'counter-increment' / 'counter-reset' to the new StyleBuilder
Comment 1 Chris Dumez 2014-12-14 21:41:39 PST 
Created attachment 243281 [details]
Patch
Comment 2 Antti Koivisto 2014-12-15 01:16:20 PST 
Comment on attachment 243281 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=243281&action=review

> Source/WebCore/css/StyleBuilderCustom.h:159
> +    template <CounterBehavior counterBehavior>
> +    static void applyInheritCounter(StyleResolver&);

I would put template arguments on the same line in headers.
Comment 3 WebKit Commit Bot 2014-12-15 01:49:40 PST 
Comment on attachment 243281 [details]
Patch

Clearing flags on attachment: 243281

Committed r177274: <http://trac.webkit.org/changeset/177274>
Comment 4 WebKit Commit Bot 2014-12-15 01:49:44 PST 
All reviewed patches have been landed.  Closing bug.