Bug 138398 - Move text-align CSS property to the new StyleBuilder
Summary: Move text-align CSS property to the new StyleBuilder
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: CSS (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Chris Dumez
URL:
Keywords:
Depends on: 137910
Blocks:
  Show dependency tree / graph
 
Reported: 2014-11-04 18:35 PST by Chris Dumez
Modified: 2014-11-05 10:24 PST (History)
6 users (show)

See Also:

Attachments
Patch (6.14 KB, patch)
2014-11-04 19:09 PST, Chris Dumez 		no flags Details | Formatted Diff | Diff
Patch (6.10 KB, patch)
2014-11-05 09:28 PST, Chris Dumez 		no flags Details | Formatted Diff | Diff
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Chris Dumez 2014-11-04 18:35:40 PST 
Move text-align CSS property to the new StyleBuilder
Comment 1 Chris Dumez 2014-11-04 19:09:39 PST 
Created attachment 240997 [details]
Patch
Comment 2 Antti Koivisto 2014-11-05 05:09:11 PST 
Comment on attachment 240997 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=240997&action=review

> Source/WebCore/css/StyleBuilderConverter.h:318
> +    if (styleResolver.parentStyle()->textAlign() == TASTART)

could use variable for styleResolver.parentStyle()->textAlign()
Comment 3 Chris Dumez 2014-11-05 09:28:49 PST 
Created attachment 241035 [details]
Patch
Comment 4 WebKit Commit Bot 2014-11-05 10:24:52 PST 
Comment on attachment 241035 [details]
Patch

Clearing flags on attachment: 241035

Committed r175625: <http://trac.webkit.org/changeset/175625>
Comment 5 WebKit Commit Bot 2014-11-05 10:24:58 PST 
All reviewed patches have been landed.  Closing bug.