Bug 138296 - Move -webkit-shape-outside to the new StyleBuilder
Summary: Move -webkit-shape-outside to the new StyleBuilder
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: CSS (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Chris Dumez
URL:
Keywords:
Depends on: 137910
Blocks:
  Show dependency tree / graph
 
Reported: 2014-11-02 16:00 PST by Chris Dumez
Modified: 2014-11-03 11:40 PST (History)
9 users (show)

See Also:

Attachments
Patch (9.10 KB, patch)
2014-11-02 16:33 PST, Chris Dumez 		no flags Details | Formatted Diff | Diff
Patch (8.98 KB, patch)
2014-11-03 09:03 PST, Chris Dumez 		no flags Details | Formatted Diff | Diff
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Chris Dumez 2014-11-02 16:00:19 PST 
Move -webkit-shape-outside to the new StyleBuilder.
Comment 1 Chris Dumez 2014-11-02 16:03:10 PST 
Bear, Zoltan, when looking at the ApplyPropertyShape<> code in DeprecatedStyleBuilder.cpp, I noticed that it is handling only CSSValueAuto as CSSPrimitiveValue. This does not seem right. The spec (and our CSS Parser) only seem to allow CSSValueNone as CSSPrimitiveValue. Should we update ApplyPropertyShape<> to all setShapeOutside(style, nullptr) when the value is CSSValueNone? (instead of CSSValueAuto).
Comment 2 Chris Dumez 2014-11-02 16:33:18 PST 
Created attachment 240822 [details]
Patch
Comment 3 Bear Travis 2014-11-02 20:12:31 PST 
Yes, if CSSValueAuto is lurking in the code, it is from an older version of the spec that used 'auto' instead of 'none'. Will look into this more tomorrow.
Comment 4 Chris Dumez 2014-11-03 09:03:50 PST 
Created attachment 240853 [details]
Patch
Comment 5 Chris Dumez 2014-11-03 09:05:38 PST 
I am just adding a FIXME about the CSSValueAuto in this patch since the idea is to move the code to the new StyleBuilder, not change behavior. Hopefully, Bear can update the code afterwards.
Comment 6 Zoltan Horvath 2014-11-03 10:52:12 PST 
Comment on attachment 240853 [details]
Patch

Thanks for moving the code to the new StyleBuilder! Looks good.
Comment 7 WebKit Commit Bot 2014-11-03 11:40:19 PST 
Comment on attachment 240853 [details]
Patch

Clearing flags on attachment: 240853

Committed r175481: <http://trac.webkit.org/changeset/175481>
Comment 8 WebKit Commit Bot 2014-11-03 11:40:26 PST 
All reviewed patches have been landed.  Closing bug.