Bug 140277 – Add support for SVG CSS Properties to the new StyleBuilder

• Status: RESOLVED
• Resolution: FIXED
• Component: CSS

[Chris Dumez]

Add support for SVG CSS Properties to the new StyleBuilder.

[Chris Dumez]

Created attachment 244320 [details]
Patch

[Build Bot]

Comment on attachment 244320 [details]
Patch

Attachment 244320 [details] did not pass mac-ews (mac):
Output: http://webkit-queues.appspot.com/results/5089822087577600

New failing tests:
svg/css/text-shadow-multiple.xhtml

[Build Bot]

Created attachment 244324 [details]
Archive of layout-test-results from ews102 for mac-mountainlion

The attached test failures were seen while running run-webkit-tests on the mac-ews.
Bot: ews102  Port: mac-mountainlion  Platform: Mac OS X 10.8.5

[Build Bot]

Comment on attachment 244320 [details]
Patch

Attachment 244320 [details] did not pass mac-wk2-ews (mac-wk2):
Output: http://webkit-queues.appspot.com/results/4741315690496000

New failing tests:
svg/css/text-shadow-multiple.xhtml

[Build Bot]

Created attachment 244325 [details]
Archive of layout-test-results from ews104 for mac-mountainlion-wk2

The attached test failures were seen while running run-webkit-tests on the mac-wk2-ews.
Bot: ews104  Port: mac-mountainlion-wk2  Platform: Mac OS X 10.8.5

[Chris Dumez]

Created attachment 244327 [details]
Patch

[Chris Dumez]

Created attachment 244329 [details]
Patch

[Chris Dumez]

Created attachment 244332 [details]
Patch

[Andreas Kling]

Comment on attachment 244332 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=244332&action=review

r=me

> Source/WebCore/ChangeLog:26
> +        conveter.

Typo, converter.

> Source/WebCore/css/StyleResolver.cpp:171
> +static const CSSPropertyID firstLowPriorityProperty = static_cast<CSSPropertyID>(CSSPropertyLineHeight + 1);

Nice.

[Chris Dumez]

Created attachment 244352 [details]
Patch

[WebKit Commit Bot]

Comment on attachment 244352 [details]
Patch

Clearing flags on attachment: 244352

Committed r178189: <http://trac.webkit.org/changeset/178189>

[WebKit Commit Bot]

All reviewed patches have been landed.  Closing bug.