WebKit Bugzilla
New
Browse
Log In
×
Sign in with GitHub
or
Remember my login
Create Account
·
Forgot Password
Forgotten password account recovery
RESOLVED FIXED
Bug 138283
Move the -webkit-transform property to the new StyleBuilder
https://bugs.webkit.org/show_bug.cgi?id=138283
Summary
Move the -webkit-transform property to the new StyleBuilder
Sam Weinig
Reported
2014-11-01 14:34:41 PDT
Convert webkit-transform to use the new style builder
Attachments
Patch
(6.05 KB, patch)
2014-11-01 14:39 PDT
,
Sam Weinig
no flags
Details
Formatted Diff
Diff
Patch
(6.05 KB, patch)
2014-11-01 14:39 PDT
,
Sam Weinig
cdumez
: review+
Details
Formatted Diff
Diff
Show Obsolete
(1)
View All
Add attachment
proposed patch, testcase, etc.
Sam Weinig
Comment 1
2014-11-01 14:39:23 PDT
Created
attachment 240794
[details]
Patch
Sam Weinig
Comment 2
2014-11-01 14:39:55 PDT
Created
attachment 240795
[details]
Patch
Chris Dumez
Comment 3
2014-11-01 14:45:15 PDT
Comment on
attachment 240795
[details]
Patch View in context:
https://bugs.webkit.org/attachment.cgi?id=240795&action=review
r=me with one thing to double-check.
> Source/WebCore/css/CSSPropertyNames.in:492 > +-webkit-transform [NewStyleBuilder, NameForMethods=Transform, Converter=Transform]
Do we really need to use the NameForMethods option here? makeprop.pl already strips the WebKit prefix for us so Transform should already be used.
Sam Weinig
Comment 4
2014-11-01 15:18:46 PDT
(In reply to
comment #3
)
> Comment on
attachment 240795
[details]
> Patch > > View in context: >
https://bugs.webkit.org/attachment.cgi?id=240795&action=review
> > r=me with one thing to double-check. > > > Source/WebCore/css/CSSPropertyNames.in:492 > > +-webkit-transform [NewStyleBuilder, NameForMethods=Transform, Converter=Transform] > > Do we really need to use the NameForMethods option here? makeprop.pl already > strips the WebKit prefix for us so Transform should already be used.
Fixed.
Sam Weinig
Comment 5
2014-11-01 15:18:55 PDT
Committed revision 175454.
Note
You need to
log in
before you can comment on or make changes to this bug.
Top of Page
Format For Printing
XML
Clone This Bug