Bug 138283 - Move the -webkit-transform property to the new StyleBuilder
Summary: Move the -webkit-transform property to the new StyleBuilder
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Sam Weinig
URL:
Keywords:
Depends on: 137910
Blocks:
  Show dependency tree / graph
 
Reported: 2014-11-01 14:34 PDT by Sam Weinig
Modified: 2014-11-01 18:25 PDT (History)
1 user (show)

See Also:

Attachments
Patch (6.05 KB, patch)
2014-11-01 14:39 PDT, Sam Weinig 		no flags Details | Formatted Diff | Diff
Patch (6.05 KB, patch)
2014-11-01 14:39 PDT, Sam Weinig 		cdumez: review+
Details | Formatted Diff | Diff
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Sam Weinig 2014-11-01 14:34:41 PDT 
Convert webkit-transform to use the new style builder
Comment 1 Sam Weinig 2014-11-01 14:39:23 PDT 
Created attachment 240794 [details]
Patch
Comment 2 Sam Weinig 2014-11-01 14:39:55 PDT 
Created attachment 240795 [details]
Patch
Comment 3 Chris Dumez 2014-11-01 14:45:15 PDT 
Comment on attachment 240795 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=240795&action=review

r=me with one thing to double-check.

> Source/WebCore/css/CSSPropertyNames.in:492
> +-webkit-transform [NewStyleBuilder, NameForMethods=Transform, Converter=Transform]

Do we really need to use the NameForMethods option here? makeprop.pl already strips the WebKit prefix for us so Transform should already be used.
Comment 4 Sam Weinig 2014-11-01 15:18:46 PDT 
(In reply to comment #3)
> Comment on attachment 240795 [details]
> Patch
> 
> View in context:
> https://bugs.webkit.org/attachment.cgi?id=240795&action=review
> 
> r=me with one thing to double-check.
> 
> > Source/WebCore/css/CSSPropertyNames.in:492
> > +-webkit-transform [NewStyleBuilder, NameForMethods=Transform, Converter=Transform]
> 
> Do we really need to use the NameForMethods option here? makeprop.pl already
> strips the WebKit prefix for us so Transform should already be used.

Fixed.
Comment 5 Sam Weinig 2014-11-01 15:18:55 PDT 
Committed revision 175454.