Bug 140008 - Move font-related CSS properties to the new StyleBuilder
Summary: Move font-related CSS properties to the new StyleBuilder
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: CSS (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Chris Dumez
URL:
Keywords:
Depends on: 137910
Blocks:
  Show dependency tree / graph
 
Reported: 2014-12-30 12:46 PST by Chris Dumez
Modified: 2014-12-30 16:53 PST (History)
5 users (show)

See Also:

Attachments
Patch (16.70 KB, patch)
2014-12-30 13:14 PST, Chris Dumez 		no flags Details | Formatted Diff | Diff
Patch (17.00 KB, patch)
2014-12-30 14:31 PST, Chris Dumez 		no flags Details | Formatted Diff | Diff
Patch (17.00 KB, patch)
2014-12-30 16:01 PST, Chris Dumez 		no flags Details | Formatted Diff | Diff
Show Obsolete (2) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Chris Dumez 2014-12-30 12:46:02 PST 
Move font-related CSS properties to the new StyleBuilder by teaching makeprop.pl how to generate them.
Comment 1 Chris Dumez 2014-12-30 13:14:57 PST 
Created attachment 243828 [details]
Patch
Comment 2 Chris Dumez 2014-12-30 14:31:27 PST 
Created attachment 243830 [details]
Patch
Comment 3 Darin Adler 2014-12-30 15:57:28 PST 
Comment on attachment 243830 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=243830&action=review

> Source/WebCore/css/CSSPropertyNames.in:101
>  -webkit-font-kerning [Inherited, LegacyStyleBuilder]
>  -webkit-font-smoothing [Inherited, LegacyStyleBuilder]
> +-webkit-font-kerning [Inherited, FontProperty, TypeName=FontDescription::Kerning, NameForMethods=Kerning]
> +-webkit-font-smoothing [Inherited, FontProperty, TypeName=FontSmoothingMode]

Build failed because you left in the old lines along with the new ones.
Comment 4 Chris Dumez 2014-12-30 16:00:19 PST 
Comment on attachment 243830 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=243830&action=review

>> Source/WebCore/css/CSSPropertyNames.in:101
>> +-webkit-font-smoothing [Inherited, FontProperty, TypeName=FontSmoothingMode]
> 
> Build failed because you left in the old lines along with the new ones.

I had a conflict when rebasing and messed up the merge. I'll fix now.
Comment 5 Chris Dumez 2014-12-30 16:01:47 PST 
Created attachment 243832 [details]
Patch
Comment 6 WebKit Commit Bot 2014-12-30 16:53:07 PST 
Comment on attachment 243832 [details]
Patch

Clearing flags on attachment: 243832

Committed r177828: <http://trac.webkit.org/changeset/177828>
Comment 7 WebKit Commit Bot 2014-12-30 16:53:12 PST 
All reviewed patches have been landed.  Closing bug.