Move "Auto" CSS properties from DeprecatedStyleBuilder to the new StyleBuilder.
Created attachment 243616 [details] Patch
Comment on attachment 243616 [details] Patch Instead of doing this as Custom=All, can we make the generator generate this?
(In reply to comment #2) > Comment on attachment 243616 [details] > Patch > > Instead of doing this as Custom=All, can we make the generator generate this? Eventually, I think so (also the Font-related properties for e.g.). I was working on getting rid of DeprecatedStyleBuilder as soon as possible. Then I was planning to do a second pass and see how we can reduce the amount of Custom code. I was thinking it would be easier to group similar properties and prioritize generating the larger groups once all the implementation is in one place. If you disagree, I can take a look at generating these 6 properties already when I find some time.
(In reply to comment #3) > (In reply to comment #2) > > Comment on attachment 243616 [details] > > Patch > > > > Instead of doing this as Custom=All, can we make the generator generate this? > > Eventually, I think so (also the Font-related properties for e.g.). I was > working on getting rid of DeprecatedStyleBuilder as soon as possible. Then I > was planning to do a second pass and see how we can reduce the amount of > Custom code. > > I was thinking it would be easier to group similar properties and prioritize > generating the larger groups once all the implementation is in one place. > > If you disagree, I can take a look at generating these 6 properties already > when I find some time. I am working on this right now. I'll probably leave out the column-gap property for now (i.e. use custom code) as it is a bit different as I don't think we should make the generator more complex for a single property.
(In reply to comment #3) > (In reply to comment #2) > > Comment on attachment 243616 [details] > > Patch > > > > Instead of doing this as Custom=All, can we make the generator generate this? > > Eventually, I think so (also the Font-related properties for e.g.). I was > working on getting rid of DeprecatedStyleBuilder as soon as possible. Then I > was planning to do a second pass and see how we can reduce the amount of > Custom code. > > I was thinking it would be easier to group similar properties and prioritize > generating the larger groups once all the implementation is in one place. > > If you disagree, I can take a look at generating these 6 properties already > when I find some time. That seems reasonable.
Comment on attachment 243616 [details] Patch I am almost done adding support for this in the generator.
Created attachment 243619 [details] Patch
Comment on attachment 243619 [details] Patch now generating most properties.
Comment on attachment 243619 [details] Patch Clearing flags on attachment: 243619 Committed r177630: <http://trac.webkit.org/changeset/177630>
All reviewed patches have been landed. Closing bug.