Bug 138208 – Move -webkit-marquee-increment property to the new StyleBuilder

• Status: RESOLVED
• Resolution: FIXED
• Component: CSS

[Chris Dumez]

Move -webkit-marquee-increment property from DeprecatedStyleBuilder to the new StyleBuilder so that it is generated from CSSPropertyNames.in.

[Chris Dumez]

Created attachment 240657 [details]
Patch

[Sam Weinig]

Comment on attachment 240657 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=240657&action=review

> Source/WebCore/css/StyleBuilderCustom.h:47
> +    auto& primitiveValue = downcast<CSSPrimitiveValue>(value);

What guarantees this cast is safe? Could we have applyValueWebkitMarqueeIncrement() take a CSSPrimitiveValue instead of a CSSValue?

[Chris Dumez]

Created attachment 240680 [details]
Patch

[Chris Dumez]

Comment on attachment 240657 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=240657&action=review

>> Source/WebCore/css/StyleBuilderCustom.h:47
>> +    auto& primitiveValue = downcast<CSSPrimitiveValue>(value);
> 
> What guarantees this cast is safe? Could we have applyValueWebkitMarqueeIncrement() take a CSSPrimitiveValue instead of a CSSValue?

The CSS Parser is already marking sure the value for -webkit-marquee-increment property is a CSSPrimitiveValue so this cast should be safe and the assertion in downcast<>() should protect us against a mismatch between the CSS Parser and the StyleBuilder. The reason the StyleBuilder functions take a CSSValue and not a CSSPrimitiveValue is because not all properties have a CSSPrimitiveValue as value. Some have a CSSValueList for e.g. and make prop.pl does not have any way to know as far as I can tell because this information is coded in the CSSParser, not CSSPropertyNames.in.

I have added a new layout test in the latest patch iteration to gain coverage for non CSSPrimitive values on  -webkit-marquee-increment, and make sure we don't crash.

[Chris Dumez]

Created attachment 240702 [details]
Patch

[Chris Dumez]

Created attachment 240723 [details]
Patch

[Chris Dumez]

ping review?

[Andreas Kling]

Comment on attachment 240723 [details]
Patch

r=me

[WebKit Commit Bot]

Comment on attachment 240723 [details]
Patch

Clearing flags on attachment: 240723

Committed r175439: <http://trac.webkit.org/changeset/175439>

[WebKit Commit Bot]

All reviewed patches have been landed.  Closing bug.