RESOLVED FIXED 138087
Move radius CSS properties to the new StyleBuilder 
https://bugs.webkit.org/show_bug.cgi?id=138087
Summary Move radius CSS properties to the new StyleBuilder
Chris Dumez
Reported 2014-10-26 16:06:25 PDT
Move radius CSS properties from DeprecatedStyleBuilder to the new StyleBuilder so that they are now generated from CSSPropertyNames.in.
Attachments
Patch (11.20 KB, patch)
2014-10-26 17:53 PDT, Chris Dumez 		no flags
DetailsFormatted DiffDiff
Patch (11.23 KB, patch)
2014-10-27 08:49 PDT, Chris Dumez 		no flags
DetailsFormatted DiffDiff
Patch (1.79 KB, patch)
2014-10-27 12:50 PDT, Chris Dumez 		kling: review+
DetailsFormatted DiffDiff
Show Obsolete (2) View All Add attachment proposed patch, testcase, etc.
Chris Dumez
Comment 1 2014-10-26 17:53:38 PDT
Created attachment 240470 [details] Patch
Andreas Kling
Comment 2 2014-10-26 19:19:04 PDT
Comment on attachment 240470 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=240470&action=review > Source/WebCore/css/StyleBuilderConverter.h:175 > + ASSERT(pair && pair->first() && pair->second()); I would break this into (three) separate assertions so you can see which one is failing. > Source/WebCore/css/StyleBuilderConverter.h:181 > + ASSERT(!radiusWidth.isNegative() && !radiusHeight.isNegative()); Ditto here.
Chris Dumez
Comment 3 2014-10-27 08:49:24 PDT
Created attachment 240482 [details] Patch
WebKit Commit Bot
Comment 4 2014-10-27 11:26:05 PDT
Comment on attachment 240482 [details] Patch Clearing flags on attachment: 240482 Committed r175222: <http://trac.webkit.org/changeset/175222>
WebKit Commit Bot
Comment 5 2014-10-27 11:26:10 PDT
All reviewed patches have been landed. Closing bug.
Chris Dumez
Comment 6 2014-10-27 12:29:27 PDT
Seems to have caused a few crashes on the bots: https://build.webkit.org/results/Apple%20Mavericks%20Release%20WK1%20(Tests)/r175222%20(9516)/results.html Looking into it now.
Chris Dumez
Comment 7 2014-10-27 12:37:01 PDT
Reopening due to crashes.
Chris Dumez
Comment 8 2014-10-27 12:50:09 PDT
Created attachment 240494 [details] Patch
Chris Dumez
Comment 9 2014-10-27 13:05:58 PDT
Committed r175228: <http://trac.webkit.org/changeset/175228>
Note You need to log in before you can comment on or make changes to this bug.