Bug 140034 - Kill the DeprecatedStyleBuilder
Summary: Kill the DeprecatedStyleBuilder
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: CSS (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Chris Dumez
URL:
Keywords:
Depends on: 137910 140010
Blocks:
  Show dependency treegraph
 
Reported: 2015-01-01 16:32 PST by Chris Dumez
Modified: 2015-01-02 14:40 PST (History)
6 users (show)

See Also:


Attachments
Patch (70.59 KB, patch)
2015-01-01 19:35 PST, Chris Dumez
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Chris Dumez 2015-01-01 16:32:20 PST
Kill the DeprecatedStyleBuilder by moving the remaining CSS properties to the new StyleBuilder (finally!).
Comment 1 Chris Dumez 2015-01-01 19:35:25 PST
Created attachment 243880 [details]
Patch
Comment 2 Darin Adler 2015-01-02 13:59:36 PST
Comment on attachment 243880 [details]
Patch

It seems like we are a little overboard on the generated code now. I wish more of the loops and such could db in shared code rather than all in the generated files. But I suppose the only way to do that would be templates, and that was madness before.
Comment 3 WebKit Commit Bot 2015-01-02 14:40:17 PST
Comment on attachment 243880 [details]
Patch

Clearing flags on attachment: 243880

Committed r177869: <http://trac.webkit.org/changeset/177869>
Comment 4 WebKit Commit Bot 2015-01-02 14:40:20 PST
All reviewed patches have been landed.  Closing bug.