Bug 138337 – Move 'size' CSS property to the new StyleBuilder

• Status: RESOLVED
• Resolution: FIXED
• Component: CSS

[Chris Dumez]

Move 'size' CSS property to the new StyleBuilder

[Chris Dumez]

Created attachment 240885 [details]
Patch

[Andreas Kling]

Comment on attachment 240885 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=240885&action=review

> Source/WebCore/css/StyleBuilderCustom.h:236
> +inline void applyInheritSize(StyleResolver&) { }
> +inline void applyInitialSize(StyleResolver&) { }

What's this about?

[Andreas Kling]

Comment on attachment 240885 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=240885&action=review

> Source/WebCore/css/StyleBuilderCustom.h:236
> +inline void applyInheritSize(StyleResolver&) { }
> +inline void applyInitialSize(StyleResolver&) { }

What's this about?

[Chris Dumez]

Comment on attachment 240885 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=240885&action=review

> Source/WebCore/css/DeprecatedStyleBuilder.cpp:-1339
> -    static void applyInheritValue(CSSPropertyID, StyleResolver*) { }

I moved the code from here, applyInitial and applyInherit were not doing anything but they need to be defined for the style builder code to build.

[Andreas Kling]

Comment on attachment 240885 [details]
Patch

r=me

[Chris Dumez]

Created attachment 241082 [details]
Patch

[WebKit Commit Bot]

Comment on attachment 241082 [details]
Patch

Clearing flags on attachment: 241082

Committed r175659: <http://trac.webkit.org/changeset/175659>

[WebKit Commit Bot]

All reviewed patches have been landed.  Closing bug.