Bug 138125 - Move "Number" CSS properties to the new StyleBuilder
Summary: Move "Number" CSS properties to the new StyleBuilder
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: CSS (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Chris Dumez
URL:
Keywords:
Depends on: 137910
Blocks:
  Show dependency tree / graph
 
Reported: 2014-10-27 21:55 PDT by Chris Dumez
Modified: 2014-10-28 12:12 PDT (History)
7 users (show)

See Also:

Attachments
Patch (19.36 KB, patch)
2014-10-27 23:02 PDT, Chris Dumez 		no flags Details | Formatted Diff | Diff
Patch (21.39 KB, patch)
2014-10-28 09:21 PDT, Chris Dumez 		no flags Details | Formatted Diff | Diff
Patch (20.92 KB, patch)
2014-10-28 10:29 PDT, Chris Dumez 		no flags Details | Formatted Diff | Diff
Show Obsolete (2) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Chris Dumez 2014-10-27 21:55:57 PDT 
Move "Number" CSS properties from DeprecatedStyleBuilder to the new StyleBuilder:
-webkit-hyphenate-limit-after / -webkit-hyphenate-limit-before / -webkit-shape-image-threshold

They are now generated from CSSPropertyNames.in
Comment 1 Chris Dumez 2014-10-27 23:02:58 PDT 
Created attachment 240530 [details]
Patch
Comment 2 Antti Koivisto 2014-10-28 07:53:36 PDT 
Comment on attachment 240530 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=240530&action=review

> Source/WebCore/css/CSSPropertyNames.in:340
> +-webkit-hyphenate-limit-after [Inherited, NewStyleBuilder, NameForMethods=HyphenationLimitAfter, Converter=Number<short>]
> +-webkit-hyphenate-limit-before [Inherited, NewStyleBuilder, NameForMethods=HyphenationLimitBefore, Converter=Number<short>]
> +-webkit-hyphenate-limit-lines [Inherited, NewStyleBuilder, NameForMethods=HyphenationLimitLines, Custom=Value]

You should add some documentation on how these annotations work, what the name mappings are, where the custom implementations should go and so on. Top of this file might be a good place.
Comment 3 Chris Dumez 2014-10-28 09:21:53 PDT 
Created attachment 240547 [details]
Patch
Comment 4 Chris Dumez 2014-10-28 09:22:38 PDT 
(In reply to comment #2)
> Comment on attachment 240530 [details]
> Patch
> 
> View in context:
> https://bugs.webkit.org/attachment.cgi?id=240530&action=review
> 
> > Source/WebCore/css/CSSPropertyNames.in:340
> > +-webkit-hyphenate-limit-after [Inherited, NewStyleBuilder, NameForMethods=HyphenationLimitAfter, Converter=Number<short>]
> > +-webkit-hyphenate-limit-before [Inherited, NewStyleBuilder, NameForMethods=HyphenationLimitBefore, Converter=Number<short>]
> > +-webkit-hyphenate-limit-lines [Inherited, NewStyleBuilder, NameForMethods=HyphenationLimitLines, Custom=Value]
> 
> You should add some documentation on how these annotations work, what the
> name mappings are, where the custom implementations should go and so on. Top
> of this file might be a good place.

Yes, I have just added the doc to this patch.
Comment 5 Chris Dumez 2014-10-28 10:29:22 PDT 
Created attachment 240552 [details]
Patch
Comment 6 WebKit Commit Bot 2014-10-28 12:12:35 PDT 
Comment on attachment 240552 [details]
Patch

Clearing flags on attachment: 240552

Committed r175267: <http://trac.webkit.org/changeset/175267>
Comment 7 WebKit Commit Bot 2014-10-28 12:12:40 PDT 
All reviewed patches have been landed.  Closing bug.