Bug 140315 - Get rid of legacy StyleBuilder switch in StyleResolver.cpp
Summary: Get rid of legacy StyleBuilder switch in StyleResolver.cpp
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: CSS (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Chris Dumez
URL:
Keywords:
Depends on: 137910
Blocks:
  Show dependency tree / graph
 
Reported: 2015-01-09 14:39 PST by Chris Dumez
Modified: 2015-01-09 17:48 PST (History)
5 users (show)

See Also:

Attachments
Patch (44.80 KB, patch)
2015-01-09 15:21 PST, Chris Dumez 		no flags Details | Formatted Diff | Diff
Patch (44.81 KB, patch)
2015-01-09 15:58 PST, Chris Dumez 		no flags Details | Formatted Diff | Diff
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Chris Dumez 2015-01-09 14:39:06 PST 
Get rid of legacy StyleBuilder switch in StyleResolver.cpp. Most properties have been ported to the generated StyleBuilder already. The ones that remain are shorthand properties and other properties that do no require any StyleBuilder handling.
We should be able to get rid of this switch by introducing a [SkipBuilder] parameter in CSSPropertyNames.in.
Comment 1 Chris Dumez 2015-01-09 15:21:10 PST 
Created attachment 244377 [details]
Patch
Comment 2 Chris Dumez 2015-01-09 15:58:27 PST 
Created attachment 244382 [details]
Patch
Comment 3 Sam Weinig 2015-01-09 17:08:08 PST 
Comment on attachment 244382 [details]
Patch

Nice! r=me.
Comment 4 WebKit Commit Bot 2015-01-09 17:48:45 PST 
Comment on attachment 244382 [details]
Patch

Clearing flags on attachment: 244382

Committed r178228: <http://trac.webkit.org/changeset/178228>
Comment 5 WebKit Commit Bot 2015-01-09 17:48:50 PST 
All reviewed patches have been landed.  Closing bug.