Bug 138000 - Move Length-type CSS properties from DeprecatedStyleBuilder to the new Style Builder
Summary: Move Length-type CSS properties from DeprecatedStyleBuilder to the new Style ...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: CSS (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Chris Dumez
URL: https://src.chromium.org/viewvc/blink...
Keywords: BlinkMergeCandidate
Depends on: 137910
Blocks:
  Show dependency tree / graph
 
Reported: 2014-10-22 21:21 PDT by Chris Dumez
Modified: 2014-10-23 09:14 PDT (History)
6 users (show)

See Also:

Attachments
WIP Patch (36.52 KB, patch)
2014-10-22 22:14 PDT, Chris Dumez 		no flags Details | Formatted Diff | Diff
Patch (40.37 KB, patch)
2014-10-22 22:32 PDT, Chris Dumez 		no flags Details | Formatted Diff | Diff
Patch (36.36 KB, patch)
2014-10-23 08:31 PDT, Chris Dumez 		no flags Details | Formatted Diff | Diff
Show Obsolete (2) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Chris Dumez 2014-10-22 21:21:40 PDT 
Move Length-type CSS properties from DeprecatedStyleBuilder to the new Style Builder so that they are now generated.
Comment 1 Chris Dumez 2014-10-22 22:14:54 PDT 
Created attachment 240328 [details]
WIP Patch
Comment 2 Chris Dumez 2014-10-22 22:32:57 PDT 
Created attachment 240329 [details]
Patch
Comment 3 Andreas Kling 2014-10-22 23:38:39 PDT 
Comment on attachment 240329 [details]
Patch

r=me, but I think we should keep the converter functions in the header file so they can be inlined as-needed in the generated code.
Comment 4 Chris Dumez 2014-10-23 08:31:04 PDT 
Created attachment 240346 [details]
Patch
Comment 5 Chris Dumez 2014-10-23 08:32:10 PDT 
(In reply to comment #3)
> Comment on attachment 240329 [details]
> Patch
> 
> r=me, but I think we should keep the converter functions in the header file
> so they can be inlined as-needed in the generated code.

Ok, I moved them out-of-class in the header and marked them as inline.
Comment 6 WebKit Commit Bot 2014-10-23 09:14:23 PDT 
Comment on attachment 240346 [details]
Patch

Clearing flags on attachment: 240346

Committed r175123: <http://trac.webkit.org/changeset/175123>
Comment 7 WebKit Commit Bot 2014-10-23 09:14:28 PDT 
All reviewed patches have been landed.  Closing bug.