Bug 139104 - Move the '-webkit-locale', '-webkit-text-orientation', '-webkit-writing-mode', '-webkit-justify-self' and '-webkit-perspective' CSS properties to the new StyleBuilder
Summary: Move the '-webkit-locale', '-webkit-text-orientation', '-webkit-writing-mode'...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Sam Weinig
URL:
Keywords:
Depends on: 137910
Blocks:
  Show dependency treegraph
 
Reported: 2014-11-29 15:45 PST by Sam Weinig
Modified: 2015-01-05 19:34 PST (History)
2 users (show)

See Also:


Attachments
Patch (10.81 KB, patch)
2014-11-29 15:45 PST, Sam Weinig
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Sam Weinig 2014-11-29 15:45:16 PST
Move the '-webkit-locale', '-webkit-text-orientation', '-webkit-writing-mode', '-webkit-justify-self' and '-webkit-perspective' CSS properties to the new StyleBuilder
Comment 1 Sam Weinig 2014-11-29 15:45:52 PST
Created attachment 242283 [details]
Patch
Comment 2 WebKit Commit Bot 2014-11-29 16:38:56 PST
Comment on attachment 242283 [details]
Patch

Clearing flags on attachment: 242283

Committed r176584: <http://trac.webkit.org/changeset/176584>
Comment 3 WebKit Commit Bot 2014-11-29 16:38:59 PST
All reviewed patches have been landed.  Closing bug.
Comment 4 Chris Dumez 2015-01-04 14:17:30 PST
Comment on attachment 242283 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=242283&action=review

> Source/WebCore/css/StyleBuilderCustom.h:677
> +    styleResolver.setTextOrientation(downcast<CSSPrimitiveValue>(value));

This does not need custom code, this is the default StyleBuilder behavior. I'll take care of removing this handler.
Comment 5 Chris Dumez 2015-01-04 16:07:21 PST
Comment on attachment 242283 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=242283&action=review

>> Source/WebCore/css/StyleBuilderCustom.h:677
>> +    styleResolver.setTextOrientation(downcast<CSSPrimitiveValue>(value));
> 
> This does not need custom code, this is the default StyleBuilder behavior. I'll take care of removing this handler.

Ah, never mind, I have just noticed the setter is on StyleResolver, not RenderStyle.