Bug 140181 – Move 'font' CSS property to the new StyleBuilder

• Status: RESOLVED
• Resolution: FIXED
• Component: CSS

[Chris Dumez]

Move 'font' CSS property to the new StyleBuilder

[Chris Dumez]

Created attachment 244175 [details]
Patch

[Build Bot]

Comment on attachment 244175 [details]
Patch

Attachment 244175 [details] did not pass mac-ews (mac):
Output: http://webkit-queues.appspot.com/results/5313252326113280

Number of test failures exceeded the failure limit.

[Build Bot]

Created attachment 244177 [details]
Archive of layout-test-results from ews101 for mac-mountainlion

The attached test failures were seen while running run-webkit-tests on the mac-ews.
Bot: ews101  Port: mac-mountainlion  Platform: Mac OS X 10.8.5

[Build Bot]

Comment on attachment 244175 [details]
Patch

Attachment 244175 [details] did not pass mac-wk2-ews (mac-wk2):
Output: http://webkit-queues.appspot.com/results/5167753866510336

Number of test failures exceeded the failure limit.

[Build Bot]

Created attachment 244178 [details]
Archive of layout-test-results from ews106 for mac-mountainlion-wk2

The attached test failures were seen while running run-webkit-tests on the mac-wk2-ews.
Bot: ews106  Port: mac-mountainlion-wk2  Platform: Mac OS X 10.8.5

[Chris Dumez]

Created attachment 244185 [details]
Patch

[Darin Adler]

Comment on attachment 244185 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=244185&action=review

> Source/WebCore/css/StyleResolver.h:289
> +    friend class StyleBuilderCustom;

Making a class a friend is such a blunt tool. Is there some nicer way to do this? Can we make just one function a friend or something?

[WebKit Commit Bot]

Comment on attachment 244185 [details]
Patch

Clearing flags on attachment: 244185

Committed r178101: <http://trac.webkit.org/changeset/178101>

[WebKit Commit Bot]

All reviewed patches have been landed.  Closing bug.