Bug 140181 - Move 'font' CSS property to the new StyleBuilder
Summary: Move 'font' CSS property to the new StyleBuilder
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: CSS (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Chris Dumez
URL:
Keywords:
Depends on: 137910
Blocks:
  Show dependency tree / graph
 
Reported: 2015-01-07 09:57 PST by Chris Dumez
Modified: 2015-01-07 21:37 PST (History)
8 users (show)

See Also:

Attachments
Patch (9.83 KB, patch)
2015-01-07 12:08 PST, Chris Dumez 		no flags Details | Formatted Diff | Diff
Archive of layout-test-results from ews101 for mac-mountainlion (189.38 KB, application/zip)
2015-01-07 12:47 PST, Build Bot 		no flags Details
Archive of layout-test-results from ews106 for mac-mountainlion-wk2 (195.85 KB, application/zip)
2015-01-07 12:49 PST, Build Bot 		no flags Details
Patch (10.31 KB, patch)
2015-01-07 13:24 PST, Chris Dumez 		no flags Details | Formatted Diff | Diff
Show Obsolete (3) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Chris Dumez 2015-01-07 09:57:38 PST 
Move 'font' CSS property to the new StyleBuilder
Comment 1 Chris Dumez 2015-01-07 12:08:48 PST 
Created attachment 244175 [details]
Patch
Comment 2 Build Bot 2015-01-07 12:47:25 PST 
Comment on attachment 244175 [details]
Patch

Attachment 244175 [details] did not pass mac-ews (mac):
Output: http://webkit-queues.appspot.com/results/5313252326113280

Number of test failures exceeded the failure limit.
Comment 3 Build Bot 2015-01-07 12:47:28 PST 
Created attachment 244177 [details]
Archive of layout-test-results from ews101 for mac-mountainlion

The attached test failures were seen while running run-webkit-tests on the mac-ews.
Bot: ews101  Port: mac-mountainlion  Platform: Mac OS X 10.8.5
Comment 4 Build Bot 2015-01-07 12:49:47 PST 
Comment on attachment 244175 [details]
Patch

Attachment 244175 [details] did not pass mac-wk2-ews (mac-wk2):
Output: http://webkit-queues.appspot.com/results/5167753866510336

Number of test failures exceeded the failure limit.
Comment 5 Build Bot 2015-01-07 12:49:49 PST 
Created attachment 244178 [details]
Archive of layout-test-results from ews106 for mac-mountainlion-wk2

The attached test failures were seen while running run-webkit-tests on the mac-wk2-ews.
Bot: ews106  Port: mac-mountainlion-wk2  Platform: Mac OS X 10.8.5
Comment 6 Chris Dumez 2015-01-07 13:24:01 PST 
Created attachment 244185 [details]
Patch
Comment 7 Darin Adler 2015-01-07 20:16:22 PST 
Comment on attachment 244185 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=244185&action=review

> Source/WebCore/css/StyleResolver.h:289
> +    friend class StyleBuilderCustom;

Making a class a friend is such a blunt tool. Is there some nicer way to do this? Can we make just one function a friend or something?
Comment 8 WebKit Commit Bot 2015-01-07 21:37:00 PST 
Comment on attachment 244185 [details]
Patch

Clearing flags on attachment: 244185

Committed r178101: <http://trac.webkit.org/changeset/178101>
Comment 9 WebKit Commit Bot 2015-01-07 21:37:05 PST 
All reviewed patches have been landed.  Closing bug.