Bug 140267 - Move '-webkit-font-feature-settings' CSS property to the new StyleBuilder
Summary: Move '-webkit-font-feature-settings' CSS property to the new StyleBuilder
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: CSS (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Chris Dumez
URL:
Keywords:
Depends on: 137910
Blocks:
  Show dependency treegraph
 
Reported: 2015-01-08 14:03 PST by Chris Dumez
Modified: 2015-01-08 17:42 PST (History)
5 users (show)

See Also:


Attachments
Patch (6.80 KB, patch)
2015-01-08 15:17 PST, Chris Dumez
no flags Details | Formatted Diff | Diff
Patch (8.78 KB, patch)
2015-01-08 16:07 PST, Chris Dumez
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Chris Dumez 2015-01-08 14:03:51 PST
Move '-webkit-font-feature-settings' CSS property to the new StyleBuilder.
Comment 1 Chris Dumez 2015-01-08 15:17:23 PST
Created attachment 244299 [details]
Patch
Comment 2 Chris Dumez 2015-01-08 16:07:30 PST
Created attachment 244308 [details]
Patch
Comment 3 Chris Dumez 2015-01-08 16:10:10 PST
Comment on attachment 244308 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=244308&action=review

> Source/WebCore/css/StyleResolver.cpp:1993
>      switch (id) {

I should be able to get rid of this switch in the next patch. This is the last non-SVG property that needed porting.
Comment 4 Andreas Kling 2015-01-08 16:59:56 PST
Comment on attachment 244308 [details]
Patch

r=me
Comment 5 WebKit Commit Bot 2015-01-08 17:42:11 PST
Comment on attachment 244308 [details]
Patch

Clearing flags on attachment: 244308

Committed r178149: <http://trac.webkit.org/changeset/178149>
Comment 6 WebKit Commit Bot 2015-01-08 17:42:15 PST
All reviewed patches have been landed.  Closing bug.