Bug 187257 – Flaky Test: fetch/fetch-worker-crash.html

• Status: RESOLVED
• Resolution: FIXED
• Component: Tools / Tests

[WebKit Commit Bot]

This is an automatically generated bug from the commit-queue.
fetch/fetch-worker-crash.html has been flaky on the commit-queue.

fetch/fetch-worker-crash.html was authored by [e-mail].
https://trac.webkit.org/browser/trunk/LayoutTests/fetch/fetch-worker-crash.html

The commit-queue just saw fetch/fetch-worker-crash.html flake (DumpRenderTree crashed) while processing attachment 344113 [details] on bug 187250.
Bot: webkit-cq-01  Port: <class 'webkitpy.common.config.ports.MacPort'>  Platform: Mac OS X 10.12.6

The bots will update this with information from each new failure.

If you believe this bug to be fixed or invalid, feel free to close.  The bots will re-open if the flake re-occurs.

If you would like to track this test fix with another bug, please close this bug as a duplicate.  The bots will follow the duplicate chain when making future comments.

[WebKit Commit Bot]

Created attachment 344117 [details]
Archive of layout-test-results from webkit-cq-01

[youenn fablet]

Crash log
Thread 0:: Dispatch queue: com.apple.main-thread
0   libsystem_kernel.dylib        	0x00007fffa453b43a swtch_pri + 10
1   libsystem_pthread.dylib       	0x00007fffa462e479 sched_yield + 11
2   com.apple.JavaScriptCore      	0x000000010d1e5fe1 WTF::WordLock::lockSlow() + 497 (WordLock.cpp:87)
3   com.apple.JavaScriptCore      	0x000000010d1cda3e WTF::installSignalHandler(WTF::Signal, WTF::Function<WTF::SignalAction (WTF::Signal, WTF::SigInfo&, __darwin_x86_thread_state64&)>&&) + 830 (WordLock.h:62)
4   com.apple.JavaScriptCore      	0x000000010dc6a84e _ZNSt3__117__call_once_proxyINS_5tupleIJOZN3JSC7VMTraps12SignalSenderC1ERKN3WTF14AbstractLockerERNS2_2VMEEUlvE_EEEEEvPv + 46 (memory:2733)
5   libc++.1.dylib                	0x00007fffa2fe6874 std::__1::__call_once(unsigned long volatile&, void*, void (*)(void*)) + 139
6   com.apple.JavaScriptCore      	0x000000010dc6a62c JSC::VMTraps::SignalSender::SignalSender(WTF::AbstractLocker const&, JSC::VM&) + 220 (VMTraps.cpp:221)
7   com.apple.JavaScriptCore      	0x000000010dc68607 JSC::VMTraps::fireTrap(JSC::VMTraps::EventType) + 167 (type_traits:3617)
8   com.apple.WebCore             	0x00000001113240b4 WebCore::WorkerThread::stop(WTF::Function<void ()>&&) + 116 (WorkerThread.cpp:287)

[youenn fablet]

Keith, Mark, any idea what could be the issue there?

[Saam Barati]

From the call stack, it seems like we might be installing a signal handler when we’re destroying a worker

[WebKit Commit Bot]

The commit-queue just saw fetch/fetch-worker-crash.html flake (DumpRenderTree crashed) while processing attachment 350695 [details] on bug 189919.
Bot: webkit-cq-01  Port: <class 'webkitpy.common.config.ports.MacPort'>  Platform: Mac OS X 10.12.6

[WebKit Commit Bot]

Created attachment 350700 [details]
Archive of layout-test-results from webkit-cq-01

[WebKit Commit Bot]

The commit-queue just saw fetch/fetch-worker-crash.html flake (DumpRenderTree crashed) while processing attachment 353377 [details] on bug 190936.
Bot: webkit-cq-02  Port: <class 'webkitpy.common.config.ports.MacPort'>  Platform: Mac OS X 10.12.6

[WebKit Commit Bot]

Created attachment 353383 [details]
Archive of layout-test-results from webkit-cq-02

[WebKit Commit Bot]

The commit-queue just saw fetch/fetch-worker-crash.html flake (DumpRenderTree crashed) while processing attachment 358374 [details] on bug 174980.
Bot: webkit-cq-01  Port: <class 'webkitpy.common.config.ports.MacPort'>  Platform: Mac OS X 10.12.6

[WebKit Commit Bot]

Created attachment 358383 [details]
Archive of layout-test-results from webkit-cq-01

[WebKit Commit Bot]

The commit-queue just saw fetch/fetch-worker-crash.html flake (DumpRenderTree crashed) while processing attachment 359176 [details] on bug 193361.
Bot: webkit-cq-03  Port: <class 'webkitpy.common.config.ports.MacPort'>  Platform: Mac OS X 10.13.6

[WebKit Commit Bot]

Created attachment 359180 [details]
Archive of layout-test-results from webkit-cq-03

[WebKit Commit Bot]

The commit-queue just saw fetch/fetch-worker-crash.html flake (DumpRenderTree crashed) while processing attachment 361130 [details] on bug 194158.
Bot: webkit-cq-03  Port: <class 'webkitpy.common.config.ports.MacPort'>  Platform: Mac OS X 10.13.6

[WebKit Commit Bot]

Created attachment 361135 [details]
Archive of layout-test-results from webkit-cq-03

[WebKit Commit Bot]

The commit-queue just saw fetch/fetch-worker-crash.html flake (DumpRenderTree crashed) while processing attachment 361909 [details] on bug 194536.
Bot: webkit-cq-01  Port: <class 'webkitpy.common.config.ports.MacPort'>  Platform: Mac OS X 10.13.6

[WebKit Commit Bot]

Created attachment 361910 [details]
Archive of layout-test-results from webkit-cq-01

[WebKit Commit Bot]

The commit-queue just saw fetch/fetch-worker-crash.html flake (DumpRenderTree crashed) while processing attachment 363377 [details] on bug 194612.
Bot: webkit-cq-01  Port: <class 'webkitpy.common.config.ports.MacPort'>  Platform: Mac OS X 10.13.6

[WebKit Commit Bot]

Created attachment 363382 [details]
Archive of layout-test-results from webkit-cq-01

[Mark Lam]

The crashing stack trace is actually:

Thread 79 Crashed:: WebCore: Worker
0   com.apple.JavaScriptCore      	0x000000010fcfa1ee WTF::registerThreadForMachExceptionHandling(WTF::Thread&) + 302 (Signals.cpp:208)
1   com.apple.JavaScriptCore      	0x00000001108187f7 JSC::JSLock::didAcquireLock() + 263 (JSLock.cpp:161)
2   com.apple.JavaScriptCore      	0x0000000110929d19 JSC::VM::VM(JSC::VM::VMType, JSC::HeapType) + 4793 (Threading.h:333)
3   com.apple.JavaScriptCore      	0x000000011092f98a JSC::VM::create(JSC::HeapType) + 42 (Ref.h:147)
4   com.apple.WebCore             	0x00000001149c907b WebCore::WorkerScriptController::WorkerScriptController(WebCore::WorkerGlobalScope*) + 27 (utility:896)
5   com.apple.WebCore             	0x0000000115662bca WebCore::WorkerGlobalScope::WorkerGlobalScope(WTF::URL const&, WTF::Ref<WebCore::SecurityOrigin, WTF::DumbPtrTraits<WebCore::SecurityOrigin> >&&, WTF::String const&, WTF::String const&, bool, WebCore::WorkerThread&, bool, WTF::Ref<WebCore::SecurityOrigin, WTF::DumbPtrTraits<WebCore::SecurityOrigin> >&&, WTF::MonotonicTime, WebCore::IDBClient::IDBConnectionProxy*, WebCore::SocketProvider*, PAL::SessionID) + 330 (memory:2097)
6   com.apple.WebCore             	0x0000000115663f01 WebCore::DedicatedWorkerThread::createWorkerGlobalScope(WTF::URL const&, WTF::Ref<WebCore::SecurityOrigin, WTF::DumbPtrTraits<WebCore::SecurityOrigin> >&&, WTF::String const&, WTF::String const&, WTF::String const&, bool, WebCore::ContentSecurityPolicyResponseHeaders const&, bool, WTF::Ref<WebCore::SecurityOrigin, WTF::DumbPtrTraits<WebCore::SecurityOrigin> >&&, WTF::MonotonicTime, PAL::SessionID) + 129 (DedicatedWorkerGlobalScope.cpp:53)
7   com.apple.WebCore             	0x000000011566cc01 WebCore::WorkerThread::workerThread() + 129 (WorkerThread.cpp:173)
8   com.apple.JavaScriptCore      	0x000000010fd0f482 WTF::Thread::entryPoint(WTF::Thread::NewThreadContext*) + 194 (memory:2597)
9   com.apple.JavaScriptCore      	0x000000010fd11719 WTF::wtfThreadEntryPoint(void*) + 9 (ThreadingPOSIX.cpp:201)
10  libsystem_pthread.dylib       	0x00007fff7d14e661 _pthread_body + 340
11  libsystem_pthread.dylib       	0x00007fff7d14e50d _pthread_start + 377
12  libsystem_pthread.dylib       	0x00007fff7d14dbf9 thread_start + 13

Signals.cpp:208 is:

inline void setExceptionPorts(const AbstractLocker& threadGroupLocker, Thread& thread)
{
    UNUSED_PARAM(threadGroupLocker);
    kern_return_t result = thread_set_exception_ports(thread.machThread(), activeExceptions, exceptionPort, EXCEPTION_STATE | MACH_EXCEPTION_CODES, MACHINE_THREAD_STATE);
    if (result != KERN_SUCCESS) {
        dataLogLn("thread set port failed due to ", mach_error_string(result));
        CRASH(); //<================= Signals.cpp:208
    }
}

Hence, the reason this crashed is because thread_set_exception_ports() failed.  The next step for debugging this would be to add some logging to see why thread_set_exception_ports() fails.  Keith, any ideas?

[Radar WebKit Bug Importer]

<rdar://problem/48527526>

[Keith Miller]

> 
> Hence, the reason this crashed is because thread_set_exception_ports()
> failed.  The next step for debugging this would be to add some logging to
> see why thread_set_exception_ports() fails.  Keith, any ideas?

In theory, the OS provides a failure reason. We could just make this a WTF crash with info and stuff values into registers.

[WebKit Commit Bot]

The commit-queue just saw fetch/fetch-worker-crash.html flake (DumpRenderTree crashed) while processing attachment 364868 [details] on bug 195755.
Bot: webkit-cq-02  Port: <class 'webkitpy.common.config.ports.MacPort'>  Platform: Mac OS X 10.13.6

[WebKit Commit Bot]

Created attachment 364881 [details]
Archive of layout-test-results from webkit-cq-02

[WebKit Commit Bot]

The commit-queue just saw fetch/fetch-worker-crash.html flake (DumpRenderTree crashed) while processing attachment 366635 [details] on bug 196557.
Bot: webkit-cq-03  Port: <class 'webkitpy.common.config.ports.MacPort'>  Platform: Mac OS X 10.13.6

[WebKit Commit Bot]

Created attachment 366640 [details]
Archive of layout-test-results from webkit-cq-03

[WebKit Commit Bot]

The commit-queue just saw fetch/fetch-worker-crash.html flake (DumpRenderTree crashed) while processing attachment 366658 [details] on bug 196526.
Bot: webkit-cq-03  Port: <class 'webkitpy.common.config.ports.MacPort'>  Platform: Mac OS X 10.13.6

[WebKit Commit Bot]

Created attachment 366666 [details]
Archive of layout-test-results from webkit-cq-03

[WebKit Commit Bot]

The commit-queue just saw fetch/fetch-worker-crash.html flake (DumpRenderTree crashed) while processing attachment 367592 [details] on bug 196995.
Bot: webkit-cq-02  Port: <class 'webkitpy.common.config.ports.MacPort'>  Platform: Mac OS X 10.13.6

[WebKit Commit Bot]

Created attachment 367595 [details]
Archive of layout-test-results from webkit-cq-02

[WebKit Commit Bot]

The commit-queue just saw fetch/fetch-worker-crash.html flake (DumpRenderTree crashed) while processing attachment 367682 [details] on bug 196984.
Bot: webkit-cq-01  Port: <class 'webkitpy.common.config.ports.MacPort'>  Platform: Mac OS X 10.13.6

[WebKit Commit Bot]

Created attachment 367691 [details]
Archive of layout-test-results from webkit-cq-01

[Saam Barati]

Interesting, we're seeing this in stderr:
"thread set port failed due to (ipc/send) invalid port right"

and crashing in:
WTF::registerThreadForMachExceptionHandling

[Robin Morisset]

Here is what I've found so far.
In every crash we have the same pattern, where the main thread is running
0   libsystem_kernel.dylib        	0x00007fff6b096306 swtch_pri + 10
1   libsystem_pthread.dylib       	0x00007fff6b26822e sched_yield + 11
2   com.apple.JavaScriptCore      	0x0000000104fc5d1a WTF::WordLock::lockSlow() + 506 (atomic:929)
3   com.apple.JavaScriptCore      	0x0000000104f7b735 WTF::installSignalHandler(WTF::Signal, WTF::Function<WTF::SignalAction (WTF::Signal, WTF::SigInfo&, __darwin_x86_thread_state64&)>&&) + 533 (Atomics.h:247)
4   com.apple.JavaScriptCore      	0x0000000105bfd7fe _ZNSt3__117__call_once_proxyINS_5tupleIJOZN3JSC7VMTraps12SignalSenderC1ERKN3WTF14AbstractLockerERNS2_2VMEEUlvE_EEEEEvPv + 46 (memory:2595)
5   libc++.1.dylib                	0x00007fff68eda36e std::__1::__call_once(unsigned long volatile&, void*, void (*)(void*)) + 139
6   com.apple.JavaScriptCore      	0x0000000105bfd5da JSC::VMTraps::SignalSender::SignalSender(WTF::AbstractLocker const&, JSC::VM&) + 202 (VMTraps.cpp:237)
7   com.apple.JavaScriptCore      	0x0000000105bfa7a8 JSC::VMTraps::fireTrap(JSC::VMTraps::EventType) + 200 (type_traits:4592)
8   com.apple.WebCore             	0x0000000109d4564b WebCore::WorkerThread::stop(WTF::Function<void ()>&&) + 203 (WorkerThread.cpp:290)

while the crashing thread is running
0   com.apple.JavaScriptCore      	0x0000000104f7b51e WTF::registerThreadForMachExceptionHandling(WTF::Thread&) + 302 (Signals.cpp:208)
1   com.apple.JavaScriptCore      	0x0000000105a379f6 JSC::JSLock::didAcquireLock() + 294 (JSLock.cpp:166)
2   com.apple.JavaScriptCore      	0x0000000105bf155e JSC::VM::VM(JSC::VM::VMType, JSC::HeapType) + 4718 (VM.cpp:350)
3   com.apple.JavaScriptCore      	0x0000000105bf708a JSC::VM::create(JSC::HeapType) + 42 (Ref.h:147)

The crash is not exactly in WTF::registerThreadForMachExceptionHandling, but in setExceptionPorts which is inlined into it. From the error message reported first by Saam, we know that the problem is an "invalid port right".
http://web.mit.edu/darwin/src/modules/xnu/osfmk/man/thread_set_exception_ports.html tells us that the "port right" is the third parameter to thread_set_exception_ports, which is exceptionPort in our case.

exceptionPort is a global variable defined at the top of Signals.cpp:
static mach_port_t exceptionPort;
It is set in exactly one place:
kern_return_t kr = mach_port_allocate(mach_task_self(), MACH_PORT_RIGHT_RECEIVE, &exceptionPort);
in a std::call_once, in startMachExceptionHandlerThread().
Note that startMachExceptionHandlerThread() is called from the main thread just before the point where we are stuck.. and there is no synchronization to make sure it completed and its effect is visible to the worker thread before it uses exceptionPort.

So I think the crash is due to this race between allocating exceptionPort and using it, resulting in an invalid exceptionPort being sometimes passed to the kernel.

I am still trying to understand why we don't hit this problem all the time, and how best to fix it. We must ensure that startMachExceptionHandlerThread() is called at least once before we ever take a JSLock() (such as in VM::VM()), since JSLock::didAcquireLock calls registerThreadForMachExceptionHandling. startMachExceptionHandlerThread is only called from installSignalHandler, which in turn is called from three places:
- VMTraps::SignalSender::SignalSender(..)
- installCrashHandler in SigIllCrashAnalyzer.cpp
- enableFastMemory() in WasmFaultSignalHandler.cpp, 
And new SignalHandler in turn only appears in fireTrap(), which is called from three places:
- void notifyNeedDebuggerBreak() { m_traps.fireTrap(VMTraps::NeedDebuggerBreak); }
- void notifyNeedTermination() { m_traps.fireTrap(VMTraps::NeedTermination); }
- void notifyNeedWatchdogCheck() { m_traps.fireTrap(VMTraps::NeedWatchdogCheck); }
I just don't see how any of these three functions can ever reliably be called before the constructor for VM runs!
As for SigillCrashAnalyzer, it is not enabled by default, and I don't think that fast memories for Wasm are enabled on all platforms. So I must be missing some element since we don't hit that crash literally all the time.

[WebKit Commit Bot]

The commit-queue just saw fetch/fetch-worker-crash.html flake (DumpRenderTree crashed) while processing attachment 368329 [details] on bug 196807.
Bot: webkit-cq-03  Port: <class 'webkitpy.common.config.ports.MacPort'>  Platform: Mac OS X 10.13.6

[WebKit Commit Bot]

Created attachment 368338 [details]
Archive of layout-test-results from webkit-cq-03

[WebKit Commit Bot]

The commit-queue just saw fetch/fetch-worker-crash.html flake (DumpRenderTree crashed) while processing attachment 368615 [details] on bug 197228.
Bot: webkit-cq-01  Port: <class 'webkitpy.common.config.ports.MacPort'>  Platform: Mac OS X 10.13.6

[WebKit Commit Bot]

Created attachment 368619 [details]
Archive of layout-test-results from webkit-cq-01

[WebKit Commit Bot]

The commit-queue just saw fetch/fetch-worker-crash.html flake (DumpRenderTree crashed) while processing attachment 369003 [details] on bug 197566.
Bot: webkit-cq-02  Port: <class 'webkitpy.common.config.ports.MacPort'>  Platform: Mac OS X 10.13.6

[WebKit Commit Bot]

Created attachment 369011 [details]
Archive of layout-test-results from webkit-cq-02

[WebKit Commit Bot]

The commit-queue just saw fetch/fetch-worker-crash.html flake (DumpRenderTree crashed) while processing attachment 369414 [details] on bug 196315.
Bot: webkit-cq-01  Port: <class 'webkitpy.common.config.ports.MacPort'>  Platform: Mac OS X 10.13.6

[WebKit Commit Bot]

Created attachment 369420 [details]
Archive of layout-test-results from webkit-cq-01

[WebKit Commit Bot]

The commit-queue just saw fetch/fetch-worker-crash.html flake (DumpRenderTree crashed) while processing attachment 370437 [details] on bug 198137.
Bot: webkit-cq-01  Port: <class 'webkitpy.common.config.ports.MacPort'>  Platform: Mac OS X 10.13.6

[WebKit Commit Bot]

Created attachment 370441 [details]
Archive of layout-test-results from webkit-cq-01

[WebKit Commit Bot]

The commit-queue just saw fetch/fetch-worker-crash.html flake (DumpRenderTree crashed) while processing attachment 370436 [details] on bug 191253.
Bot: webkit-cq-02  Port: <class 'webkitpy.common.config.ports.MacPort'>  Platform: Mac OS X 10.13.6

[WebKit Commit Bot]

Created attachment 370442 [details]
Archive of layout-test-results from webkit-cq-02

[WebKit Commit Bot]

The commit-queue just saw fetch/fetch-worker-crash.html flake (DumpRenderTree crashed) while processing attachment 370954 [details] on bug 198359.
Bot: webkit-cq-02  Port: <class 'webkitpy.common.config.ports.MacPort'>  Platform: Mac OS X 10.13.6

[WebKit Commit Bot]

Created attachment 370961 [details]
Archive of layout-test-results from webkit-cq-02

[WebKit Commit Bot]

The commit-queue just saw fetch/fetch-worker-crash.html flake (DumpRenderTree crashed) while processing attachment 371166 [details] on bug 198228.
Bot: webkit-cq-03  Port: <class 'webkitpy.common.config.ports.MacPort'>  Platform: Mac OS X 10.13.6

[WebKit Commit Bot]

Created attachment 371169 [details]
Archive of layout-test-results from webkit-cq-03

[WebKit Commit Bot]

The commit-queue just saw fetch/fetch-worker-crash.html flake (DumpRenderTree crashed) while processing attachment 371346 [details] on bug 198534.
Bot: webkit-cq-03  Port: <class 'webkitpy.common.config.ports.MacPort'>  Platform: Mac OS X 10.13.6

[WebKit Commit Bot]

Created attachment 371350 [details]
Archive of layout-test-results from webkit-cq-03

[WebKit Commit Bot]

The commit-queue just saw fetch/fetch-worker-crash.html flake (DumpRenderTree crashed) while processing attachment 372161 [details] on bug 198185.
Bot: webkit-cq-01  Port: <class 'webkitpy.common.config.ports.MacPort'>  Platform: Mac OS X 10.13.6

[WebKit Commit Bot]

Created attachment 372167 [details]
Archive of layout-test-results from webkit-cq-01

[WebKit Commit Bot]

The commit-queue just saw fetch/fetch-worker-crash.html flake (DumpRenderTree crashed) while processing attachment 372603 [details] on bug 199082.
Bot: webkit-cq-03  Port: <class 'webkitpy.common.config.ports.MacPort'>  Platform: Mac OS X 10.13.6

[WebKit Commit Bot]

Created attachment 372605 [details]
Archive of layout-test-results from webkit-cq-03

[WebKit Commit Bot]

The commit-queue just saw fetch/fetch-worker-crash.html flake (DumpRenderTree crashed) while processing attachment 372697 [details] on bug 197009.
Bot: webkit-cq-03  Port: <class 'webkitpy.common.config.ports.MacPort'>  Platform: Mac OS X 10.13.6

[WebKit Commit Bot]

Created attachment 372701 [details]
Archive of layout-test-results from webkit-cq-03

[WebKit Commit Bot]

The commit-queue just saw fetch/fetch-worker-crash.html flake (DumpRenderTree crashed) while processing attachment 375703 [details] on bug 200505.
Bot: webkit-cq-02  Port: <class 'webkitpy.common.config.ports.MacPort'>  Platform: Mac OS X 10.13.6

[WebKit Commit Bot]

Created attachment 375709 [details]
Archive of layout-test-results from webkit-cq-02

[WebKit Commit Bot]

The commit-queue just saw fetch/fetch-worker-crash.html flake (DumpRenderTree crashed) while processing attachment 377478 [details] on bug 201232.
Bot: webkit-cq-01  Port: <class 'webkitpy.common.config.ports.MacPort'>  Platform: Mac OS X 10.13.6

[WebKit Commit Bot]

Created attachment 377618 [details]
Archive of layout-test-results from webkit-cq-01

[WebKit Commit Bot]

The commit-queue just saw fetch/fetch-worker-crash.html flake (DumpRenderTree crashed) while processing attachment 379236 [details] on bug 200391.
Bot: webkit-cq-01  Port: <class 'webkitpy.common.config.ports.MacPort'>  Platform: Mac OS X 10.13.6

[WebKit Commit Bot]

Created attachment 379240 [details]
Archive of layout-test-results from webkit-cq-01

[WebKit Commit Bot]

The commit-queue just saw fetch/fetch-worker-crash.html flake (DumpRenderTree crashed) while processing attachment 379380 [details] on bug 202113.
Bot: webkit-cq-03  Port: <class 'webkitpy.common.config.ports.MacPort'>  Platform: Mac OS X 10.13.6

[WebKit Commit Bot]

Created attachment 379391 [details]
Archive of layout-test-results from webkit-cq-03

[WebKit Commit Bot]

The commit-queue just saw fetch/fetch-worker-crash.html flake (DumpRenderTree crashed) while processing attachment 380672 [details] on bug 202817.
Bot: webkit-cq-01  Port: <class 'webkitpy.common.config.ports.MacPort'>  Platform: Mac OS X 10.13.6

[WebKit Commit Bot]

Created attachment 380675 [details]
Archive of layout-test-results from webkit-cq-01

[WebKit Commit Bot]

The commit-queue just saw fetch/fetch-worker-crash.html flake (DumpRenderTree crashed) while processing attachment 380806 [details] on bug 202872.
Bot: webkit-cq-03  Port: <class 'webkitpy.common.config.ports.MacPort'>  Platform: Mac OS X 10.13.6

[WebKit Commit Bot]

Created attachment 380812 [details]
Archive of layout-test-results from webkit-cq-03

[WebKit Commit Bot]

The commit-queue just saw fetch/fetch-worker-crash.html flake (DumpRenderTree crashed) while processing attachment 381201 [details] on bug 203108.
Bot: webkit-cq-03  Port: <class 'webkitpy.common.config.ports.MacPort'>  Platform: Mac OS X 10.13.6

[WebKit Commit Bot]

Created attachment 381219 [details]
Archive of layout-test-results from webkit-cq-03

[WebKit Commit Bot]

The commit-queue just saw fetch/fetch-worker-crash.html flake (DumpRenderTree crashed) while processing attachment 381289 [details] on bug 202919.
Bot: webkit-cq-03  Port: <class 'webkitpy.common.config.ports.MacPort'>  Platform: Mac OS X 10.13.6

[WebKit Commit Bot]

Created attachment 381306 [details]
Archive of layout-test-results from webkit-cq-03

[WebKit Commit Bot]

The commit-queue just saw fetch/fetch-worker-crash.html flake (DumpRenderTree crashed) while processing attachment 381467 [details] on bug 203202.
Bot: webkit-cq-01  Port: <class 'webkitpy.common.config.ports.MacPort'>  Platform: Mac OS X 10.13.6

[WebKit Commit Bot]

Created attachment 381486 [details]
Archive of layout-test-results from webkit-cq-01

[WebKit Commit Bot]

The commit-queue just saw fetch/fetch-worker-crash.html flake (DumpRenderTree crashed) while processing attachment 381663 [details] on bug 203280.
Bot: webkit-cq-03  Port: <class 'webkitpy.common.config.ports.MacPort'>  Platform: Mac OS X 10.13.6

[WebKit Commit Bot]

Created attachment 381727 [details]
Archive of layout-test-results from webkit-cq-03

[WebKit Commit Bot]

The commit-queue just saw fetch/fetch-worker-crash.html flake (DumpRenderTree crashed) while processing attachment 385214 [details] on bug 205037.
Bot: webkit-cq-03  Port: <class 'webkitpy.common.config.ports.MacPort'>  Platform: Mac OS X 10.13.6

[WebKit Commit Bot]

Created attachment 385219 [details]
Archive of layout-test-results from webkit-cq-03

[WebKit Commit Bot]

The commit-queue just saw fetch/fetch-worker-crash.html flake (DumpRenderTree crashed) while processing attachment 385218 [details] on bug 205035.
Bot: webkit-cq-01  Port: <class 'webkitpy.common.config.ports.MacPort'>  Platform: Mac OS X 10.13.6

[WebKit Commit Bot]

Created attachment 385308 [details]
Archive of layout-test-results from webkit-cq-01

[WebKit Commit Bot]

The commit-queue just saw fetch/fetch-worker-crash.html flake (DumpRenderTree crashed) while processing attachment 386015 [details] on bug 205420.
Bot: webkit-cq-01  Port: <class 'webkitpy.common.config.ports.MacPort'>  Platform: Mac OS X 10.13.6

[WebKit Commit Bot]

Created attachment 386063 [details]
Archive of layout-test-results from webkit-cq-01

[WebKit Commit Bot]

The commit-queue just saw fetch/fetch-worker-crash.html flake (DumpRenderTree crashed) while processing attachment 386237 [details] on bug 204665.
Bot: webkit-cq-01  Port: <class 'webkitpy.common.config.ports.MacPort'>  Platform: Mac OS X 10.13.6

[WebKit Commit Bot]

Created attachment 386262 [details]
Archive of layout-test-results from webkit-cq-01

[WebKit Commit Bot]

The commit-queue just saw fetch/fetch-worker-crash.html flake (DumpRenderTree crashed) while processing attachment 386416 [details] on bug 205597.
Bot: webkit-cq-03  Port: <class 'webkitpy.common.config.ports.MacPort'>  Platform: Mac OS X 10.13.6

[WebKit Commit Bot]

Created attachment 386421 [details]
Archive of layout-test-results from webkit-cq-03

[WebKit Commit Bot]

The commit-queue just saw fetch/fetch-worker-crash.html flake (DumpRenderTree crashed) while processing attachment 386475 [details] on bug 205619.
Bot: webkit-cq-03  Port: <class 'webkitpy.common.config.ports.MacPort'>  Platform: Mac OS X 10.13.6

[WebKit Commit Bot]

Created attachment 386477 [details]
Archive of layout-test-results from webkit-cq-03

[WebKit Commit Bot]

The commit-queue just saw fetch/fetch-worker-crash.html flake (DumpRenderTree crashed) while processing attachment 386520 [details] on bug 205556.
Bot: webkit-cq-01  Port: <class 'webkitpy.common.config.ports.MacPort'>  Platform: Mac OS X 10.13.6

[WebKit Commit Bot]

Created attachment 386526 [details]
Archive of layout-test-results from webkit-cq-01

[WebKit Commit Bot]

The commit-queue just saw fetch/fetch-worker-crash.html flake (DumpRenderTree crashed) while processing attachment 386521 [details] on bug 205555.
Bot: webkit-cq-01  Port: <class 'webkitpy.common.config.ports.MacPort'>  Platform: Mac OS X 10.13.6

[WebKit Commit Bot]

Created attachment 386577 [details]
Archive of layout-test-results from webkit-cq-01

[WebKit Commit Bot]

The commit-queue just saw fetch/fetch-worker-crash.html flake (DumpRenderTree crashed) while processing attachment 386585 [details] on bug 205673.
Bot: webkit-cq-03  Port: <class 'webkitpy.common.config.ports.MacPort'>  Platform: Mac OS X 10.13.6

[WebKit Commit Bot]

Created attachment 386588 [details]
Archive of layout-test-results from webkit-cq-03

[WebKit Commit Bot]

The commit-queue just saw fetch/fetch-worker-crash.html flake (DumpRenderTree crashed) while processing attachment 386649 [details] on bug 205703.
Bot: webkit-cq-01  Port: <class 'webkitpy.common.config.ports.MacPort'>  Platform: Mac OS X 10.13.6

[WebKit Commit Bot]

Created attachment 386670 [details]
Archive of layout-test-results from webkit-cq-01

[WebKit Commit Bot]

The commit-queue just saw fetch/fetch-worker-crash.html flake (DumpRenderTree crashed) while processing attachment 387038 [details] on bug 205830.
Bot: webkit-cq-03  Port: <class 'webkitpy.common.config.ports.MacPort'>  Platform: Mac OS X 10.13.6

[WebKit Commit Bot]

Created attachment 387106 [details]
Archive of layout-test-results from webkit-cq-03

[WebKit Commit Bot]

The commit-queue just saw fetch/fetch-worker-crash.html flake (DumpRenderTree crashed) while processing attachment 387126 [details] on bug 205940.
Bot: webkit-cq-01  Port: <class 'webkitpy.common.config.ports.MacPort'>  Platform: Mac OS X 10.13.6

[WebKit Commit Bot]

Created attachment 387130 [details]
Archive of layout-test-results from webkit-cq-01

[WebKit Commit Bot]

The commit-queue just saw fetch/fetch-worker-crash.html flake (DumpRenderTree crashed) while processing attachment 388766 [details] on bug 206795.
Bot: webkit-cq-03  Port: <class 'webkitpy.common.config.ports.MacPort'>  Platform: Mac OS X 10.14.6

[WebKit Commit Bot]

Created attachment 388771 [details]
Archive of layout-test-results from webkit-cq-03

[WebKit Commit Bot]

The commit-queue just saw fetch/fetch-worker-crash.html flake (DumpRenderTree crashed) while processing attachment 388776 [details] on bug 206799.
Bot: webkit-cq-03  Port: <class 'webkitpy.common.config.ports.MacPort'>  Platform: Mac OS X 10.14.6

[WebKit Commit Bot]

Created attachment 388813 [details]
Archive of layout-test-results from webkit-cq-03

[WebKit Commit Bot]

The commit-queue just saw fetch/fetch-worker-crash.html flake (DumpRenderTree crashed) while processing attachment 389264 [details] on bug 206776.
Bot: webkit-cq-02  Port: <class 'webkitpy.common.config.ports.MacPort'>  Platform: Mac OS X 10.14.6

[WebKit Commit Bot]

Created attachment 389272 [details]
Archive of layout-test-results from webkit-cq-02

[WebKit Commit Bot]

The commit-queue just saw fetch/fetch-worker-crash.html flake (DumpRenderTree crashed) while processing attachment 390087 [details] on bug 207271.
Bot: webkit-cq-03  Port: <class 'webkitpy.common.config.ports.MacPort'>  Platform: Mac OS X 10.14.6

[WebKit Commit Bot]

Created attachment 390213 [details]
Archive of layout-test-results from webkit-cq-03

[WebKit Commit Bot]

The commit-queue just saw fetch/fetch-worker-crash.html flake (DumpRenderTree crashed) while processing attachment 390509 [details] on bug 207628.
Bot: webkit-cq-03  Port: <class 'webkitpy.common.config.ports.MacPort'>  Platform: Mac OS X 10.14.6

[WebKit Commit Bot]

Created attachment 390520 [details]
Archive of layout-test-results from webkit-cq-03

[WebKit Commit Bot]

The commit-queue just saw fetch/fetch-worker-crash.html flake (DumpRenderTree crashed) while processing attachment 391024 [details] on bug 207854.
Bot: webkit-cq-03  Port: <class 'webkitpy.common.config.ports.MacPort'>  Platform: Mac OS X 10.14.6

[WebKit Commit Bot]

Created attachment 391033 [details]
Archive of layout-test-results from webkit-cq-03

[WebKit Commit Bot]

The commit-queue just saw fetch/fetch-worker-crash.html flake (DumpRenderTree crashed) while processing attachment 391309 [details] on bug 208001.
Bot: webkit-cq-02  Port: <class 'webkitpy.common.config.ports.MacPort'>  Platform: Mac OS X 10.14.6

[WebKit Commit Bot]

Created attachment 391326 [details]
Archive of layout-test-results from webkit-cq-02

[WebKit Commit Bot]

The commit-queue just saw fetch/fetch-worker-crash.html flake (DumpRenderTree crashed) while processing attachment 391365 [details] on bug 207975.
Bot: webkit-cq-03  Port: <class 'webkitpy.common.config.ports.MacPort'>  Platform: Mac OS X 10.14.6

[WebKit Commit Bot]

Created attachment 391372 [details]
Archive of layout-test-results from webkit-cq-03

[WebKit Commit Bot]

The commit-queue just saw fetch/fetch-worker-crash.html flake (DumpRenderTree crashed) while processing attachment 391356 [details] on bug 206132.
Bot: webkit-cq-03  Port: <class 'webkitpy.common.config.ports.MacPort'>  Platform: Mac OS X 10.14.6

[WebKit Commit Bot]

Created attachment 391383 [details]
Archive of layout-test-results from webkit-cq-03

[WebKit Commit Bot]

The commit-queue just saw fetch/fetch-worker-crash.html flake (DumpRenderTree crashed) while processing attachment 391949 [details] on bug 208362.
Bot: webkit-cq-03  Port: <class 'webkitpy.common.config.ports.MacPort'>  Platform: Mac OS X 10.14.6

[WebKit Commit Bot]

Created attachment 391953 [details]
Archive of layout-test-results from webkit-cq-03

[WebKit Commit Bot]

The commit-queue just saw fetch/fetch-worker-crash.html flake (DumpRenderTree crashed) while processing attachment 393145 [details] on bug 208804.
Bot: webkit-cq-01  Port: <class 'webkitpy.common.config.ports.MacPort'>  Platform: Mac OS X 10.14.6

[WebKit Commit Bot]

Created attachment 393147 [details]
Archive of layout-test-results from webkit-cq-01

[Robin Morisset]

Created attachment 395277 [details]
Patch

This is a speculative fix, I have not been able to confirm that it fixes the problem as the crash is flaky/non-reproducible

[Ryan Haddad]

Results history link showing that this crash is indeed still happening on the bots:
https://results.webkit.org/?suite=layout-tests&test=fetch%2Ffetch-worker-crash.html

[Yusuke Suzuki]

Comment on attachment 395277 [details]
Patch

r=me

[EWS]

Committed r260165: <https://trac.webkit.org/changeset/260165>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 395277 [details].