Bug 199082 – Web Inspector: Error "null is not an object (evaluating 'syntaxTree.containersOfPosition')" when setting a breakpoint

• Status: RESOLVED
• Resolution: FIXED
• Component: Web Inspector

[Saam Barati]

Created attachment 372587 [details]
test case

This is happening to me on r246642 using a debug build. Attaching html test case here. (If you use a debug build, you'll need to wait until I land https://bugs.webkit.org/show_bug.cgi?id=198775 to have the WHLSL program not crash).

Repro steps:
1. Set a breakpoint on the line: "const shaderModule = device.createShaderModule({code: shaderSource, isWHLSL: true});"
2. reload the page
3. breakpoint will hit, then shortly, inspector will hit this error

[Saam Barati]

stack trace shown in inspector:

null is not an object (evaluating 'syntaxTree.containersOfPosition')​ (at SourceCodeTextEditor.js:​1443:​35)​
    ?​ @ SourceCodeTextEditor.js:​1443:​35
    makeSyntaxTreeAndCallCallback @ Script.js:​212:​21
    ?​ @ Script.js:​226:​42
    promiseReactionJob @ [native code]​

[Devin Rousso]

Created attachment 372589 [details]
Patch

[Matt Baker]

Comment on attachment 372589 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=372589&action=review

rs=me

> Source/WebInspectorUI/ChangeLog:10
> +        The script syntax tree may be fetched even if the resources hasn't finished parsing (or had

Nit: either "resource" or "resources haven't"

[Devin Rousso]

Created attachment 372603 [details]
Patch

[WebKit Commit Bot]

The commit-queue encountered the following flaky tests while processing attachment 372603 [details]:

imported/w3c/web-platform-tests/content-security-policy/reporting/report-multiple-violations-02.html bug 199095 (author: [e-mail])
fetch/fetch-worker-crash.html bug 187257 (author: [e-mail])
The commit-queue is continuing to process your patch.

[WebKit Commit Bot]

Comment on attachment 372603 [details]
Patch

Clearing flags on attachment: 372603

Committed r246667: <https://trac.webkit.org/changeset/246667>

[WebKit Commit Bot]

All reviewed patches have been landed.  Closing bug.

[Radar WebKit Bug Importer]

<rdar://problem/51969446>