e.g: ``` vertex float4 vertexShader(float4 position : attribute(0), float i : attribute(1)) : SV_Position { return position; } fragment float4 fragmentShader(float4 position : SV_Position, constant float[] theBuffer : register(b0)) : SV_Target 0 { //float x; return float4(x, x, x, 1.0); } ```
Crashes in the Checker
working on this next
Created attachment 372593 [details] patch
Comment on attachment 372593 [details] patch View in context: https://bugs.webkit.org/attachment.cgi?id=372593&action=review > LayoutTests/webgpu/whlsl-use-undefined-variable.html:18 > +async function start() { Where are the -expected.txts?
Comment on attachment 372593 [details] patch View in context: https://bugs.webkit.org/attachment.cgi?id=372593&action=review > LayoutTests/ChangeLog:11 > + Myles mostly fixed this in r246631 when he made NameResolver propagate > + its error to its parent NameResolver. However, there was still one bug > + where we ended up calling setError twice for an if statement. This patch > + fixes that and adds tests. OOPS, This should go in WebCore's changelog
Created attachment 372651 [details] patch for landing
Comment on attachment 372651 [details] patch for landing Clearing flags on attachment: 372651 Committed r246700: <https://trac.webkit.org/changeset/246700>
All reviewed patches have been landed. Closing bug.
<rdar://problem/52004615>