Bug 191253 - Fix validateExceptionChecks for CLoop
Summary: Fix validateExceptionChecks for CLoop
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: JavaScriptCore (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Tadeu Zagallo
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2018-11-05 01:55 PST by Tadeu Zagallo
Modified: 2019-05-22 14:04 PDT (History)
8 users (show)

See Also:

Attachments
Patch (5.14 KB, patch)
2018-11-05 02:22 PST, Tadeu Zagallo 		no flags Details | Formatted Diff | Diff
Archive of layout-test-results from ews104 for mac-sierra-wk2 (3.23 MB, application/zip)
2018-11-05 11:40 PST, EWS Watchlist 		no flags Details
Patch for landing (5.13 KB, patch)
2019-05-22 13:10 PDT, Tadeu Zagallo 		no flags Details | Formatted Diff | Diff
Show Obsolete (2) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Tadeu Zagallo 2018-11-05 01:55:19 PST 
...
Comment 1 Tadeu Zagallo 2018-11-05 02:22:42 PST 
Created attachment 353840 [details]
Patch
Comment 2 EWS Watchlist 2018-11-05 11:40:19 PST 
Comment on attachment 353840 [details]
Patch

Attachment 353840 [details] did not pass mac-wk2-ews (mac-wk2):
Output: https://webkit-queues.webkit.org/results/9867403

New failing tests:
imported/w3c/web-platform-tests/webrtc/RTCPeerConnection-setRemoteDescription-tracks.https.html
Comment 3 EWS Watchlist 2018-11-05 11:40:21 PST 
Created attachment 353893 [details]
Archive of layout-test-results from ews104 for mac-sierra-wk2

The attached test failures were seen while running run-webkit-tests on the mac-wk2-ews.
Bot: ews104  Port: mac-sierra-wk2  Platform: Mac OS X 10.12.6
Comment 4 Keith Miller 2019-05-22 11:07:36 PDT 
Comment on attachment 353840 [details]
Patch

r=me.
Comment 5 Tadeu Zagallo 2019-05-22 13:10:30 PDT 
Created attachment 370436 [details]
Patch for landing
Comment 6 WebKit Commit Bot 2019-05-22 14:02:38 PDT 
The commit-queue encountered the following flaky tests while processing attachment 370436 [details]:

fetch/fetch-worker-crash.html bug 187257 (author: youennf@gmail.com)
The commit-queue is continuing to process your patch.
Comment 7 WebKit Commit Bot 2019-05-22 14:03:26 PDT 
Comment on attachment 370436 [details]
Patch for landing

Clearing flags on attachment: 370436

Committed r245646: <https://trac.webkit.org/changeset/245646>
Comment 8 WebKit Commit Bot 2019-05-22 14:03:28 PDT 
All reviewed patches have been landed.  Closing bug.
Comment 9 Radar WebKit Bug Importer 2019-05-22 14:04:24 PDT 
<rdar://problem/51041175>