Bug 203108 - Don't put pages that have not reached the non-visually empty layout milestone in the back/forward cache
Summary: Don't put pages that have not reached the non-visually empty layout milestone...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebCore Misc. (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Chris Dumez
URL:
Keywords: InRadar
Depends on:
Blocks: 202293
  Show dependency tree / graph
 
Reported: 2019-10-17 10:04 PDT by Chris Dumez
Modified: 2019-10-17 22:01 PDT (History)
5 users (show)

See Also:

Attachments
Patch (3.24 KB, patch)
2019-10-17 10:32 PDT, Chris Dumez 		no flags Details | Formatted Diff | Diff
Patch (4.81 KB, patch)
2019-10-17 21:05 PDT, Chris Dumez 		no flags Details | Formatted Diff | Diff
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Chris Dumez 2019-10-17 10:04:51 PDT 
Don't put pages that have not reached the non-visually empty layout milestone in the back/forward cache.
Comment 1 Chris Dumez 2019-10-17 10:32:15 PDT 
Created attachment 381201 [details]
Patch
Comment 2 Geoffrey Garen 2019-10-17 10:36:17 PDT 
Comment on attachment 381201 [details]
Patch

r=me
Comment 3 Radar WebKit Bug Importer 2019-10-17 10:36:27 PDT 
<rdar://problem/56375671>
Comment 4 WebKit Commit Bot 2019-10-17 13:30:52 PDT 
The commit-queue encountered the following flaky tests while processing attachment 381201 [details]:

fetch/fetch-worker-crash.html bug 187257 (author: youennf@gmail.com)
The commit-queue is continuing to process your patch.
Comment 5 WebKit Commit Bot 2019-10-17 13:31:43 PDT 
Comment on attachment 381201 [details]
Patch

Clearing flags on attachment: 381201

Committed r251255: <https://trac.webkit.org/changeset/251255>
Comment 6 WebKit Commit Bot 2019-10-17 13:31:45 PDT 
All reviewed patches have been landed.  Closing bug.
Comment 7 Chris Dumez 2019-10-17 16:42:16 PDT 
Reverted r251255 for reason:

This is causing the existing back/forward tests to be flaky

Committed r251267: <https://trac.webkit.org/changeset/251267>
Comment 8 Chris Dumez 2019-10-17 21:05:19 PDT 
Created attachment 381265 [details]
Patch
Comment 9 WebKit Commit Bot 2019-10-17 22:01:57 PDT 
Comment on attachment 381265 [details]
Patch

Clearing flags on attachment: 381265

Committed r251275: <https://trac.webkit.org/changeset/251275>
Comment 10 WebKit Commit Bot 2019-10-17 22:01:59 PDT 
All reviewed patches have been landed.  Closing bug.