Bug 187250 – InstanceOf IC should do generic if the prototype is not an object.

• Status: RESOLVED
• Resolution: FIXED
• Component: New Bugs

[Keith Miller]

InstanceOf IC should do generic if the prototype is not an object.

[Keith Miller]

Created attachment 344109 [details]
Patch

[Keith Miller]

rdar://problem/41387395

[Mark Lam]

Comment on attachment 344109 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=344109&action=review

r=me

> Source/JavaScriptCore/jit/Repatch.cpp:743
>          if (!jsDynamicCast<JSObject*>(vm, value)) {

Fix this indentation.

[Keith Miller]

Comment on attachment 344109 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=344109&action=review

>> Source/JavaScriptCore/jit/Repatch.cpp:743
>>          if (!jsDynamicCast<JSObject*>(vm, value)) {
> 
> Fix this indentation.

Whoops, fixed.

[Keith Miller]

Created attachment 344113 [details]
Patch for landing

[Saam Barati]

Comment on attachment 344113 [details]
Patch for landing

View in context: https://bugs.webkit.org/attachment.cgi?id=344113&action=review

> Source/JavaScriptCore/ChangeLog:3
> +        InstanceOf IC should do generic if the prototype is not an object.

do generic => go generic

[Keith Miller]

Comment on attachment 344113 [details]
Patch for landing

View in context: https://bugs.webkit.org/attachment.cgi?id=344113&action=review

>> Source/JavaScriptCore/ChangeLog:3
>> +        InstanceOf IC should do generic if the prototype is not an object.
> 
> do generic => go generic

I don't think that's accurate since you can still have Hit/Miss cases even with a generic case.

[Saam Barati]

I'm just talking about the english of your title. "Generic" is not a thing you "do". Perhaps "become" is the right word

[WebKit Commit Bot]

The commit-queue encountered the following flaky tests while processing attachment 344113 [details]:

fetch/fetch-worker-crash.html bug 187257 (author: [e-mail])
The commit-queue is continuing to process your patch.

[WebKit Commit Bot]

Comment on attachment 344113 [details]
Patch for landing

Clearing flags on attachment: 344113

Committed r233427: <https://trac.webkit.org/changeset/233427>

[WebKit Commit Bot]

All reviewed patches have been landed.  Closing bug.