Bug 187250 - InstanceOf IC should do generic if the prototype is not an object.
Summary: InstanceOf IC should do generic if the prototype is not an object.
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Keith Miller
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2018-07-02 09:36 PDT by Keith Miller
Modified: 2018-07-02 11:05 PDT (History)
6 users (show)

See Also:


Attachments
Patch (4.89 KB, patch)
2018-07-02 09:50 PDT, Keith Miller
no flags Details | Formatted Diff | Diff
Patch for landing (4.94 KB, patch)
2018-07-02 10:14 PDT, Keith Miller
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Keith Miller 2018-07-02 09:36:55 PDT
InstanceOf IC should do generic if the prototype is not an object.
Comment 1 Keith Miller 2018-07-02 09:50:22 PDT
Created attachment 344109 [details]
Patch
Comment 2 Keith Miller 2018-07-02 09:56:59 PDT
rdar://problem/41387395
Comment 3 Mark Lam 2018-07-02 10:12:28 PDT
Comment on attachment 344109 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=344109&action=review

r=me

> Source/JavaScriptCore/jit/Repatch.cpp:743
>          if (!jsDynamicCast<JSObject*>(vm, value)) {

Fix this indentation.
Comment 4 Keith Miller 2018-07-02 10:13:42 PDT
Comment on attachment 344109 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=344109&action=review

>> Source/JavaScriptCore/jit/Repatch.cpp:743
>>          if (!jsDynamicCast<JSObject*>(vm, value)) {
> 
> Fix this indentation.

Whoops, fixed.
Comment 5 Keith Miller 2018-07-02 10:14:13 PDT
Created attachment 344113 [details]
Patch for landing
Comment 6 Saam Barati 2018-07-02 10:18:23 PDT
Comment on attachment 344113 [details]
Patch for landing

View in context: https://bugs.webkit.org/attachment.cgi?id=344113&action=review

> Source/JavaScriptCore/ChangeLog:3
> +        InstanceOf IC should do generic if the prototype is not an object.

do generic => go generic
Comment 7 Keith Miller 2018-07-02 10:20:19 PDT
Comment on attachment 344113 [details]
Patch for landing

View in context: https://bugs.webkit.org/attachment.cgi?id=344113&action=review

>> Source/JavaScriptCore/ChangeLog:3
>> +        InstanceOf IC should do generic if the prototype is not an object.
> 
> do generic => go generic

I don't think that's accurate since you can still have Hit/Miss cases even with a generic case.
Comment 8 Saam Barati 2018-07-02 10:54:26 PDT
I'm just talking about the english of your title. "Generic" is not a thing you "do". Perhaps "become" is the right word
Comment 9 WebKit Commit Bot 2018-07-02 11:04:14 PDT
The commit-queue encountered the following flaky tests while processing attachment 344113 [details]:

fetch/fetch-worker-crash.html bug 187257 (author: youennf@gmail.com)
The commit-queue is continuing to process your patch.
Comment 10 WebKit Commit Bot 2018-07-02 11:05:02 PDT
Comment on attachment 344113 [details]
Patch for landing

Clearing flags on attachment: 344113

Committed r233427: <https://trac.webkit.org/changeset/233427>
Comment 11 WebKit Commit Bot 2018-07-02 11:05:04 PDT
All reviewed patches have been landed.  Closing bug.