Bug 202919 - [CSS Shadow Parts] ::part rules should be able to override style attribute
Summary: [CSS Shadow Parts] ::part rules should be able to override style attribute
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: CSS (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Nobody
URL:
Keywords: InRadar
Depends on: 203029
Blocks: 149443
  Show dependency tree / graph
 
Reported: 2019-10-14 01:19 PDT by Emilio Cobos Álvarez (:emilio)
Modified: 2019-10-18 09:21 PDT (History)
13 users (show)

See Also:

Attachments
Testcase. (617 bytes, text/html)
2019-10-14 01:19 PDT, Emilio Cobos Álvarez (:emilio) 		no flags Details
patch (13.28 KB, patch)
2019-10-16 08:03 PDT, Antti Koivisto 		no flags Details | Formatted Diff | Diff
patch (17.35 KB, patch)
2019-10-17 04:43 PDT, Antti Koivisto 		no flags Details | Formatted Diff | Diff
patch (18.15 KB, patch)
2019-10-18 02:28 PDT, Antti Koivisto 		no flags Details | Formatted Diff | Diff
patch (18.08 KB, patch)
2019-10-18 02:40 PDT, Antti Koivisto 		no flags Details | Formatted Diff | Diff
Show Obsolete (3) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Emilio Cobos Álvarez (:emilio) 2019-10-14 01:19:04 PDT 
Created attachment 380861 [details]
Testcase.

See the test-case.

WebKit trunk behaves the same as Firefox, but I think Chromium is technically correct.
Comment 1 Jan Miksovsky 2019-10-15 16:36:33 PDT 
I filed https://github.com/w3c/webcomponents/issues/847 just to make sure everyone's on board with following Chrome's behavior.
Comment 2 Antti Koivisto 2019-10-16 00:16:44 PDT 
Inline style is simply appended to the matching declaration list, and not sorted with the rest of the author style, because before this feature it would always win.
Comment 3 Antti Koivisto 2019-10-16 08:03:44 PDT 
Created attachment 381069 [details]
patch
Comment 4 Antti Koivisto 2019-10-17 04:43:19 PDT 
Created attachment 381189 [details]
patch
Comment 5 Antti Koivisto 2019-10-18 02:28:37 PDT 
Created attachment 381286 [details]
patch
Comment 6 Antti Koivisto 2019-10-18 02:40:33 PDT 
Created attachment 381289 [details]
patch
Comment 7 WebKit Commit Bot 2019-10-18 09:19:31 PDT 
The commit-queue encountered the following flaky tests while processing attachment 381289 [details]:

fetch/fetch-worker-crash.html bug 187257 (author: youennf@gmail.com)
The commit-queue is continuing to process your patch.
Comment 8 WebKit Commit Bot 2019-10-18 09:20:23 PDT 
Comment on attachment 381289 [details]
patch

Clearing flags on attachment: 381289

Committed r251285: <https://trac.webkit.org/changeset/251285>
Comment 9 WebKit Commit Bot 2019-10-18 09:20:25 PDT 
All reviewed patches have been landed.  Closing bug.
Comment 10 Radar WebKit Bug Importer 2019-10-18 09:21:14 PDT 
<rdar://problem/56408673>