Bug 202872 - USE_ANGLE=1 build broken with last ANGLE roll
Summary: USE_ANGLE=1 build broken with last ANGLE roll
Alias: None
Product: WebKit
Classification: Unclassified
Component: ANGLE (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Kenneth Russell
Keywords: InRadar
Depends on: 202780
  Show dependency treegraph
Reported: 2019-10-11 17:08 PDT by Kenneth Russell
Modified: 2019-10-15 14:37 PDT (History)
14 users (show)

See Also:

Patch (4.02 KB, patch)
2019-10-11 17:13 PDT, Kenneth Russell
no flags Details | Formatted Diff | Diff
Patch (5.96 KB, patch)
2019-10-11 18:00 PDT, Kenneth Russell
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Kenneth Russell 2019-10-11 17:08:44 PDT
The last ANGLE roll in https://bugs.webkit.org/show_bug.cgi?id=202780 broke WebKit's USE_ANGLE=1 build due to not including FrameCapture.cpp.

Upstream ANGLE bug https://bugs.chromium.org/p/angleproject/issues/detail?id=4001 has been filed about this issue and a patch is up for review. A small patch can be applied to WebKit's copy of ANGLE to fix this build.
Comment 1 Kenneth Russell 2019-10-11 17:13:17 PDT
Created attachment 380803 [details]
Comment 2 Kenneth Russell 2019-10-11 17:13:59 PDT
Tested locally with USE_ANGLE=1 build. Sorry for the breakage; I was obviously testing the USE_ANGLE=0 build locally for a while for another patch.
Comment 3 EWS Watchlist 2019-10-11 17:14:18 PDT
Note that there are important steps to take when updating ANGLE. See http://trac.webkit.org/wiki/UpdatingANGLE
Comment 4 Kenneth Russell 2019-10-11 17:31:28 PDT
Comment on attachment 380803 [details]

Never mind, there's probably a better build fix per feedback on the upstream ANGLE bug.
Comment 5 Kenneth Russell 2019-10-11 18:00:49 PDT
Created attachment 380806 [details]
Comment 6 Kenneth Russell 2019-10-11 18:01:14 PDT
Comment on attachment 380806 [details]

This is the approach recommended by the ANGLE developers.
Comment 7 WebKit Commit Bot 2019-10-11 19:56:26 PDT
The commit-queue encountered the following flaky tests while processing attachment 380806 [details]:

fetch/fetch-worker-crash.html bug 187257 (author: youennf@gmail.com)
The commit-queue is continuing to process your patch.
Comment 8 WebKit Commit Bot 2019-10-11 19:57:18 PDT
Comment on attachment 380806 [details]

Clearing flags on attachment: 380806

Committed r251037: <https://trac.webkit.org/changeset/251037>
Comment 9 WebKit Commit Bot 2019-10-11 19:57:20 PDT
All reviewed patches have been landed.  Closing bug.
Comment 10 Radar WebKit Bug Importer 2019-10-15 14:37:22 PDT