Bug 202780 - Roll ANGLE for ETC extensions and EGL_ANGLE_device_cgl
Summary: Roll ANGLE for ETC extensions and EGL_ANGLE_device_cgl
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: ANGLE (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Kenneth Russell
URL:
Keywords: InRadar
Depends on:
Blocks: 197900 200904 202872
  Show dependency treegraph
 
Reported: 2019-10-09 20:25 PDT by Kenneth Russell
Modified: 2019-10-12 00:51 PDT (History)
13 users (show)

See Also:


Attachments
Patch (6.19 MB, patch)
2019-10-10 17:13 PDT, Kenneth Russell
achristensen: review+
Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Kenneth Russell 2019-10-09 20:25:40 PDT
Need to roll ANGLE forward to pick up the following two fixes:

Add EGL_ANGLE_device_cgl extension
https://chromium.googlesource.com/angle/angle/+/8e7d9d6c2326a36ff57335ceeb41eb86cb639a7f

and:

(ANGLE) Rename CHROMIUM_compressed_texture_etc to use ANGLE_ prefix.
https://chromium.googlesource.com/angle/angle/+/d01ae535b36c47b8f09b2c43a9a213c40fc2a55c

for the following two bugs:

Implement accelerated video-to-texture upload path for ANGLE backend for WebGL on desktop
https://bugs.webkit.org/show_bug.cgi?id=200904

and:

Please support WEBGL_compressed_texture_etc1 extension (and possibly WEBGL_compressed_texture_etc too)
https://bugs.webkit.org/show_bug.cgi?id=197900
Comment 1 Kenneth Russell 2019-10-09 21:42:33 PDT
Also need this follow-up change:

Conditionalize DeviceCGL implementation
https://chromium.googlesource.com/angle/angle/+/c5e0ac757a112a24a0118d434e652fd7b558e6a8
Comment 2 Kenneth Russell 2019-10-10 17:13:23 PDT
Created attachment 380703 [details]
Patch
Comment 3 EWS Watchlist 2019-10-10 17:15:00 PDT
Note that there are important steps to take when updating ANGLE. See http://trac.webkit.org/wiki/UpdatingANGLE
Comment 4 Kenneth Russell 2019-10-10 17:55:58 PDT
This is a mega-patch, but there are no changes relative to upstream ANGLE.

The only build changes needed were to remove the FrameCapture source files from the Xcode and CMake projects, and to add the new DeviceCGL.cpp/h files for the CGL backend.
Comment 5 Alex Christensen 2019-10-11 13:21:41 PDT
https://trac.webkit.org/changeset/251018/webkit
Comment 6 Dean Jackson 2019-10-11 13:33:16 PDT
In the future I don't think it's worth including all the changes in the ChangeLog. Just saying ANGLE was rolled was enough.
Comment 7 Kenneth Russell 2019-10-11 14:28:17 PDT
Thanks Alex for your review and help landing this patch, and Dean for the suggestion - will edit down the ChangeLog next time.
Comment 8 Dean Jackson 2019-10-11 17:17:59 PDT
<rdar://problem/56201832>

Our bug importer keeps importing this without putting the keywords on.