WebKit Bugzilla
New
Browse
Log In
×
Sign in with GitHub
or
Remember my login
Create Account
·
Forgot Password
Forgotten password account recovery
RESOLVED FIXED
Bug 202780
Roll ANGLE for ETC extensions and EGL_ANGLE_device_cgl
https://bugs.webkit.org/show_bug.cgi?id=202780
Summary
Roll ANGLE for ETC extensions and EGL_ANGLE_device_cgl
Kenneth Russell
Reported
2019-10-09 20:25:40 PDT
Need to roll ANGLE forward to pick up the following two fixes: Add EGL_ANGLE_device_cgl extension
https://chromium.googlesource.com/angle/angle/+/8e7d9d6c2326a36ff57335ceeb41eb86cb639a7f
and: (ANGLE) Rename CHROMIUM_compressed_texture_etc to use ANGLE_ prefix.
https://chromium.googlesource.com/angle/angle/+/d01ae535b36c47b8f09b2c43a9a213c40fc2a55c
for the following two bugs: Implement accelerated video-to-texture upload path for ANGLE backend for WebGL on desktop
https://bugs.webkit.org/show_bug.cgi?id=200904
and: Please support WEBGL_compressed_texture_etc1 extension (and possibly WEBGL_compressed_texture_etc too)
https://bugs.webkit.org/show_bug.cgi?id=197900
Attachments
Patch
(6.19 MB, patch)
2019-10-10 17:13 PDT
,
Kenneth Russell
achristensen
: review+
Details
Formatted Diff
Diff
View All
Add attachment
proposed patch, testcase, etc.
Kenneth Russell
Comment 1
2019-10-09 21:42:33 PDT
Also need this follow-up change: Conditionalize DeviceCGL implementation
https://chromium.googlesource.com/angle/angle/+/c5e0ac757a112a24a0118d434e652fd7b558e6a8
Kenneth Russell
Comment 2
2019-10-10 17:13:23 PDT
Created
attachment 380703
[details]
Patch
EWS Watchlist
Comment 3
2019-10-10 17:15:00 PDT
Note that there are important steps to take when updating ANGLE. See
http://trac.webkit.org/wiki/UpdatingANGLE
Kenneth Russell
Comment 4
2019-10-10 17:55:58 PDT
This is a mega-patch, but there are no changes relative to upstream ANGLE. The only build changes needed were to remove the FrameCapture source files from the Xcode and CMake projects, and to add the new DeviceCGL.cpp/h files for the CGL backend.
Alex Christensen
Comment 5
2019-10-11 13:21:41 PDT
https://trac.webkit.org/changeset/251018/webkit
Dean Jackson
Comment 6
2019-10-11 13:33:16 PDT
In the future I don't think it's worth including all the changes in the ChangeLog. Just saying ANGLE was rolled was enough.
Kenneth Russell
Comment 7
2019-10-11 14:28:17 PDT
Thanks Alex for your review and help landing this patch, and Dean for the suggestion - will edit down the ChangeLog next time.
Dean Jackson
Comment 8
2019-10-11 17:17:59 PDT
<
rdar://problem/56201832
> Our bug importer keeps importing this without putting the keywords on.
Note
You need to
log in
before you can comment on or make changes to this bug.
Top of Page
Format For Printing
XML
Clone This Bug