Wincairo build seems to be broken. EWS and build.webkit.org seems to be failing with below build error, e.g.: https://ews-build.webkit.org/#/builders/12/builds/7400/steps/9/logs/stdio, https://build.webkit.org/builders/WinCairo%2064-bit%20WKL%20Debug%20%28Build%29/builds/11035/steps/compile-webkit/logs/stdio
[1854/5075] Linking CXX shared library bin64\libGLESv2.dll
FAILED: bin64/libGLESv2.dll lib64/libGLESv2.lib
cmd.exe /C "cd . && C:\tools\cmake\bin\cmake.exe -E vs_link_dll --intdir=Source\ThirdParty\ANGLE\CMakeFiles\GLESv2.dir --rc="C:\Program Files (x86)\Windows Kits\10\bin\10.0.17763.0\x64\rc.exe" --mt="C:\Program Files (x86)\Windows Kits\10\bin\10.0.17763.0\x64\mt.exe"
winspool.lib shell32.lib ole32.lib oleaut32.lib uuid.lib comdlg32.lib advapi32.lib /MANIFEST /MANIFESTFILE:bin64\libGLESv2.dll.manifest" failed (exit code 1120) with the following output:
Creating library lib64\libGLESv2.lib and object lib64\libGLESv2.exp
LINK : warning LNK4217: symbol 'ANGLEGetDisplayPlatform' defined in 'ANGLE.lib(Platform.cpp.obj)' is imported by 'proc_table_egl_autogen.cpp.obj' in function ...
LINK : warning LNK4217: symbol 'ANGLEResetDisplayPlatform' defined in 'ANGLE.lib(Platform.cpp.obj)' is imported by 'proc_table_egl_autogen.cpp.obj' in function ...
ANGLE.lib(Renderer11.cpp.obj) : error LNK2019: unresolved external symbol CreateDXGIFactory1 referenced in function ...
bin64\libGLESv2.dll : fatal error LNK1120: 1 unresolved externals
[1858/5075] Building CXX object Source\WebCore\PAL\pal\CMakeFiles\PAL.dir\FileSizeFormatter.cpp.obj
ninja: build stopped: subcommand failed.
Failed in r251019 (https://build.webkit.org/builders/WinCairo%2064-bit%20WKL%20Debug%20%28Build%29/builds/11011)
Passed in r251017 (https://build.webkit.org/builders/WinCairo%2064-bit%20WKL%20Debug%20%28Build%29/builds/11010)
Seems to be broken by https://trac.webkit.org/changeset/251018/webkit
Created attachment 380831 [details]
It seems like the function that was being complained about is in dxgi, and adding that to where dxguid is defined seems to work.
I'm uncertain if the same issue will apply to FTW as well as the library line there seems similar to the one in PlatformWin.
Note that there are important steps to take when updating ANGLE. See http://trac.webkit.org/wiki/UpdatingANGLE
I'd gotten a second unrelated error locally after fixing this, but am not sure whether I should be trying to fix that in this or a separate ticket.
Comment on attachment 380831 [details]
Clearing flags on attachment: 380831
Committed r251056: <https://trac.webkit.org/changeset/251056>
All reviewed patches have been landed. Closing bug.
It seems like another fix is needed. The build is still failing at a later stage with the error:
..\..\Source\WebCore\platform\network\curl\SynchronousLoaderClientCurl.cpp(32): fatal error C1083: Cannot open include file: 'EventLoop.h': No such file or directory
Sorry about the breakage and thanks for fixing this build issue!