Bug 202893 - Wincairo build broken: EventLoop.h: No such file or directory
Summary: Wincairo build broken: EventLoop.h: No such file or directory
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: Other
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Stephan Szabo
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2019-10-13 06:53 PDT by Aakash Jain
Modified: 2019-10-15 15:11 PDT (History)
12 users (show)

See Also:

Attachments
Patch removing include of EventLoop.h (1.14 KB, patch)
2019-10-13 09:22 PDT, Stephan Szabo 		no flags Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Aakash Jain 2019-10-13 06:53:15 PDT 
Wincairo build seems to be broken recently. There was a build fix in https://bugs.webkit.org/show_bug.cgi?id=202879, however, the build is now failing with another error:

"..\..\Source\WebCore\platform\network\curl\SynchronousLoaderClientCurl.cpp(32): fatal error C1083: Cannot open include file: 'EventLoop.h': No such file or directory"

e.g.: https://build.webkit.org/builders/WinCairo%2064-bit%20WKL%20Debug%20%28Build%29/builds/11048
Comment 1 Stephan Szabo 2019-10-13 09:22:57 PDT 
Created attachment 380848 [details]
Patch removing include of EventLoop.h

This built for me and things I tried in minibrowser seemed to work just without the include.
Comment 2 WebKit Commit Bot 2019-10-13 16:49:09 PDT 
Comment on attachment 380848 [details]
Patch removing include of EventLoop.h

Clearing flags on attachment: 380848

Committed r251062: <https://trac.webkit.org/changeset/251062>
Comment 3 WebKit Commit Bot 2019-10-13 16:49:11 PDT 
All reviewed patches have been landed.  Closing bug.
Comment 4 Ling Ho 2019-10-15 15:11:37 PDT 
<rdar://problem/56234491>