Bug 198137 - WebKit does not generate an ESC key event for CMD+.
Summary: WebKit does not generate an ESC key event for CMD+.
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebKit Misc. (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Brent Fulgham
Keywords: InRadar
Depends on:
Reported: 2019-05-22 13:05 PDT by Brent Fulgham
Modified: 2019-07-05 10:42 PDT (History)
4 users (show)

See Also:

Patch (2.03 KB, patch)
2019-05-22 13:11 PDT, Brent Fulgham
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Brent Fulgham 2019-05-22 13:05:46 PDT
The Apple iPad keyboard does not have an escape key. The CMD+. keystroke maps to ESC, but WebKit does not honor this behavior.
Comment 1 Brent Fulgham 2019-05-22 13:11:31 PDT
Created attachment 370437 [details]
Comment 2 Brent Fulgham 2019-05-22 13:12:19 PDT
Comment 3 Brent Fulgham 2019-05-22 13:14:41 PDT
Comment on attachment 370437 [details]

r=me (I uploaded the patch, but the code change is Daniel's).
Comment 4 WebKit Commit Bot 2019-05-22 13:57:55 PDT
The commit-queue encountered the following flaky tests while processing attachment 370437 [details]:

fetch/fetch-worker-crash.html bug 187257 (author: youennf@gmail.com)
The commit-queue is continuing to process your patch.
Comment 5 WebKit Commit Bot 2019-05-22 13:58:38 PDT
Comment on attachment 370437 [details]

Clearing flags on attachment: 370437

Committed r245644: <https://trac.webkit.org/changeset/245644>
Comment 6 WebKit Commit Bot 2019-05-22 13:58:40 PDT
All reviewed patches have been landed.  Closing bug.