Bug 205940 - Fix testing Makefile to inherit preprocessor definitions
Summary: Fix testing Makefile to inherit preprocessor definitions
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Keith Miller
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2020-01-08 11:24 PST by Keith Miller
Modified: 2020-01-08 13:19 PST (History)
3 users (show)

See Also:


Attachments
Patch (1.87 KB, patch)
2020-01-08 11:34 PST, Keith Miller
no flags Details | Formatted Diff | Diff
Patch (2.65 KB, patch)
2020-01-08 11:46 PST, Keith Miller
no flags Details | Formatted Diff | Diff
Patch for landing (2.39 KB, patch)
2020-01-08 12:08 PST, Keith Miller
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Keith Miller 2020-01-08 11:24:50 PST
Fix testing Makefile to inherit preprocessor definitions
Comment 1 Keith Miller 2020-01-08 11:34:07 PST
Created attachment 387117 [details]
Patch
Comment 2 Keith Miller 2020-01-08 11:46:30 PST
Created attachment 387119 [details]
Patch
Comment 3 Mark Lam 2020-01-08 12:07:20 PST
Comment on attachment 387119 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=387119&action=review

r=me with fix.

> ChangeLog:17
> +2020-01-08  Keith Miller  <keith_miller@apple.com>
> +
> +        Fix testing Makefile to inherit preprocessor definitions
> +        https://bugs.webkit.org/show_bug.cgi?id=205940
> +
> +        Reviewed by NOBODY (OOPS!).
> +
> +        * Makefile.shared:

Remove dupe ChangeLog.
Comment 4 Keith Miller 2020-01-08 12:08:05 PST
Created attachment 387126 [details]
Patch for landing
Comment 5 WebKit Commit Bot 2020-01-08 13:17:59 PST
The commit-queue encountered the following flaky tests while processing attachment 387126 [details]:

fetch/fetch-worker-crash.html bug 187257 (author: youennf@gmail.com)
The commit-queue is continuing to process your patch.
Comment 6 WebKit Commit Bot 2020-01-08 13:18:50 PST
Comment on attachment 387126 [details]
Patch for landing

Clearing flags on attachment: 387126

Committed r254219: <https://trac.webkit.org/changeset/254219>
Comment 7 WebKit Commit Bot 2020-01-08 13:18:52 PST
All reviewed patches have been landed.  Closing bug.
Comment 8 Radar WebKit Bug Importer 2020-01-08 13:19:13 PST
<rdar://problem/58419206>