Tell web developers to switch to IndexedDB.
Created attachment 353134 [details] Patch
Comment on attachment 353134 [details] Patch Attachment 353134 [details] did not pass mac-ews (mac): Output: https://webkit-queues.webkit.org/results/9732912 New failing tests: http/tests/security/cross-origin-websql-allowed.html http/tests/security/storage-blocking-loosened-websql.html http/tests/security/same-origin-websql-blocked.html fast/frames/sandboxed-iframe-storage.html http/tests/storage/callbacks-are-called-in-correct-context.html js/dom/callback-function-with-handle-event.html inspector/runtime/CommandLineAPI-inspect.html storage/websql/open-database-while-transaction-in-progress.html fast/history/page-cache-webdatabase-no-transaction-db.html js/dom/exceptions-thrown-in-callbacks.html storage/websql/multiple-databases-garbage-collection.html http/tests/security/storage-blocking-strengthened-websql.html http/tests/security/cross-origin-websql.html fast/dom/MutationObserver/database-callback-delivery.html storage/websql/private-browsing-noread-nowrite.html
Created attachment 353141 [details] Archive of layout-test-results from ews103 for mac-sierra The attached test failures were seen while running run-webkit-tests on the mac-ews. Bot: ews103 Port: mac-sierra Platform: Mac OS X 10.12.6
Comment on attachment 353134 [details] Patch Attachment 353134 [details] did not pass mac-wk2-ews (mac-wk2): Output: https://webkit-queues.webkit.org/results/9732934 New failing tests: http/tests/security/cross-origin-websql-allowed.html http/tests/security/storage-blocking-loosened-websql.html http/tests/security/same-origin-websql-blocked.html http/tests/storage/callbacks-are-called-in-correct-context.html js/dom/callback-function-with-handle-event.html fast/history/page-cache-webdatabase-no-transaction-db.html js/dom/exceptions-thrown-in-callbacks.html http/tests/security/storage-blocking-strengthened-websql.html http/tests/security/cross-origin-websql.html fast/dom/MutationObserver/database-callback-delivery.html inspector/runtime/CommandLineAPI-inspect.html
Created attachment 353142 [details] Archive of layout-test-results from ews106 for mac-sierra-wk2 The attached test failures were seen while running run-webkit-tests on the mac-wk2-ews. Bot: ews106 Port: mac-sierra-wk2 Platform: Mac OS X 10.12.6
Comment on attachment 353134 [details] Patch Attachment 353134 [details] did not pass win-ews (win): Output: https://webkit-queues.webkit.org/results/9733038 New failing tests: http/tests/security/same-origin-websql-blocked.html
Created attachment 353146 [details] Archive of layout-test-results from ews200 for win-future The attached test failures were seen while running run-webkit-tests on the win-ews. Bot: ews200 Port: win-future Platform: CYGWIN_NT-6.1-2.9.0-0.318-5-3-x86_64-64bit
Comment on attachment 353134 [details] Patch Attachment 353134 [details] did not pass ios-sim-ews (ios-simulator-wk2): Output: https://webkit-queues.webkit.org/results/9732993 New failing tests: http/tests/security/cross-origin-websql-allowed.html http/tests/security/storage-blocking-loosened-websql.html http/tests/security/same-origin-websql-blocked.html js/dom/callback-function-with-handle-event.html fast/history/page-cache-webdatabase-no-transaction-db.html js/dom/exceptions-thrown-in-callbacks.html http/tests/security/storage-blocking-strengthened-websql.html http/tests/security/cross-origin-websql.html fast/dom/MutationObserver/database-callback-delivery.html storage/websql/private-browsing-noread-nowrite.html
Created attachment 353149 [details] Archive of layout-test-results from ews126 for ios-simulator-wk2 The attached test failures were seen while running run-webkit-tests on the ios-sim-ews. Bot: ews126 Port: ios-simulator-wk2 Platform: Mac OS X 10.13.6
Comment on attachment 353134 [details] Patch Attachment 353134 [details] did not pass mac-debug-ews (mac): Output: https://webkit-queues.webkit.org/results/9733570 New failing tests: http/tests/security/cross-origin-websql-allowed.html storage/websql/private-browsing-noread-nowrite.html http/tests/security/storage-blocking-loosened-websql.html http/tests/security/same-origin-websql-blocked.html fast/frames/sandboxed-iframe-storage.html http/tests/storage/callbacks-are-called-in-correct-context.html storage/websql/open-database-while-transaction-in-progress.html js/dom/callback-function-with-handle-event.html fast/history/page-cache-webdatabase-no-transaction-db.html js/dom/exceptions-thrown-in-callbacks.html storage/websql/multiple-databases-garbage-collection.html http/tests/security/storage-blocking-strengthened-websql.html http/tests/security/cross-origin-websql.html fast/dom/MutationObserver/database-callback-delivery.html inspector/runtime/CommandLineAPI-inspect.html
Created attachment 353154 [details] Archive of layout-test-results from ews116 for mac-sierra The attached test failures were seen while running run-webkit-tests on the mac-debug-ews. Bot: ews116 Port: mac-sierra Platform: Mac OS X 10.12.6
Created attachment 353196 [details] Patch
Comment on attachment 353196 [details] Patch Attachment 353196 [details] did not pass mac-ews (mac): Output: https://webkit-queues.webkit.org/results/9742085 New failing tests: http/tests/storage/callbacks-are-called-in-correct-context.html
Created attachment 353201 [details] Archive of layout-test-results from ews102 for mac-sierra The attached test failures were seen while running run-webkit-tests on the mac-ews. Bot: ews102 Port: mac-sierra Platform: Mac OS X 10.12.6
Created attachment 353203 [details] Patch
Comment on attachment 353203 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=353203&action=review > Source/WebCore/Modules/webdatabase/DOMWindowWebDatabase.cpp:48 > + document->addConsoleMessage(MessageSource::Storage, MessageLevel::Warning, "Web SQL will be deprecated in WebKit. Please change over to IndexedDB."); will be => is
(In reply to Daniel Bates from comment #16) > Comment on attachment 353203 [details] > Patch > > View in context: > https://bugs.webkit.org/attachment.cgi?id=353203&action=review > > > Source/WebCore/Modules/webdatabase/DOMWindowWebDatabase.cpp:48 > > + document->addConsoleMessage(MessageSource::Storage, MessageLevel::Warning, "Web SQL will be deprecated in WebKit. Please change over to IndexedDB."); > > will be => is Also, no need to mention WebKit as it is obvious to the audience.
(In reply to Daniel Bates from comment #17) > (In reply to Daniel Bates from comment #16) > > Comment on attachment 353203 [details] > > Patch > > > > View in context: > > https://bugs.webkit.org/attachment.cgi?id=353203&action=review > > > > > Source/WebCore/Modules/webdatabase/DOMWindowWebDatabase.cpp:48 > > > + document->addConsoleMessage(MessageSource::Storage, MessageLevel::Warning, "Web SQL will be deprecated in WebKit. Please change over to IndexedDB."); > > > > will be => is > > Also, no need to mention WebKit as it is obvious to the audience. Web SQL has not been dropped yet. Should I use "is" here?
(In reply to Sihui Liu from comment #18) > (In reply to Daniel Bates from comment #17) > > (In reply to Daniel Bates from comment #16) > > > Comment on attachment 353203 [details] > > > Patch > > > > > > View in context: > > > https://bugs.webkit.org/attachment.cgi?id=353203&action=review > > > > > > > Source/WebCore/Modules/webdatabase/DOMWindowWebDatabase.cpp:48 > > > > + document->addConsoleMessage(MessageSource::Storage, MessageLevel::Warning, "Web SQL will be deprecated in WebKit. Please change over to IndexedDB."); > > > > > > will be => is > > > > Also, no need to mention WebKit as it is obvious to the audience. > > Web SQL has not been dropped yet. Should I use "is" here? Are you planning to keep this message after its been removed?
(In reply to Daniel Bates from comment #19) > (In reply to Sihui Liu from comment #18) > > (In reply to Daniel Bates from comment #17) > > > (In reply to Daniel Bates from comment #16) > > > > Comment on attachment 353203 [details] > > > > Patch > > > > > > > > View in context: > > > > https://bugs.webkit.org/attachment.cgi?id=353203&action=review > > > > > > > > > Source/WebCore/Modules/webdatabase/DOMWindowWebDatabase.cpp:48 > > > > > + document->addConsoleMessage(MessageSource::Storage, MessageLevel::Warning, "Web SQL will be deprecated in WebKit. Please change over to IndexedDB."); > > > > > > > > will be => is > > > > > > Also, no need to mention WebKit as it is obvious to the audience. > > > > Web SQL has not been dropped yet. Should I use "is" here? > > Are you planning to keep this message after its been removed? *keep this message or a variant of it after Web SQL has been removed?
(In reply to Sihui Liu from comment #18) > (In reply to Daniel Bates from comment #17) > > (In reply to Daniel Bates from comment #16) > > > Comment on attachment 353203 [details] > > > Patch > > > > > > View in context: > > > https://bugs.webkit.org/attachment.cgi?id=353203&action=review > > > > > > > Source/WebCore/Modules/webdatabase/DOMWindowWebDatabase.cpp:48 > > > > + document->addConsoleMessage(MessageSource::Storage, MessageLevel::Warning, "Web SQL will be deprecated in WebKit. Please change over to IndexedDB."); > > > > > > will be => is > > > > Also, no need to mention WebKit as it is obvious to the audience. > > Web SQL has not been dropped yet. Should I use "is" here? I think “is” is appropriate here. They way this message is worded means this message is a notice of a future deprecation notice (I.e. a notice of a notice). One notice seems sufficient.
(In reply to Daniel Bates from comment #21) > (In reply to Sihui Liu from comment #18) > > (In reply to Daniel Bates from comment #17) > > > (In reply to Daniel Bates from comment #16) > > > > Comment on attachment 353203 [details] > > > > Patch > > > > > > > > View in context: > > > > https://bugs.webkit.org/attachment.cgi?id=353203&action=review > > > > > > > > > Source/WebCore/Modules/webdatabase/DOMWindowWebDatabase.cpp:48 > > > > > + document->addConsoleMessage(MessageSource::Storage, MessageLevel::Warning, "Web SQL will be deprecated in WebKit. Please change over to IndexedDB."); > > > > > > > > will be => is > > > > > > Also, no need to mention WebKit as it is obvious to the audience. > > > > Web SQL has not been dropped yet. Should I use "is" here? > > I think “is” is appropriate here. They way this message is worded means this > message is a notice of a future deprecation notice (I.e. a notice of a > notice). One notice seems sufficient. +1 for “is deprecated”.
Created attachment 353292 [details] Patch
Comment on attachment 353292 [details] Patch So I think our typical message is that "X is deprecated. Please use Y instead". See examples for ApplicationCache, CSSKeyframesRule::insertRule, XMLHttpRequest::send(ArrayBuffer&), etc... For consistency, we should do the same. r=me with that message change.
Created attachment 353377 [details] Patch for landing
The commit-queue encountered the following flaky tests while processing attachment 353377 [details]: fetch/fetch-worker-crash.html bug 187257 (author: youennf@gmail.com) The commit-queue is continuing to process your patch.
Comment on attachment 353377 [details] Patch for landing Clearing flags on attachment: 353377 Committed r237591: <https://trac.webkit.org/changeset/237591>
All reviewed patches have been landed. Closing bug.
<rdar://problem/45672606>