Bug 205420 - Resync web-platform-tests/dom tests from upstream
Summary: Resync web-platform-tests/dom tests from upstream
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Tools / Tests (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Chris Dumez
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2019-12-18 15:09 PST by Chris Dumez
Modified: 2019-12-19 09:16 PST (History)
9 users (show)

See Also:


Attachments
Patch (115.80 KB, patch)
2019-12-18 15:14 PST, Chris Dumez
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Chris Dumez 2019-12-18 15:09:30 PST
Resync web-platform-tests/dom tests from upstream.
Comment 1 Chris Dumez 2019-12-18 15:14:05 PST
Created attachment 386015 [details]
Patch
Comment 2 Ryosuke Niwa 2019-12-18 20:57:29 PST
Comment on attachment 386015 [details]
Patch

rs=me
Comment 3 WebKit Commit Bot 2019-12-18 22:34:02 PST
The commit-queue encountered the following flaky tests while processing attachment 386015 [details]:

fetch/fetch-worker-crash.html bug 187257 (author: youennf@gmail.com)
The commit-queue is continuing to process your patch.
Comment 4 WebKit Commit Bot 2019-12-18 22:35:45 PST
Comment on attachment 386015 [details]
Patch

Clearing flags on attachment: 386015

Committed r253738: <https://trac.webkit.org/changeset/253738>
Comment 5 WebKit Commit Bot 2019-12-18 22:35:46 PST
All reviewed patches have been landed.  Closing bug.
Comment 6 Radar WebKit Bug Importer 2019-12-18 22:36:18 PST
<rdar://problem/58069617>
Comment 7 Truitt Savell 2019-12-19 09:12:00 PST
This update made imported/w3c/web-platform-tests/dom/events/Event-dispatch-redispatch.html fail constantly on iOS

History:
https://results.webkit.org/?suite=layout-tests&test=imported%2Fw3c%2Fweb-platform-tests%2Fdom%2Fevents%2FEvent-dispatch-redispatch.html

Diff:
--- /Volumes/Data/slave/ios-simulator-13-debug-tests-wk2/build/layout-test-results/imported/w3c/web-platform-tests/dom/events/Event-dispatch-redispatch-expected.txt
+++ /Volumes/Data/slave/ios-simulator-13-debug-tests-wk2/build/layout-test-results/imported/w3c/web-platform-tests/dom/events/Event-dispatch-redispatch-actual.txt
@@ -1,7 +1,7 @@
 click me!
 
 FAIL Redispatching DOMContentLoaded event after being dispatched assert_true: Received DOMContentLoaded event should be trusted before redispatching expected true got false
-FAIL Redispatching mouseup event whose default action dispatches a click event assert_true: Received mouseup event should be trusted before redispatching from click event listener expected true got false
+FAIL Redispatching mouseup event whose default action dispatches a click event assert_true: mouseup and click events should've been fired expected true got false
 PASS Redispatching event which is being dispatched 
-PASS Synthesizing click on button... (button width / height: 62.734375 / 18) 
+PASS Synthesizing click on button... (button width / height: 66.78125 / 20)
Comment 8 Chris Dumez 2019-12-19 09:12:41 PST
(In reply to Truitt Savell from comment #7)
> This update made
> imported/w3c/web-platform-tests/dom/events/Event-dispatch-redispatch.html
> fail constantly on iOS
> 
> History:
> https://results.webkit.org/?suite=layout-tests&test=imported%2Fw3c%2Fweb-
> platform-tests%2Fdom%2Fevents%2FEvent-dispatch-redispatch.html
> 
> Diff:
> ---
> /Volumes/Data/slave/ios-simulator-13-debug-tests-wk2/build/layout-test-
> results/imported/w3c/web-platform-tests/dom/events/Event-dispatch-redispatch-
> expected.txt
> +++
> /Volumes/Data/slave/ios-simulator-13-debug-tests-wk2/build/layout-test-
> results/imported/w3c/web-platform-tests/dom/events/Event-dispatch-redispatch-
> actual.txt
> @@ -1,7 +1,7 @@
>  click me!
>  
>  FAIL Redispatching DOMContentLoaded event after being dispatched
> assert_true: Received DOMContentLoaded event should be trusted before
> redispatching expected true got false
> -FAIL Redispatching mouseup event whose default action dispatches a click
> event assert_true: Received mouseup event should be trusted before
> redispatching from click event listener expected true got false
> +FAIL Redispatching mouseup event whose default action dispatches a click
> event assert_true: mouseup and click events should've been fired expected
> true got false
>  PASS Redispatching event which is being dispatched 
> -PASS Synthesizing click on button... (button width / height: 62.734375 /
> 18) 
> +PASS Synthesizing click on button... (button width / height: 66.78125 / 20)

Looks like we need an iOS specific baseline then.
Comment 9 Chris Dumez 2019-12-19 09:16:12 PST
(In reply to Chris Dumez from comment #8)
> (In reply to Truitt Savell from comment #7)
> > This update made
> > imported/w3c/web-platform-tests/dom/events/Event-dispatch-redispatch.html
> > fail constantly on iOS
> > 
> > History:
> > https://results.webkit.org/?suite=layout-tests&test=imported%2Fw3c%2Fweb-
> > platform-tests%2Fdom%2Fevents%2FEvent-dispatch-redispatch.html
> > 
> > Diff:
> > ---
> > /Volumes/Data/slave/ios-simulator-13-debug-tests-wk2/build/layout-test-
> > results/imported/w3c/web-platform-tests/dom/events/Event-dispatch-redispatch-
> > expected.txt
> > +++
> > /Volumes/Data/slave/ios-simulator-13-debug-tests-wk2/build/layout-test-
> > results/imported/w3c/web-platform-tests/dom/events/Event-dispatch-redispatch-
> > actual.txt
> > @@ -1,7 +1,7 @@
> >  click me!
> >  
> >  FAIL Redispatching DOMContentLoaded event after being dispatched
> > assert_true: Received DOMContentLoaded event should be trusted before
> > redispatching expected true got false
> > -FAIL Redispatching mouseup event whose default action dispatches a click
> > event assert_true: Received mouseup event should be trusted before
> > redispatching from click event listener expected true got false
> > +FAIL Redispatching mouseup event whose default action dispatches a click
> > event assert_true: mouseup and click events should've been fired expected
> > true got false
> >  PASS Redispatching event which is being dispatched 
> > -PASS Synthesizing click on button... (button width / height: 62.734375 /
> > 18) 
> > +PASS Synthesizing click on button... (button width / height: 66.78125 / 20)
> 
> Looks like we need an iOS specific baseline then.

Done in <https://trac.webkit.org/changeset/253756>.