Bug 205830 - Add support for encoding WebCore::Font over IPC for DisplayList::DrawGlyphs
Summary: Add support for encoding WebCore::Font over IPC for DisplayList::DrawGlyphs
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Text (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Wenson Hsieh
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2020-01-06 14:01 PST by Wenson Hsieh
Modified: 2020-01-08 08:33 PST (History)
14 users (show)

See Also:

Attachments
WIP (16.70 KB, patch)
2020-01-06 14:07 PST, Wenson Hsieh 		no flags Details | Formatted Diff | Diff
Patch (20.35 KB, patch)
2020-01-07 14:53 PST, Wenson Hsieh 		no flags Details | Formatted Diff | Diff
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Wenson Hsieh 2020-01-06 14:01:57 PST 
<rdar://problem/57347719>
Comment 1 Wenson Hsieh 2020-01-06 14:07:28 PST Comment hidden (obsolete)
Comment 2 Wenson Hsieh 2020-01-07 14:53:11 PST 
Created attachment 387038 [details]
Patch
Comment 3 Dean Jackson 2020-01-07 15:24:56 PST 
Comment on attachment 387038 [details]
Patch

Can this have a test please?
Comment 4 Wenson Hsieh 2020-01-07 15:47:00 PST 
(In reply to Dean Jackson from comment #3)
> Comment on attachment 387038 [details]
> Patch
> 
> Can this have a test please?

Ah, so these changes should be covered by a number of existing tests in fast/canvas (as well as imported tests) that exercise fillText and strokeText. We don't currently have a mechanism for painting the canvas element using the GPU process, but once that lands in webkit.org/b/204955, we should be able to mark a number of these tests as passing.

Currently, the entire fast/canvas is marked as [ Skip ] in LayoutTests/gpu-process/TestExpectations.
Comment 5 WebKit Commit Bot 2020-01-08 08:32:32 PST 
The commit-queue encountered the following flaky tests while processing attachment 387038 [details]:

fetch/fetch-worker-crash.html bug 187257 (author: youennf@gmail.com)
The commit-queue is continuing to process your patch.
Comment 6 WebKit Commit Bot 2020-01-08 08:33:26 PST 
Comment on attachment 387038 [details]
Patch

Clearing flags on attachment: 387038

Committed r254202: <https://trac.webkit.org/changeset/254202>
Comment 7 WebKit Commit Bot 2020-01-08 08:33:28 PST 
All reviewed patches have been landed.  Closing bug.